From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6445C7EE23 for ; Sun, 11 Jun 2023 12:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C02F86B0072; Sun, 11 Jun 2023 08:30:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8C046B0074; Sun, 11 Jun 2023 08:30:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2C536B0075; Sun, 11 Jun 2023 08:30:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8FC546B0072 for ; Sun, 11 Jun 2023 08:30:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 58958401B9 for ; Sun, 11 Jun 2023 12:30:34 +0000 (UTC) X-FDA: 80890400388.21.0631AC7 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 6755940019 for ; Sun, 11 Jun 2023 12:30:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=GJl0QNiL; spf=pass (imf07.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686486631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IluuocYiQgWfjHeAlzGtmudRQSB681KjbqAV+x9B0v8=; b=TVSeQhKGr/sCTRylKLL+5olgO/6rBiMksfj4qiU7JObcTb2YLD4MO5tzjO2e3L21Mf0+aF x6SgOOlmh7yEjUAuwJeSeo+M/m9Gy2kxJhEHJnJxzu22EoVrU7uHfo5kAVMAUP5AuWTdxI sT0A8fnZuYVmjoWraS03cvEXrjtDBs8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=GJl0QNiL; spf=pass (imf07.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686486631; a=rsa-sha256; cv=none; b=ky3doAsWTDLdi/MAh3mNGA5gZOI143EDxz0bJc3tLOujfzBaDXo0SGUsUn9dQVBCnqg02S mOmqc70U3ut/yfRBFl7PWM4E7buFsMMS28JGNO7dN2hi8ieJbaablIlq9ijIBRBmAdZLKT alESiaKtmg7N9ZH83BwOmHZj9KD1pNo= Received: from [192.168.10.54] (unknown [119.152.150.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id CD7DF660574E; Sun, 11 Jun 2023 13:30:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686486629; bh=HHdqWR2okT6f26fW1zbq1QsrSlpeo2mcJTuQUDuClkw=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=GJl0QNiLNl8GF6nN2GckWewBetb/dGrtGkiHBh94JFUSP2+k5aQa0W5xjSg/pw+g/ kxaJskEwwzEktuXQz7Vg6yr/zV5DQpdpHn4UI8sT495SGgdwOrjeaUJfttfOajX51Y 3NYWqAs6KI2hpAmnNIzTnNJOfrs/uOkyQ26nX2EjWbR+kVlGPiSsbu3EOSDMeQ2XQO 9PDHWknjFVtduWH9or7+6c4Y5XPTW7WH2zzvopdsCtEwYnRG+3yXaFQjS/7vfcHtzH OKl8QYKyqnuP5xOe/lPDuBAWQTLWAt41AcqzTT7KM4DgqvMctVFTSzkSdBdKTr8AdC fxXrHof3yhmAg== Message-ID: <109d9c47-9c0e-e8ca-2bc1-cb741bc45a1b@collabora.com> Date: Sun, 11 Jun 2023 17:30:22 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Muhammad Usama Anjum , Shuah Khan , linux-kernel@vger.kernel.org, Peter Xu , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/1] selftests: mm: uufd-unit-tests: remove a format warning in printf Content-Language: en-US To: Mirsad Todorovac References: <20230610235016.438460-1-mirsad.todorovac@alu.unizg.hr> From: Muhammad Usama Anjum In-Reply-To: <20230610235016.438460-1-mirsad.todorovac@alu.unizg.hr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6755940019 X-Rspam-User: X-Stat-Signature: emsjaygb4upyhd4jg1twymjbm6o8q4j6 X-Rspamd-Server: rspam01 X-HE-Tag: 1686486631-284958 X-HE-Meta: U2FsdGVkX19QtIAr9Nb4FFtMbP1TJiR31y9FGzDLsE1nl9geME1PG51tQJNosLyJhZujDWAeSo0sqlY1mZMHUbCJ7nCuCRLdhcCoDxbyYC7DPVgjL0TBLbpmqpVh68y3/DEC8OMJqigEWIAaM8cfVhB655EfTj1hpHjHTTyhBklSEAb6bQFM2w61pfDTwpwuHSHPPfp5+yzgp6zsOOzkUWKR3Z2H0BjZ+xTkn79fJMLOvx31giDM2rhuyH9W91fyXee39CX3A62mUlvh8QzxJMZbzxuLL7AKxM+ILEA47YykA6ByetpdS3hsDZBbkkCNSgYahfkgFC1nbDsfPAxVbFCD6tmgyZf/lCIGtv3M0mi58GFw5prG708eKkw7HzdtBhMOn+t0N5/3KbOb5AEQvG+s2c0PRW7I45HYF3r/X71PbEnfunL+n88SGBorn5h/rA/PuuOLLJnTT4hQ/n+kptiX0k0rrjKAw9Zax74+GG1axMwn/EPyHcHRq/P7AvDa352WsLixOZOM7cN+G1fQnI6iia2siodnxWwYlWTW+OpBw1ilvC0ynaAlZ/V2UdmiUkrF3XH8joDk0zcphI37PTOWLSM+OKKB9za1WbJphB3KuoWE2vzBC/O3HMZb4wjHLNbWvc57L/PJrZio4uutQdum7sMgsNvYGPIqigT5ngbICvjq/mDWN4YnE3xzn0N6iskFtw4gitzANWC4JOTkqS+MCZ2YJFNSlJFdIpmznTPHxqvHr7tnjlOVDq+3V7CxYhCRsQcMf9xywgLXQgZUWk7+UXnzFCeAXETB2rE2E3e13Mlj05bXQ7lhYk5WouuKt9fNNqOGAr5bBHHOypTAWzBLMxxrT9Nv6oq+OXfrYBVV+VlhbZeUSeHPqsfuVE6MahZV/CP9WbfqryQla0mG/zFPNHgUPr03JCO4sc9vBmK8m6yhVIv/cmi/ZDQHqv/nK00juZ+GplePRnbHW0Q 0a9hu3TK cz1L4RBYdD+9dM9ALLvbmXTG4fYecxdoDabRifV7wB0Zs8G70VLsd/x1+p3bAvdvMULSIirfJhPP/sN2ZsX6oNIyBTG3DrT6F7vhHqLy4maEhP59+HvF9K4hQkhMDXH8z8ZE4HqbArSiZu06+TSTyfzpQfk0U0NjZd0WTZZ7gi2QS6euT6QkjQshdCSIoTlyD5mL7PH+qcUGgo+iguChQ7E6alVhAjEc5E3DbVa8xlYmO+zWRG04lQjFOD1Jua+F+6rN8JZVX7Qe2eXEhIV/QRuzRk+Q2L9jcITTpDe/FYe/UZAV44yGlakx3NW+Pv//Sjfu4tCpFdhw6Vx7EloNW9cUAQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The fix has already been picked up by Andew in mm unstable: https://lore.kernel.org/all/20230607023727.0E011C433D2@smtp.kernel.org On 6/11/23 4:50 AM, Mirsad Todorovac wrote: > GCC 11.3.0 issued warnings about macros and types of arguments [edited]: > > gcc -Wall -I ../tools/testing/selftests/../../.. \ > -I ../tools/testing/selftests/../../../tools/include/uapi \ > -isystem ../usr/include -no-pie uffd-unit-tests.c vm_util.c \ > uffd-common.c -lrt -lpthread -o \ > ../tools/testing/selftests/mm/uffd-unit-tests > uffd-unit-tests.c: In function ‘main’: > uffd-unit-tests.c:1198:41: warning: format not a string literal and no \ > format arguments [-Wformat-security] > 1198 | uffd_test_start(test_name); > | ^~~~~~~~~ > uffd-unit-tests.c:100:24: note: in definition of macro ‘uffd_test_start’ > 100 | printf(__VA_ARGS__); \ > | ^~~~~~~~~~~ > uffd-unit-tests.c:1205:33: warning: format not a string literal and no \ > format arguments [-Wformat-security] > 1205 | uffd_test_skip(errmsg); > | ^~~~~~~~~~~~~~ > > The macros are defined as: > > #define uffd_test_start(...) do { \ > printf("Testing "); \ > printf(__VA_ARGS__); \ > printf("... "); \ > fflush(stdout); \ > } while (0) > > #define uffd_test_skip(...) do { \ > printf("skipped [reason: "); \ > printf(__VA_ARGS__); \ > printf("]\n"); \ > ksft_inc_xskip_cnt(); \ > } while (0) > > Minor workaround, adding "%s" first argument to macro expansion calls seems > to be the easiest way to eliminate the warnings. > > Cc: Peter Xu > Cc: linux-mm@kvack.org > Cc: linux-kselftest@vger.kernel.org > Fixes: 43759d44dc34 ("selftests/mm: add uffdio register ioctls test") > Fixes: 16a45b57cbf2 ("selftests/mm: add framework for uffd-unit-test") > Signed-off-by: Mirsad Todorovac > --- > tools/testing/selftests/mm/uffd-unit-tests.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c > index 269c86768a02..d356dd271c84 100644 > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -1195,14 +1195,14 @@ int main(int argc, char *argv[]) > snprintf(test_name, sizeof(test_name), > "%s on %s", test->name, mem_type->name); > > - uffd_test_start(test_name); > + uffd_test_start("%s", test_name); > if (!uffd_feature_supported(test)) { > uffd_test_skip("feature missing"); > continue; > } > if (uffd_setup_environment(&args, test, mem_type, > &errmsg)) { > - uffd_test_skip(errmsg); > + uffd_test_skip("%s", errmsg); > continue; > } > test->uffd_fn(&args); -- BR, Muhammad Usama Anjum