From: Badari Pulavarty <pbadari@us.ibm.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-mm@kvack.org
Subject: Re: slab fragmentation ?
Date: 05 Oct 2004 11:47:54 -0700 [thread overview]
Message-ID: <1097002074.12861.145.camel@dyn318077bld.beaverton.ibm.com> (raw)
In-Reply-To: <4162ECAD.8090403@colorfullife.com>
On Tue, 2004-10-05 at 11:49, Manfred Spraul wrote:
> Badari Pulavarty wrote:
>
> >>The fix would be simple: kmem_cache_alloc_node must walk through the
> >>list of partial slabs and check if it finds a slab from the correct
> >>node. If it does, then just use that slab instead of allocating a new
> >>one. And statistics must be added to kmem_cache_alloc_node - I forgot
> >>that when I wrote the function.
> >>
> >>
> >
> >I will add more debug to find out if this is happening or not.
> >
> >What stats you want me to update in kmem_cache_alloc_node() ?
> >
> >
> >
> I would just add a printk to confirm our suspicion.
> "kmem_cache_alloc_node called" + dump_stack(). I always use that
> approach, thus I forgot to add proper statistics.
Yep.
[<c01078c2>] dump_stack+0x17/0x1b
[<c0143323>] kmem_cache_alloc_node+0x181/0x186
[<c0143462>] __alloc_percpu+0x65/0xb9
[<c023c03e>] alloc_disk+0x45/0xc8
[<c027fcb5>] sd_probe+0x89/0x341
[<c0232d64>] bus_match+0x35/0x5e
[<c0232dcc>] device_attach+0x3f/0x8f
[<c023305e>] bus_add_device+0x68/0xab
[<c0231ff8>] device_add+0x94/0x12a
[<c027ccbe>] scsi_sysfs_add_sdev+0x3e/0x1bf
[<c027b871>] scsi_add_lun+0x2d9/0x378
[<c027b9b4>] scsi_probe_and_add_lun+0xa4/0x1d1
[<c027bed3>] scsi_report_lun_scan+0x2a0/0x3c2
[<c027c1af>] scsi_scan_target+0xc2/0xeb
[<c027c23c>] scsi_scan_channel+0x64/0x77
[<c027c314>] scsi_scan_host_selected+0xc5/0xff
[<c027c372>] scsi_scan_host+0x24/0x28
[<f8833654>] sdebug_driver_probe+0x94/0xb8 [scsi_debug]
[<c0232d64>] bus_match+0x35/0x5e
[<c0232dcc>] device_attach+0x3f/0x8f
[<c023305e>] bus_add_device+0x68/0xab
[<c0231ff8>] device_add+0x94/0x12a
[<f883348a>] sdebug_add_adapter+0x124/0x1e7 [scsi_debug]
[<f88331cc>] sdebug_add_host_store+0x6b/0x9a [scsi_debug]
[<c0232a7d>] drv_attr_store+0x37/0x39
[<c018e65b>] flush_write_buffer+0x31/0x3e
[<c018e6ab>] sysfs_write_file+0x43/0x52
[<c0157d68>] vfs_write+0xba/0x107
[<c0157e3d>] sys_write+0x35/0x53
[<c0106a89>] sysenter_past_esp+0x52/0x71
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-05 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 23:36 Badari Pulavarty
2004-09-30 3:41 ` Andrew Morton
2004-09-30 4:52 ` badari
2004-09-30 14:49 ` Martin J. Bligh
2004-09-30 14:48 ` Badari Pulavarty
2004-10-03 6:04 ` Manfred Spraul
2004-10-04 15:51 ` Badari Pulavarty
2004-10-04 16:08 ` Manfred Spraul
2004-10-04 17:37 ` Badari Pulavarty
2004-10-05 14:46 ` Badari Pulavarty
2004-10-05 17:58 ` Manfred Spraul
2004-10-05 18:27 ` Badari Pulavarty
2004-10-05 18:49 ` Manfred Spraul
2004-10-05 18:47 ` Badari Pulavarty [this message]
2004-10-05 21:13 ` Badari Pulavarty
2004-10-05 22:11 ` Chen, Kenneth W
2004-10-05 22:18 ` Chen, Kenneth W
2004-10-06 14:58 ` Badari Pulavarty
2004-10-09 14:28 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097002074.12861.145.camel@dyn318077bld.beaverton.ibm.com \
--to=pbadari@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox