From: Dave Hansen <haveblue@us.ibm.com>
To: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
lhms <lhms-devel@lists.sourceforge.net>,
William Lee Irwin III <wli@holomorphy.com>
Subject: Re: [RFC] buddy allocator without bitmap [3/4]
Date: Thu, 26 Aug 2004 08:55:09 -0700 [thread overview]
Message-ID: <1093535709.2984.24.camel@nighthawk> (raw)
In-Reply-To: <412DD34A.70802@jp.fujitsu.com>
> + if (zone->nr_mem_map > 1) {
> + /*
> + * there may be hole in zone's memmap &&
> + * hole is not aligned in this order.
> + * currently, I think CONFIG_VIRTUAL_MEM_MAP
> + * case is only case to reach here.
> + * Is there any other case ?
> + */
> + /*
> + * Is there better call than pfn_valid ?
> + */
> + if (!pfn_valid(zone->zone_start_pfn
> + + (page_idx ^ (1 << order))))
> + break;
> + }
Nice try. How about putting the ia64 code in a macro or header function
that you can #ifdef out on all the other architectures? We used to be
able to see that entire while loop on one screen. That's a bit harder
now.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-08-26 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 12:10 Hiroyuki KAMEZAWA
2004-08-26 15:55 ` Dave Hansen [this message]
2004-08-27 0:05 ` [Lhms-devel] " Hiroyuki KAMEZAWA
2004-08-27 0:15 ` Dave Hansen
2004-08-27 0:42 ` Hiroyuki KAMEZAWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093535709.2984.24.camel@nighthawk \
--to=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox