From: Dave Hansen <haveblue@us.ibm.com>
To: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm <linux-mm@kvack.org>, lhms <lhms-devel@lists.sourceforge.net>
Subject: Re: [Lhms-devel] [RFC] free_area[] bitmap elimination [0/3]
Date: Mon, 23 Aug 2004 08:43:21 -0700 [thread overview]
Message-ID: <1093275800.3153.825.camel@nighthawk> (raw)
In-Reply-To: <4126B3F9.90706@jp.fujitsu.com>
A few tiny, cosmetic comments on the patch itself:
> }
>
> +
> +
> +
> #endif /* CONFIG_HUGETLB_PAGE */
>
Be careful about adding whitespace like that
> /*
> + * indicates page's order in freelist
> + * order is recorded in inveterd manner.
> + */
The comments around there tend to use a space instead of a tab in
comments like this:
/*
* foo
*/
patch 2:
> area = zone->free_area + current_order;
> if (list_empty(&area->free_list))
> continue;
> -
> page = list_entry(area->free_list.next, struct page, lru);
> list_del(&page->lru);
More whitespace .
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-08-23 15:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-21 2:31 Hiroyuki KAMEZAWA
2004-08-21 2:55 ` William Lee Irwin III
2004-08-21 4:56 ` [Lhms-devel] " Hirokazu Takahashi
2004-08-21 5:21 ` William Lee Irwin III
2004-08-21 5:37 ` Hiroyuki KAMEZAWA
2004-08-21 5:37 ` William Lee Irwin III
2004-08-21 6:10 ` Hiroyuki KAMEZAWA
2004-08-21 17:48 ` William Lee Irwin III
2004-08-21 5:00 ` Hiroyuki KAMEZAWA
2004-08-21 5:01 ` [Lhms-devel] " Hirokazu Takahashi
2004-08-21 5:26 ` Hiroyuki KAMEZAWA
2004-08-21 5:01 ` William Lee Irwin III
2004-08-21 9:43 ` Nigel Cunningham
2004-08-23 14:36 ` [Lhms-devel] " Dave Hansen
2004-08-23 15:00 ` Dave Hansen
2004-08-24 0:07 ` [Lhms-devel] " Hiroyuki KAMEZAWA
2004-08-24 0:00 ` [Lhms-devel] " Hiroyuki KAMEZAWA
2004-08-24 2:28 ` Hirokazu Takahashi
2004-08-24 2:49 ` Dave Hansen
2004-08-24 3:31 ` Hiroyuki KAMEZAWA
2004-08-23 15:43 ` Dave Hansen [this message]
2004-08-24 0:15 ` Hiroyuki KAMEZAWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093275800.3153.825.camel@nighthawk \
--to=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox