From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2597C3DA60 for ; Wed, 17 Jul 2024 20:19:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E0AE6B00BF; Wed, 17 Jul 2024 16:19:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 391C56B00BE; Wed, 17 Jul 2024 16:19:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E41B6B00BF; Wed, 17 Jul 2024 16:19:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F3E266B00BD for ; Wed, 17 Jul 2024 16:19:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C42D161901 for ; Wed, 17 Jul 2024 20:19:24 +0000 (UTC) X-FDA: 82350359448.07.4ADB312 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 3124AA0005 for ; Wed, 17 Jul 2024 20:19:21 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="gL4Q/VUN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7pv+nM1h; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="gL4Q/VUN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7pv+nM1h; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721247517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uG/TL70DOuV6k27FNkLApQMyQ9L09UTancsGn8vY74s=; b=QTxVn67OjKd8MGYf4/8zPNU57V/877KzcrKm1q1Z+wWUpBU/thR/z7RQP+VU3RyGvIg4Ay 7gNDqTTXkPvQ9fOQjR92ugEiaOczD30xM6bPk6czPH9aHK0PkuPoAhfZCDBLABZbBpwJng kOMy9lumOX8GRHh0t4tPOdUD5cqqVS4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721247517; a=rsa-sha256; cv=none; b=JVxEwnDgmKzM/9KqO4FoJgiLYcPSzdbYROVr5aNqbpvWGxil6sMC6h2RPoyGiCUfAhl0M2 54ZlRK0++TTo9JSBlUqGiwJOPwtwTcwzewC/XoCaXlgEKCwOT3YjsBhb1XIS9DxBB7PsE0 kQODEF/3gazWFU/nQDjaY+8FvZTjR7A= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="gL4Q/VUN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7pv+nM1h; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="gL4Q/VUN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7pv+nM1h; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A3FE21C15; Wed, 17 Jul 2024 20:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721247560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uG/TL70DOuV6k27FNkLApQMyQ9L09UTancsGn8vY74s=; b=gL4Q/VUNYNh1EBuTiLZ0+AAirTIo3rHrGjhvRKLWmWzr7vGoReijn1GQ90BF9SATybVnKI IsuD87kCl8kkw3GRVwz3QNjcvAL+BkE3sDKtoX+PYnDPSIecX4zwjZb7GLRakNuc7lLNft Rbh3GBstHspwp1FD/AAmaXJV+Es91Fw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721247560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uG/TL70DOuV6k27FNkLApQMyQ9L09UTancsGn8vY74s=; b=7pv+nM1hqpu1fKKFN6C0dfivqP+CxQwVwJLFWjVML3Y54UN3jeZA8EMZa6/RDo1DpJvKAS iuOr+zX5YG2MVGDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1721247560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uG/TL70DOuV6k27FNkLApQMyQ9L09UTancsGn8vY74s=; b=gL4Q/VUNYNh1EBuTiLZ0+AAirTIo3rHrGjhvRKLWmWzr7vGoReijn1GQ90BF9SATybVnKI IsuD87kCl8kkw3GRVwz3QNjcvAL+BkE3sDKtoX+PYnDPSIecX4zwjZb7GLRakNuc7lLNft Rbh3GBstHspwp1FD/AAmaXJV+Es91Fw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1721247560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uG/TL70DOuV6k27FNkLApQMyQ9L09UTancsGn8vY74s=; b=7pv+nM1hqpu1fKKFN6C0dfivqP+CxQwVwJLFWjVML3Y54UN3jeZA8EMZa6/RDo1DpJvKAS iuOr+zX5YG2MVGDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 120CF1368F; Wed, 17 Jul 2024 20:19:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3xb8A0gnmGa9ZwAAD6G6ig (envelope-from ); Wed, 17 Jul 2024 20:19:20 +0000 Message-ID: <10865b0a-175e-4b90-9042-7b63b1ea19f8@suse.cz> Date: Wed, 17 Jul 2024 22:19:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] alloc_tag: outline and export free_reserved_page() Content-Language: en-US To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, hch@infradead.org, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot References: <20240717181239.2510054-1-surenb@google.com> <20240717181239.2510054-2-surenb@google.com> <16286915-1350-4e6b-a0f6-deec02b7fa92@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Bar: / X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3124AA0005 X-Stat-Signature: 7dpdsr8haqficjgy9gra97pdmfzdtssr X-Rspam-User: X-HE-Tag: 1721247561-18175 X-HE-Meta: U2FsdGVkX1+HEX7fACGa0o3n/YjFGUQuMFs+AyJCRcTGSnGZrsXov1nrqg3PJwtmRHFi/I18gVqkeDCIeRBx9ufGnoEDlA6E2TzTq3WpauGZf2Cbaq0Od9CM/NblERXpLnSLA1gVH7Q7Hds+/ftfF6BBdPKlnakY0YUGAVEtBf6Hc1vHzl4qgq3iJpDXKnQfrjDyjfcgKXp5eiDiSNdRqZSdNGV/IC6LrsqVJ3KNxI35mhMVF6GpJtKGMN4dTNBywYy1Jnan6Byw2gYTvJ44lKbISpnlYXCA1VZVzCRuAPwTkDS9fa875sqZACI+0kekClYhXKjJk3Eh8IOirkCbatOYfLxwmFHCBgkqk2m5i8oyU20Bwkz8mf8KU5DPwfdUNhsq5Ycdwd/FrCu7HNQMylPotQLtIjdNz/MQNc8SgLXBQsutVoHJkjEkhUyCztDcCx6tm7BnXdvHflUQ+dShpc79cauBeb01AqqNv/x+1wRl2qCI3yEc3QrNEWtt071U2fxCK/7rnwnMuFK3BAtqilJ/M5Mrmjmhl1VFhpIvV3Yqmd+dabmYFQyevXFlJrr3TL7Fx5+7JSlnntCDCREMYpyzohMblh5JxVjfJeQ3OOCuIvXK/JIKlRENnpAz7WrvboX2v4y5IE07psn0hLpDomonfabjonJGE7nd7ZQs6fpc1CgAOOh/b2GDWIspXBbX1GpkriNpSMBZXK9CKI2HZpm6k+UdTXB3xrepmozg6H1jvSgtPQtdWh8z1TN+pNSWqynCY6eaimYHhickDgbgU/NLYyuuTzCbvSUgFm+k1lwViDlXlZY5PcqrvLP0qeo2VKtWcvj6MAtKFzw2Vj6T2xB88pBMC44bQ5fjiEuu/dsD7/CCeVlzv9CjkFqFHPVq9MO8u4dbqkDUG0gc7N3X8nYsVNNO545sHnE6c09eziIKzvVumfwovFdmi+AKFD8kHTavEk23e+yRg3tTbAm F0EGlw58 YwUUjVk4iG1Sylxn5+BE0VKfo+uzeoYZ8HutUd/MID2tAXr8o0Qyv8Ue1lEjAu0moXB/fqyNdhr+B9qaDw22t+oy7eUmqn5ik4IiwXJN0HqzEZ6jCfgN+fj6isX55U+bTiisZA8mYcmp8oyn2zCajdzv/m0mTmmznIDcWUH0mJwKzYH2CZA1Ig1VIBXFCdNdiIxvP0cy8PwWwg7J83w+VRiSvm1a7EnPag6++bUYCLej2Z20vG7OPN0YOLrmO7YX+5FiRhtqAJZYQEeMQBheokuTTKVZbt563G6l2tfkdVbYxXfeT6bNFWARRM5MZOj5CkfZeAaI71g6MBR5NOqLMMufJb/PhCrMFI4jL72BAAcoEP45WnLw7GILVOjjR+8xzc18qyY+j/UlBHR+Vdt2UHktFxWQAyVadaEEBo66vOk6iT8KHJAbNiL7CX0WT+KjYbGUAvy9dPeWeaxb46OyQa4Sh0E78MUPenvjnAKHgP1bO3EUuciStFOVkIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/17/24 10:04 PM, Suren Baghdasaryan wrote: > On Wed, Jul 17, 2024 at 12:36 PM Vlastimil Babka wrote: >> >> On 7/17/24 8:12 PM, Suren Baghdasaryan wrote: >> > Outline and export free_reserved_page() because modules use it and it >> > in turn uses page_ext_{get|put} which should not be exported. The same >> > result could be obtained by outlining {get|put}_page_tag_ref() but that >> > would have higher performance impact as these functions are used in >> > more performance critical paths. >> > >> > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging") >> > Reported-by: kernel test robot >> > Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/ >> > Suggested-by: Christoph Hellwig >> > Suggested-by: Vlastimil Babka >> > Signed-off-by: Suren Baghdasaryan >> >> Acked-by: Vlastimil Babka >> >> Are these two patches now stable@ material as 6.10 build is broken on ppc64 >> with alloc taging enabled? > > I tested them with that specific configuration mentioned in the bug > report and with several usual ones I use. > Yeah, I guess from now on all such fixes should have > > Cc: stable@vger.kernel.org # v6.10 Right. BTW I have just realized that the way you did Patch 2/2 and outlined the whole free_reserved_page() (which is fair, it's an init-time function), mem_alloc_profiling_enabled() didn't stay inlined so Patch 1/2 is in fact not necessary anymore?