From: Vlastimil Babka <vbabka@suse.cz>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev,
hch@infradead.org, pasha.tatashin@soleen.com,
souravpanda@google.com, keescook@chromium.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 2/2] alloc_tag: outline and export free_reserved_page()
Date: Wed, 17 Jul 2024 22:19:19 +0200 [thread overview]
Message-ID: <10865b0a-175e-4b90-9042-7b63b1ea19f8@suse.cz> (raw)
In-Reply-To: <CAJuCfpG2uNicytRYhfqAKrfkxJoNLUUK_o066D=yKggsoc3wKQ@mail.gmail.com>
On 7/17/24 10:04 PM, Suren Baghdasaryan wrote:
> On Wed, Jul 17, 2024 at 12:36 PM Vlastimil Babka <vbabka@suse.cz> wrote:
>>
>> On 7/17/24 8:12 PM, Suren Baghdasaryan wrote:
>> > Outline and export free_reserved_page() because modules use it and it
>> > in turn uses page_ext_{get|put} which should not be exported. The same
>> > result could be obtained by outlining {get|put}_page_tag_ref() but that
>> > would have higher performance impact as these functions are used in
>> > more performance critical paths.
>> >
>> > Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging")
>> > Reported-by: kernel test robot <lkp@intel.com>
>> > Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/
>> > Suggested-by: Christoph Hellwig <hch@infradead.org>
>> > Suggested-by: Vlastimil Babka <vbabka@suse.cz>
>> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
>>
>> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>>
>> Are these two patches now stable@ material as 6.10 build is broken on ppc64
>> with alloc taging enabled?
>
> I tested them with that specific configuration mentioned in the bug
> report and with several usual ones I use.
> Yeah, I guess from now on all such fixes should have
>
> Cc: stable@vger.kernel.org # v6.10
Right. BTW I have just realized that the way you did Patch 2/2 and outlined
the whole free_reserved_page() (which is fair, it's an init-time function),
mem_alloc_profiling_enabled() didn't stay inlined so Patch 1/2 is in fact
not necessary anymore?
next prev parent reply other threads:[~2024-07-17 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 18:12 [PATCH v2 1/2] alloc_tag: export mem_alloc_profiling_key used by modules Suren Baghdasaryan
2024-07-17 18:12 ` [PATCH v2 2/2] alloc_tag: outline and export free_reserved_page() Suren Baghdasaryan
2024-07-17 19:35 ` Vlastimil Babka
2024-07-17 20:04 ` Suren Baghdasaryan
2024-07-17 20:19 ` Vlastimil Babka [this message]
2024-07-17 21:20 ` Suren Baghdasaryan
2024-07-17 21:30 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10865b0a-175e-4b90-9042-7b63b1ea19f8@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=pasha.tatashin@soleen.com \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox