From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] ppc64: Fix possible race with set_pte on a present PTE From: Benjamin Herrenschmidt In-Reply-To: <1085544720.5580.9.camel@gaston> References: <1085369393.15315.28.camel@gaston> <1085371988.15281.38.camel@gaston> <1085373839.14969.42.camel@gaston> <20040525034326.GT29378@dualathlon.random> <20040525114437.GC29154@parcelfarce.linux.theplanet.co.uk> <20040525153501.GA19465@foobazco.org> <20040525102547.35207879.davem@redhat.com> <20040525105442.2ebdc355.davem@redhat.com> <1085521251.24948.127.camel@gaston> <1085522860.15315.133.camel@gaston> <1085530867.14969.143.camel@gaston> <1085541906.14969.412.camel@gaston> <1085544720.5580.9.camel@gaston> Content-Type: text/plain Message-Id: <1085545114.5578.11.camel@gaston> Mime-Version: 1.0 Date: Wed, 26 May 2004 14:18:34 +1000 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Linus Torvalds Cc: "David S. Miller" , wesolows@foobazco.org, willy@debian.org, Andrea Arcangeli , Andrew Morton , Linux Kernel list , mingo@elte.hu, bcrl@kvack.org, linux-mm@kvack.org, Linux Arch list List-ID: On Wed, 2004-05-26 at 14:12, Benjamin Herrenschmidt wrote: > On Wed, 2004-05-26 at 14:08, Linus Torvalds wrote: > > > You're right. We do use it on the do_wp_page() path, and there we actually > > use a whole new page in the "break_cow()" case. That case is in fact > > fundamentally different from the other ones. > > > > So we should probably break up the "ptep_establish()" into its two pieces, > > since the callers don't actually want to do the same thing. One really > > wants to do a "clear old one, set a totally new one", and the two other > > places want to actually update just the dirty and accessed bits. Hrm... Still dies, some kind of loop it seems, I'll have a look Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org