From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8071BC61DA4 for ; Sat, 18 Feb 2023 09:18:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B33AB6B0071; Sat, 18 Feb 2023 04:18:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE39D6B0072; Sat, 18 Feb 2023 04:18:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AB336B0073; Sat, 18 Feb 2023 04:18:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8AA9A6B0071 for ; Sat, 18 Feb 2023 04:18:26 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5613B120A51 for ; Sat, 18 Feb 2023 09:18:26 +0000 (UTC) X-FDA: 80479861812.28.9046BD1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9C5BF140006 for ; Sat, 18 Feb 2023 09:18:23 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dfSxNkFO; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676711903; a=rsa-sha256; cv=none; b=yCp7V396GHgpIWWJIvMQq0eWpE5g6XskknrVqjwir06BF9VvxfnvN5J2PfnbUUAvX616jt rG2dpghz9bg9fObJTzVxaiBXM7nXfSdtbKYljR3mYWOTU2cwrEh0n06PaoefojGJCCFiEr lsd6MfZp3o6uETVGL3jcCVuhzzsdrU0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dfSxNkFO; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676711903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R3BrmhBgQgWTKEiCYwN2vM7iyjzhHhTKrOpbAg9oclw=; b=LkHUjXihb8gID2wMhcpNpc+tnviSURmg40aFFMZA6WZsFws2asOUA8CLknstnJPMJ1agtm w4eZNaKKEqOYmV6tXlLQd5WUwTVuF1DsCFlPgv2rMLCZOJ2+AAClsWO/HYK2TahCjI3rXe 2AdZ3Kts+caMciT0VauSXXp9tjDioMc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676711902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R3BrmhBgQgWTKEiCYwN2vM7iyjzhHhTKrOpbAg9oclw=; b=dfSxNkFOrr78CsHbeVAs1ywoAnzFXwMuX7oNXCHFtreATrY7q81+HlNWj9NJBf3Q5tnj0j ze3hfUHl/eW0IEv72/FDyXUXieuWjTkZdDX1tSpyosUnHvO81VvblYrpnaPo8DumRd1y/o cobLnJomx/xDdyUeUPIRXYYWi3M1CX0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-325-J1y4fjxvOBaocJW_UBOeNQ-1; Sat, 18 Feb 2023 04:18:17 -0500 X-MC-Unique: J1y4fjxvOBaocJW_UBOeNQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84A2980352D; Sat, 18 Feb 2023 09:18:16 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F7A6492B00; Sat, 18 Feb 2023 09:18:13 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <87a61b9y20.fsf@oc8242746057.ibm.com> References: <87a61b9y20.fsf@oc8242746057.ibm.com> <87a61ckowk.fsf@oc8242746057.ibm.com> <732891.1676670463@warthog.procyon.org.uk> To: Alexander Egorenkov Cc: dhowells@redhat.com, axboe@kernel.dk, david@redhat.com, hch@infradead.org, hch@lst.de, hdanton@sina.com, jack@suse.cz, jgg@nvidia.com, jhubbard@nvidia.com, jlayton@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, logang@deltatee.com, viro@zeniv.linux.org.uk, willy@infradead.org, Marc Hartmayer Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1085543.1676711893.1@warthog.procyon.org.uk> Date: Sat, 18 Feb 2023 09:18:13 +0000 Message-ID: <1085544.1676711893@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Queue-Id: 9C5BF140006 X-Rspamd-Server: rspam01 X-Stat-Signature: 4r141zkofboa5a7eje6xh5ugbfgbjjhi X-HE-Tag: 1676711903-367779 X-HE-Meta: U2FsdGVkX18vexuZbJvkaSqk1DexjZqjGsZZlWToW1xFo8DpFaNmFpx+oOCuSSXvTtldj2iRGRKNPs+8tiqKDrDha7ozq9tHn7tFYRrN2pBpSWADxK+GRmdGyuXdMKeoUD+4lJeAlQJ5os9CXT2IbRYGOyI6cmA7Tify3YVot/xVzXkjH/bt/YSp5gUFGo5oFkZ+QlG43J2UhVZpK3dr2hBiQJ3WlG2xcTt44oEM2tZvuZL4EAw0P28S+18GdL6ty1jbi2wTXIbgO5OWhhLG4AO83k8hkU5XpR0YfvCQvMEXTTkx9f3ElwcT3cUrLISoNdOAlHiWTSj3Fx1zz2h3BeOCERaXabF5Iz8wYwZBWhOAWceN3Cyb6zEIb3hvRYXePD+fPhOmZjHnqHRToaFkiliMI6LeKcVm5R4X7OCeyBbDovemS3KZJ3lH2iBAWTmyAlg/SV4WvXvxla82sD7Nvui7zngWQNxqWgO4OaQMT/46RFqz8++v/W5z9lCkmWXPbBL7myKjew4mt6BIRTI0ZMJgOK1J3muzT5IU37R4LuVQOPQVOsXCSIPq6t637Ijfgn+uP1+NBGPbjnK5gYhuLu0lvMtkN0qRp5bFrZjX0fAz5BiDxudGqwPQzxEia0g2JuQ7DU935qNlDnLusR73gvcEeJMekbQJHTdMQwyESwHBgTPNhYFwbzg4p8iJJXJABvEkcYiFk6Zn2Ib1kkndjflU0imSQVMs4+e9XpXUgmbUbqAzWwqRbhgGl/HQU0dH3vWPKzGlPGQctpgGQhglcMmDLYaFpSe7CEitOubCRPfRoqnBB58gEsOyymAwAMBVBOrpAIO9diVGTKZgAkCf3kPWwKWWRNerNWBDql4vvXE7vp8xx5NakWkppNL739MdCdLcoZhiS3nWaNVdGc+/nb7VjEeUVOMUuevEEK4ZVCEHSd00PEmaHkJYo9L6GRF954FIMh9zTpVmz+cvDwD 8dS841+X U3NgbTMlD7gtJvxjxf26rhg8qhB9SmiaGbTRgERWl77jfnRsgLX2gDkHwp6aES3+N+jGYPMYiVYk2wdH3+liheLFQ/V8U/OR/juZNZVgh2/6DcSSBW+VYcE+cLvbTGs7wcWP5Vk9xc0tKF4CAyz0dvpJMXUfmJpeJ1auiaKRdt8jRjuQvQzKMpZI320D6cVXWXKx0jJEhBVZFWjco0yVOjKCzRANRFAXl5hTi82odN3keEEC1UiR+oAkQ6yOxf66slDhArLJu6ZLsg7LqrGuS1YQVDB7FHxkh2NnrLBd/PMqAdCk/FpFbSw6iE5P6AmPTqhSvuPMvXlqSyd0wOaAjZWirIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alexander Egorenkov wrote: > > + n = min_t(loff_t, len, isize - *ppos); > > + n = splice_folio_into_pipe(pipe, folio, *ppos, n); > > if (!n) > > goto out; > > len -= n; > > Yes, this change fixed the problem. Thanks! David