From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41014E7718D for ; Fri, 20 Dec 2024 18:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA676B0092; Fri, 20 Dec 2024 13:31:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6AAB6B0093; Fri, 20 Dec 2024 13:31:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6E396B0095; Fri, 20 Dec 2024 13:31:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 80A966B0092 for ; Fri, 20 Dec 2024 13:31:13 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F013E1C7DAC for ; Fri, 20 Dec 2024 18:31:11 +0000 (UTC) X-FDA: 82916178744.15.F2ED1CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 965DF20021 for ; Fri, 20 Dec 2024 18:30:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BLMqnjuv; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734719437; a=rsa-sha256; cv=none; b=sRbNLBXYRAOr1sVUdkZlAtn50TY/3chC4CiYLPH6ZBkihOte8rOFnFKUD+yZJU+sXeLbm6 d1bJpOYAZSAuvz25RQ3w2BVCy5zI0tUS3PwpDYta4CVm97uxPO8WR+S2KmfoH36Nl4+fBr VQh+wyIQ8JeP+4n8dCiJbV3nNfWU5OU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BLMqnjuv; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734719437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PN5EVM1NmukZNXj0qpicok/RL7e9UE7DI/QNZtLqqyY=; b=rWmDGbRZZVcxdE7O1h1vbm7WhgOlttfIIvOIGAIREC5PVr+p8oeZzc3L65Hbu6PEadNPoP LeJbvBUrf0T/aweyQ18O9a1ZmDdJvpbjzO1Umo/xjVlzu6MBqz5GyAE6TM3R8gpafLlOEo 49iWkvbHnE78YGKodNuDy6JSDukMo0w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734719468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PN5EVM1NmukZNXj0qpicok/RL7e9UE7DI/QNZtLqqyY=; b=BLMqnjuvwG9+dHuVDlzBLumbSZ8r3qKYjxrFuoON9Q65T/Ap5OlqR5zyyNP263RhgWEJPx u2d7b4DGGz9MBjBvoNAJoFH4SpoGSMGePs6rQHQOOTCAtl7IJbFWxdcPedrfswBpa7Wmqc BB6TNKtfcjss5W0vOx/VE+c0YWI+YlQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-c9zaN8vlMWmjVsWHfufWvg-1; Fri, 20 Dec 2024 13:31:07 -0500 X-MC-Unique: c9zaN8vlMWmjVsWHfufWvg-1 X-Mimecast-MFC-AGG-ID: c9zaN8vlMWmjVsWHfufWvg Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385e49efd59so1121262f8f.0 for ; Fri, 20 Dec 2024 10:31:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734719466; x=1735324266; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PN5EVM1NmukZNXj0qpicok/RL7e9UE7DI/QNZtLqqyY=; b=IwHpn0RUQLqwEegSRijgfXvzKPZDQPc3cJWEpl8/XQsxYlg2OY1OwyXJVwhT+vijlj XFnIATOEOacg4nXME85Ln02v90e2EbqG+okPpMuM3xHBUnfTbWnvZH1SXZuzegKh6V7K jxoP0+tY/hUzQCs7CdD/lVAXO5zdRL2WiUOgBQILpP39Mw88z21zjlMIfqycx7mpCznt us92TOQ5B10v0xneUN/hAjKrfdhw49vYr5FhwWxWjb4NlmG4+/RhX2GaINW08hIcfVjt Zv+ioHspbyGMT0za/q2kN5wGpljF/RGaTjQSDI1+wROvQq5UjbkN/et9smd/7gnO3DMb Qn5g== X-Forwarded-Encrypted: i=1; AJvYcCUyAyRzmZcMsxhRPAaWBrCNRGjMwjCGdk0msM91vAsd+RryQU+hgkDZMWVpO3aMyv4SG0r4mJbxig==@kvack.org X-Gm-Message-State: AOJu0Yxu1UQGMNpSBvQeRyiamtcyYhVREQMhw6i5rPMqnrQFqbO+gEJF qdxZAnBMxCHSZ4jlUg5d7BGTZJBAIVatunRswOSQSDYoBO5HnWxpifu6qUwHUI8w30crYPu8afp FUMIzPreS/eDiUIpwrTZBbHkyyRJEbIO3BX+tUfc4OwDNEyg4 X-Gm-Gg: ASbGncsghtWM4nRuYMxB7PuwTINtmSqNMhwGD+4F7gakm6BLhE/myTJnFXJNZ0AKj4w uqwCWBR6+G48nvVQPEtXayBK4OjoD4SUNyl4yNMd2Tv2vusqJc6IgoOk5URXBrq+De4OiTMw9iq tDDCx1rl5RvD/2PL323IY+HPI/MNUOIqHJhdelYqmWDaf5VoDlQH8aqklatINHSyypQkij6ql7s Tg/wbaImQ22Dc7ua/pKLiyGrBl7t8z+/yg0G0cdIA7zs5MeqyQDzU6ChZVzRNULlH9cDWWHFbm2 9pBlCJMmP4+f32+ZQep8FG/+1r1fWZxhcO55rBsbOHQv3Uh9omGRYeZG1x7lXRKkVz1Rq3C3Boe cYbcbsrMU X-Received: by 2002:a5d:64c2:0:b0:386:366d:5d0b with SMTP id ffacd0b85a97d-38a22408e8amr3824123f8f.55.1734719466295; Fri, 20 Dec 2024 10:31:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IElxiFyJ9qIUioQdUCoDL6NC0K4joEuaDrLW1M/n6klr2NWFr2HJs9ZJNS8OQoynugK8eIYkQ== X-Received: by 2002:a5d:64c2:0:b0:386:366d:5d0b with SMTP id ffacd0b85a97d-38a22408e8amr3824083f8f.55.1734719465905; Fri, 20 Dec 2024 10:31:05 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c829348sm4641303f8f.22.2024.12.20.10.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 10:31:05 -0800 (PST) Message-ID: <107dacce-87dc-457b-a2e1-e5a4699d66af@redhat.com> Date: Fri, 20 Dec 2024 19:31:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 14/25] rmap: Add support for PUD sized mappings to rmap To: Alistair Popple Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org, lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: <7f739c9e9f0a25cafb76a482e31e632c8f72102e.1734407924.git-series.apopple@nvidia.com> <4b5768b7-96e0-4864-9dbe-88fd1f0e87b8@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DCY98sEu9Ec5YXWv4BUPjPS3EHTKiwj2LeWA8Zi57jQ_1734719466 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 965DF20021 X-Stat-Signature: wn5rgnfq3qhuzgszuiwnrfturbzknagn X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734719453-17487 X-HE-Meta: U2FsdGVkX1+DdfWn4XRWYTWvYUmA9BOEf+mlppmZms+/wKvFqKKDCo5qp+bThmYvWkSiFQsMU0ZBp7uJgi7Y9Xz5o8/X1ay2oN4dSotBhFWhtPO4zCv7tfWESZJyUZ4hW38kR1Ik5qYjdBOK6cdgqNhJ6FNznl7xi8wjLEwWzs6VW5HayYHLRiUzbmCLmbJTk/bDuoZfdYOO8iW0IgZCJKF27sRxSOoHKeFceFMTfF8+0IfcAU9w/NYQlrMnRu690UBZibkwx4sf5GKn9e+IUFbse6C2Vxm7HU0mZQ8GLebLBdSeT+8ajxjatK7bQKanOEMiLWP2CglD9FJ+dF1oMgOYidpH/MzRkOEzlKiclUbNGE9vMFrnE9JJlDztOEz0Yds9B1+1AE7wfQicumvLW4I7r0yAPamvrGYH9VVVi+cKQnVyycCYjb7XbzELMFvIyqOoz0oBEerp5kE4FfbgcuejiIm50e+ibTk6mXYTcD032HjzViZxDoKwyOc938efBZQpYJkWKQxKQL0MUhEpUGrQVKZnraSDbUksvSuXC9l3sMTWYR3n8pK0cMlfmE3b1XParDrIGyt1BkeipL4LmBRZIS420LTyz0YTR5m2V9Tf7f0iS1Haj6gwAm1nTPr9DCAjU9TR/oiVrwOJiWtCzofYDtxdHO6i1g7j4WNeujgT2ib3hoBueE/3E2Yh3DV+PXkzYHIniE5AHRZpJOxx1Mwc8lmcyFPqFqmsD4CAXMYF+Fna5GuW2T7eTsOpfUHgEiYEDOXfi7PZBQCjwhVmufW9gTZGo4NZa+SPYerbEmModanfQsfRJdZOZK661t7mGLP0UT4SwREK9owQyqXXuK7Ku1E40e2k/QXKG+dix6VRIkt7+HGDfl8nYi7ag3ksDes5C+LvIxYzeJtX4SxGdyxEksBi3PQaVR0CpY9SA560atIJhAiGMObxs5JydvAKL/ZQhv24+SCESpUEVPC hRY4Jcc4 eJl0whVB4WD/4E1fgE5qARiOE0CcwRECp6HIMFAblRQwF0oEjuBmOn9D2kvVMqFCUM7obRj2RVwEF9I07aUC0zMBY5rIuA0b7xsVP5Jvm0mVgjTt68mlmIRqFPMxHZN7Ni+JGookT0vMXISv6qR2hEjZSgsHUnBZcEYtuj50Dm2gFRUpHBNzazOWi1cgXOBaFTdhO7gXEcjhVU6Nxgzd59AWjUT6exSmoZmaLsCPzr8BRHcztK3Vlr6xZmaxuarl/L1qWYSc0FO0MMIBn5PmqVdSiBzngJ9mM5HlUrlyLW9aoLD+szQNJ0SmK9bm7xBeQHlgQfKt7WPdHIi2K/EI6mduSPyl3IkTHSMlc/QsHAdRKy9vLVZ/O2J9cQW1bLUl1XcGT8TNrMIwAV3Dskt/kGgUWzU6XXzqmb+xyEz+w8msAo3+5NZOZei7nliiiPU0OwYA5BI3RQmjs89s8DC4aauxjMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.199533, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> return -EBUSY; >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index c6c4d4e..39d0439 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -1203,6 +1203,11 @@ static __always_inline unsigned int __folio_add_rmap(struct folio *folio, >>> } >>> atomic_inc(&folio->_large_mapcount); >>> break; >>> + case RMAP_LEVEL_PUD: >>> + /* We only support entire mappings of PUD sized folios in rmap */ >>> + atomic_inc(&folio->_entire_mapcount); >>> + atomic_inc(&folio->_large_mapcount); >>> + break; >> >> >> This way you don't account the pages at all as mapped, whereby PTE-mapping it >> would? And IIRC, these PUD-sized pages can be either mapped using PTEs or >> using a single PUD. > > Oh good point. I was thinking that because we don't account PUD mappings today > that it would be fine to ignore them. But of course this series means we start > accounting them if mapped with PTEs so agree we should be consistent. > >> I suspect what you want is to > > Yes, I think so. Thanks for the hint. I will be out over the Christmas break but > will do a respin to incorporate this before then. I'll be on PTO starting ... well now. But I'll try to give the other parts a quick peek if anything urgent jumps at me. (bad habit of reading mails while on PTO ...) In any case, happy holidays to you! -- Cheers, David / dhildenb