From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [Bugme-new] [Bug 2019] New: Bug from the mm subsystem involving X (fwd) From: Dave Hansen In-Reply-To: <5450000.1076082574@[10.10.2.4]> References: <51080000.1075936626@flay> <60330000.1075939958@flay> <64260000.1075941399@flay> <20040204165620.3d608798.akpm@osdl.org> <1075946211.13163.18962.camel@dyn318004bld.beaverton.ibm.com> <98220000.1076051821@[10.10.2.4]> <1076061476.27855.1144.camel@nighthawk> <5450000.1076082574@[10.10.2.4]> Content-Type: text/plain Message-Id: <1076088169.29478.2928.camel@nighthawk> Mime-Version: 1.0 Date: 06 Feb 2004 09:22:49 -0800 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: "Martin J. Bligh" Cc: Linus Torvalds , Keith Mannthey , Andrew Morton , "linux-kernel@vger.kernel.org" , linux-mm List-ID: On Fri, 2004-02-06 at 07:49, Martin J. Bligh wrote: > >> +#ifdef CONFIG_NUMA > >> + #ifdef CONFIG_X86_NUMAQ > >> + #include > >> + #else /* summit or generic arch */ > >> + #include > >> + #endif > >> +#else /* !CONFIG_NUMA */ > >> + #define get_memcfg_numa get_memcfg_numa_flat > >> + #define get_zholes_size(n) (0) > >> +#endif /* CONFIG_NUMA */ > > > > We ran into a bug with #ifdefs like this before. It was fixed in some > > of the code that you're trying to remove. > > What bug? With a regular PC config, plus CONFIG_NUMA turned on: CC arch/i386/kernel/process.o In file included from include/asm/mmzone.h:17, from include/linux/mmzone.h:318, from include/linux/gfp.h:4, from include/linux/slab.h:15, from include/linux/percpu.h:4, from include/linux/sched.h:31, from include/linux/module.h:10, from init/do_mounts.c:1: include/asm/srat.h:31: #error CONFIG_ACPI_SRAT not defined, and srat.h header has been included In file included from include/asm/mmzone.h:17, from include/linux/mmzone.h:318, from include/linux/gfp.h:4, from include/linux/slab.h:15, from include/linux/percpu.h:4, from include/linux/rcupdate.h:42, from include/linux/dcache.h:10, from include/linux/fs.h:17, from init/do_mounts_initrd.c:3: I can post the config if you like. You were the one who made me go fix it in the first place. That's why I added that #error. :) --dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org