From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81498C25B78 for ; Mon, 13 May 2024 16:00:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00CA36B00BF; Mon, 13 May 2024 12:00:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFDC56B019C; Mon, 13 May 2024 12:00:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D506A6B019D; Mon, 13 May 2024 12:00:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B73FF6B00BF for ; Mon, 13 May 2024 12:00:57 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59BCCA0347 for ; Mon, 13 May 2024 16:00:57 +0000 (UTC) X-FDA: 82113836154.05.93F4DDB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id EED2C2002B for ; Mon, 13 May 2024 16:00:53 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bvJMLlt4; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715616054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K0CYoZs0dx2HGoMj4p9xHQbvgN9/vzp+5liOIZ+zRdo=; b=xi2zt13hz45zH5MWrFbBp8ilZmPUJydFw1CraaKgClhhA9Md6sufduYgSh14ZzL6T3vkvk MCDVN7V6Pu7snlTroGGFaVK0uMBzrkApawDS7ltk5BPSGxqjAS/vv4aKJPa4osqtWs4Crh xXn+5KlG/CgsECmZ79eCr7Xs+v4Uol8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715616054; a=rsa-sha256; cv=none; b=rFOxCZv41P0vdc3d4X7erorxOkziCbSsR4uxVm9/nL07cYbkj27ES2vsdSRSohk2VnlVUF XQYAdHHltWnAHkOg4hmrX66jbeIrYWMltfsA0kuoRJJeqIONBuX3/a22HjFnU81wuINWYu 322uZU46IDA4xLmd0WLwoqnQ2qFmgi8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bvJMLlt4; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715616052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=K0CYoZs0dx2HGoMj4p9xHQbvgN9/vzp+5liOIZ+zRdo=; b=bvJMLlt4FCDQuHm6wSzPVuVUyIRzB2BRT8MLW0pMfWxKdLE6W7q+wk07VTVkpmbMVO9Qxj /HKVhlxDZIPlB8mMez7i1IGbb5r05g1IXNCmGSymEvFPB0eFAyOzNH3+l42MrjWzTT4Xqa 4j/j5pAVNybgrkftWZ3Gm9whA4RQsXI= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-fOHoBSFHOWSh7G0gKgiN-A-1; Mon, 13 May 2024 12:00:40 -0400 X-MC-Unique: fOHoBSFHOWSh7G0gKgiN-A-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-5b295d6df56so2864824eaf.3 for ; Mon, 13 May 2024 09:00:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715616039; x=1716220839; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=K0CYoZs0dx2HGoMj4p9xHQbvgN9/vzp+5liOIZ+zRdo=; b=QyS3Z8zUB3NwJ306VeBX+tNadIzqMaQj7uvjglKimGVjBRF7N7aG88/wSXsu7oIzd+ TOI8iMduwDbdeYFBJEgRdYug3ljFFQfil/XAWBRpKOabDOdlTfIAED7wsyCA/apAoAN1 BBgxI4re6YLnlDiV5oEdddZXubnPouk1RkAz0ijQFuCvrb6yMoHc74eu0KF6Ut89RKoF 5D9OqQRWF5+ah83ivo8WrH0h4SLyiIupbk4HtmglBd1XAifohMhPbVOoW/FNL4QALZby W1+P86ZsN2pkvshZVSN2gcDu3tRjHmaE/pqZiJVLQWynWfYaIH3KHiEfuRenhgh1UCAa zkkA== X-Forwarded-Encrypted: i=1; AJvYcCWs15UqjPXupP+eXTX9Rz7n3baC0WhQWeEOKRxZaa6YXqiZWizPQxItHBM7FM7mZSY1WpYaNf4xp6CuM08HYTVzz9Y= X-Gm-Message-State: AOJu0YwhLrVu5cmuqks0hvj4R6WYwWtB162zSp8yKksGItWTl+LUDKM9 eTIwyum7QFkOizUkSsD136ckqPXtMrii+OXbeM1HQGxrGIxoXMtVH09Fkc4v8mBJRneFHkGJ+Rm n/CANFuD9POKmFn+B9MEdzskKPHOM7uYfVvwnzIwj3ZVUYT10 X-Received: by 2002:a05:6358:339f:b0:192:c556:5552 with SMTP id e5c5f4694b2df-193bb3fc5fcmr990632355d.6.1715616039122; Mon, 13 May 2024 09:00:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFeWg5zvCqydqbu87+C41bMR+br/c5m2gqcBqQMojKuo+mwd1ZzTwAvHMx7nrzpYwnz/sN+Bw== X-Received: by 2002:a05:6358:339f:b0:192:c556:5552 with SMTP id e5c5f4694b2df-193bb3fc5fcmr990629555d.6.1715616038660; Mon, 13 May 2024 09:00:38 -0700 (PDT) Received: from [172.21.1.2] ([50.204.89.31]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6340a449ffbsm8008935a12.2.2024.05.13.09.00.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 09:00:37 -0700 (PDT) Message-ID: <10529556-e22d-4afa-803d-c75511ce8425@redhat.com> Date: Mon, 13 May 2024 18:00:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH linux-next] mm/huge_memory: mark racy access on huge_anon_orders_always To: xu.xin16@zte.com.cn, akpm@linux-foundation.org Cc: willy@infradead.org, shy828301@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ziy@nvidia.com References: <20240511144436754EiKfJM4xjMSTyCbEExwcL@zte.com.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240511144436754EiKfJM4xjMSTyCbEExwcL@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 7qawfo7iymi1k134uph5xhgka96y5mcn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EED2C2002B X-HE-Tag: 1715616053-526720 X-HE-Meta: U2FsdGVkX18cTaFT+cy4IHZv/IAQ2Zbrq0/PG6AavnNcppFIzcD6FI2YTDP0ALsk2VPDEiiPxPfA+kqGp+XFpl/m+apVII580OA19GASYdvev7xm9bdwvMV8fL7jwAt/Xk8fCo2UkCyy+YYhr5SzVnE/0hb3OiFQgpwOFJRQzn9tP6jhJR/c9tyFRoFYEWwR6UCX1oggmVP+nZEs59eATQBIyWcEhqza1h2aou+DemOQgWV6amTHJ56wxwAHYCLjAYScLL2W7iQ6UmLWnhpm4L0ZkZjtp/BOB3io8qxi2VCWfRJ5YemE6EXMJ9qTkI+wN4O0uxRylOJnZ66/IymYcvv3eKD/BbmEmeKr6bYa25zyomrL9DE9gR6+TyOSrbIQdnYIzrGAwer08Go4WyQD5+9iG4HPfpSd1/pM//LfhgsxSFtlvUZbZ/62mugGeY0+7aQJu9ZxtB85whLZ75Cb1bpvUaIri7WrJOkMgzr8CyILm3Nu1bO4dLlH4nYmMs90nF2UxO0dS93cZOePejidHVqN2NmgQyfex1CXyMEoQoLICZ9PSubre9s9WJOwgd4WQ7k7DipEMUlz1Vwar348p0mei0tnIc6YJRQDfYwPzN8fuVvpCPRhKyKmV4dgeWda88Y5VrjiDBCmS7iZWKZqlew4D9Wx+iSmjIpzXRfni+ZkiNXm3D5lxXnujKnuBimi+/I35RxVzWlz+IxbXvCb2NXErVmnSGyBuuxE3IJv+aKn+h4b+eCk61+yz7tFnGg+AeIHXTfHyN+SIPwZw33Lv6pcc1SV1+vPZlGTfn97NYPA5LOb4DuB/41GtTXPJ6qAUYxIcOjGawpgRNKot07gSADOC/0p1B6HPyYaykdgZFafP7wPaKmw/mnwxgrPalOIZ7y4i37hGsVVa0Fd0OziBgmFVS7RLxbuGUFpG5++CeGoRpTSYGdcz3+vJlZ7NJCedoC36Di6gNOMkFbS22f C4EZPKwf 1NdViIX223r/9Q58E5eZ2ZGaQOVTBidtTlZqFPPYl/RGyLwj0UNajaPN+pr1nCJaihFD1xGSSxrqcC96yw+bh+AtTRdg9viXE2EXU/ORxN8paafw/FwZSEZXOweEk6wFuLQQ9+kZkkGA/cn1aircAlfrApx1juYMOik6ecIYDreJ2SufrjJjLVLo/Hu6hSAW6uaAAfRUc8pXm1pGOh81EZueP5UqNmhEfIPCNveM1eiDYthv6oKYI6XaVjg2fx++wIELZPN2yfojPDzt8v2KLD6j98V6cStFf98rxxHMh+jfU6dE2wtHR10etPEDYoKBmcuAxGJ7a3vSMIeNOFOXBnJ9S1sXOb/WMsWNFHTuT962aeRZEpDDSdBk0epyXrpMiRACeJLsppbJJttCN1eBNSkMUaKf0pIYLUGhxyKi2PJzOFOfTn5emX4VCDR5yUSlPWjknP7blhd3Y8P/U/iSNdAPf0Y5Nt0DljD9UUuVHECrJT6RqMm6agikmqK3e4Kj2kGiCAMjJ3moOdVCsBm16+CNG9YEsLs5Bb7+S8AWS8sn4cbHk086LYg1zpWQ4ELW7uKweBEEc1FkZHun+rmGuJzdIbQ5YfisIJK4BxtrkhJG/VWQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.05.24 08:44, xu.xin16@zte.com.cn wrote: > From: Ran Xiaokai > > huge_anon_orders_always and huge_anon_orders_always are accessed "huge_anon_orders_always" mentioned twice. > lockless, it is better to use the READ_ONCE() wrapper. > This is not fixing any visible bug, hopefully this can cease some > KCSAN complains in the future. > Also do that for huge_anon_orders_madvise. > > Signed-off-by: Ran Xiaokai > --- > include/linux/huge_mm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index de0c89105076..6573430ea600 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -122,8 +122,8 @@ static inline bool hugepage_flags_enabled(void) > * So we don't need to look at huge_anon_orders_inherit. > */ > return hugepage_global_enabled() || > - huge_anon_orders_always || > - huge_anon_orders_madvise; > + READ_ONCE(huge_anon_orders_always) || > + READ_ONCE(huge_anon_orders_madvise); Don't mess up the alignment please. > } > > static inline int highest_order(unsigned long orders) Acked-by: David Hildenbrand -- Cheers, David / dhildenb