From: Stephen Hemminger <shemminger@osdl.org>
To: Andrew Morton <akpm@digeo.com>
Cc: "David S. Miller" <davem@redhat.com>,
rmk@arm.linux.org.uk, ak@muc.de, davidm@napali.hpl.hp.com,
anton@samba.org, linux-mm@kvack.org,
Andrea Arcangeli <andrea@suse.de>
Subject: Re: Linus rollup
Date: 29 Jan 2003 14:35:52 -0800 [thread overview]
Message-ID: <1043879752.10150.387.camel@dell_ss3.pdx.osdl.net> (raw)
In-Reply-To: <20030129022617.62800a6e.akpm@digeo.com>
On Wed, 2003-01-29 at 02:26, Andrew Morton wrote:
> "David S. Miller" <davem@redhat.com> wrote:
> >
> > From: Russell King <rmk@arm.linux.org.uk>
> > Date: Wed, 29 Jan 2003 09:59:49 +0000
> >
> > /* This function must be called with interrupts disabled
> >
> > which hasn't been true for some time, and is even less true now that
> > local IRQs don't get disabled. Does this matter... for UP?
> >
> > I disable local IRQs during gettimeofday() on sparc.
> >
> > These locks definitely need to be taken with IRQs disabled.
> > Why isn't x86 doing that?
>
> Darned if I know. Looks like Andrea's kernel will deadlock if
> arch/i386/kernel/time.c:timer_interrupt() takes i8253_lock
> while that cpu is holding the same lock in do_slow_gettimeoffset().
Rather than disabling interrupts in the i386 do_gettimeofday
why not just change spin_lock(&i8253_lock) to spin_lock_irqsave
in timer_pit.c
--
Stephen Hemminger <shemminger@osdl.org>
Open Source Devlopment Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2003-01-29 22:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-29 6:07 Andrew Morton
2003-01-29 6:53 ` David Mosberger
2003-01-29 7:25 ` David S. Miller
2003-01-29 9:33 ` Andrew Morton
2003-01-29 9:35 ` David S. Miller
2003-01-29 9:54 ` Anton Blanchard
2003-01-29 9:59 ` Russell King
2003-01-29 9:51 ` David S. Miller
2003-01-29 10:26 ` Andrew Morton
2003-01-29 22:35 ` Stephen Hemminger [this message]
2003-01-29 23:12 ` Andrew Morton
2003-01-30 0:30 ` David S. Miller
2003-01-30 1:27 ` Andrew Morton
2003-01-30 1:24 ` Andi Kleen
2003-01-30 2:01 ` Andrew Morton
2003-01-30 1:35 ` Andrea Arcangeli
2003-01-30 2:00 ` Andrew Morton
2003-01-30 1:50 ` Jeff Garzik
2003-01-30 2:03 ` Andrea Arcangeli
2003-01-30 17:09 ` Stephen Hemminger
2003-01-30 17:15 ` Randy.Dunlap
2003-01-30 17:25 ` Andi Kleen
2003-01-30 17:23 ` Randy.Dunlap
2003-01-30 1:52 ` Richard Henderson
2003-01-30 2:06 ` Andrea Arcangeli
2003-01-30 1:54 ` Andrea Arcangeli
2003-01-30 2:19 ` Andrew Morton
2003-01-30 17:37 ` Stephen Hemminger
2003-01-30 17:50 ` Andrea Arcangeli
2003-01-30 2:00 ` Richard Henderson
2003-01-30 0:46 ` Andrea Arcangeli
2003-01-30 0:43 ` Andrea Arcangeli
2003-01-29 10:16 ` Andrew Morton
2003-01-29 17:04 ` David Mosberger
2003-01-29 17:25 ` Russell King
2003-01-29 19:05 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1043879752.10150.387.camel@dell_ss3.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=ak@muc.de \
--cc=akpm@digeo.com \
--cc=andrea@suse.de \
--cc=anton@samba.org \
--cc=davem@redhat.com \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-mm@kvack.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox