From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1CBC6FD18 for ; Wed, 19 Apr 2023 11:10:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D24D78E0002; Wed, 19 Apr 2023 07:10:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD4138E0001; Wed, 19 Apr 2023 07:10:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B759B8E0002; Wed, 19 Apr 2023 07:10:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A4EEA8E0001 for ; Wed, 19 Apr 2023 07:10:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7740A140240 for ; Wed, 19 Apr 2023 11:10:34 +0000 (UTC) X-FDA: 80697872388.24.A64033D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 0FE65180006 for ; Wed, 19 Apr 2023 11:10:31 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bUEago6X; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681902632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6VEVKA1Vl6VhcJKmRR8Lc5Oh25keqB43HXXf18w/R70=; b=KghAzHkGgmgOED11WTavHq/V2V8tyqUdxj02J+u5F5WuNCrFqSZsdtsTnfQ2nsFzc5xjRa WCBBStPH7Hh5nQ1ywvi3iMI9WGsDgr5mN4eOh8fWblKzOuNKiADQr57msqVDlWc9v9X2OV 19BURC0EjRuPqbMkX4CFWooBoYQeD/I= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bUEago6X; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681902632; a=rsa-sha256; cv=none; b=m3tk8AjeAxkEMpV2ApIjm/s03a40kskQ3DgJ+lNLbcEaXUP8spdTm8syaUVC/xi3oA6bGd XsiG8qdcko1mkbcZwnr35p5SXcw8LkjYbLBqtfSURll+AJwMjP3nCWEBqrEFW2Fwr2kuza 2J+ROMsVAKpa9RCMDmuqeMCWnggFELk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681902631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6VEVKA1Vl6VhcJKmRR8Lc5Oh25keqB43HXXf18w/R70=; b=bUEago6XRxC1Kvw0vr+80qtNDRORKAF5Vb/FDfiYUc7ZXr/lvtbW8MXyKjohkV394BzgK4 KtPPaa5+uAoht7rSVhkB2AY0eFexT2GECh0dety3EesGtofaIeL0tafu2YqfnnAFAVTYOU 8s1EQ67ny1R41+YzBGNz83+4H5AUNDg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-PSGhJrGkM6KXz9UcGFKbVg-1; Wed, 19 Apr 2023 07:10:30 -0400 X-MC-Unique: PSGhJrGkM6KXz9UcGFKbVg-1 Received: by mail-wm1-f70.google.com with SMTP id ay41-20020a05600c1e2900b003f173d56c20so783596wmb.6 for ; Wed, 19 Apr 2023 04:10:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681902629; x=1684494629; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6VEVKA1Vl6VhcJKmRR8Lc5Oh25keqB43HXXf18w/R70=; b=G7LFeRc3m8vDxPiQrWwATKcM3hcfx9fXQW8WGiHN5cx0eLgYMHstOzYeDh7B4fyut7 a3npLV/nhNMmf4m19ENP+fxecWmj1ohhOweCQ9USWqb/fXI5dMbQ45Bw2jpAvLCQYTtZ qlutX2OS+dPbxt7ooKGI7CigQiQHp/t2mcfhvKi5pQFfqyJmifllcFkniIzvQTL30rjS wsH9chuTyPtUByEQuNlze1cjvwQEECZ7UlDoW61EbhZGTJT5gaHhkzuOrT7HLUmtvIfb 1UB/TI5cgqmJbikr4bh1k7jrWbMAXHZchP2ipTEsvFw5jpVWCBx1O336IcwPTmivVBWJ 0mTg== X-Gm-Message-State: AAQBX9eTgYZCTkvubue6GdWmS9x8a6soZVhbqRmHWYw9KR0ncx2zzxWO 9pXJ8gBPXC99y36y2dT60mZrLY+DqnZF8GXbcs/tzPZYJxAgE8UPF++Lm9UuIA8LcxBXksG5QqL wOuOOQavLm3Q= X-Received: by 2002:a7b:c7cb:0:b0:3f1:72e2:5d13 with SMTP id z11-20020a7bc7cb000000b003f172e25d13mr8046135wmk.16.1681902629029; Wed, 19 Apr 2023 04:10:29 -0700 (PDT) X-Google-Smtp-Source: AKy350avLXd/CBQHwiuF4d7hR9iQ9uS5lpaVU09xA6pxIBcVZ6qLDKiB+l8V9gjwW1zCzN3JrjTycg== X-Received: by 2002:a7b:c7cb:0:b0:3f1:72e2:5d13 with SMTP id z11-20020a7bc7cb000000b003f172e25d13mr8046114wmk.16.1681902628741; Wed, 19 Apr 2023 04:10:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:7b00:7c52:a5fa:8004:96fd? (p200300cbc70b7b007c52a5fa800496fd.dip0.t-ipconnect.de. [2003:cb:c70b:7b00:7c52:a5fa:8004:96fd]) by smtp.gmail.com with ESMTPSA id w9-20020a05600c474900b003f17e37ce60sm1836550wmo.47.2023.04.19.04.10.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 04:10:28 -0700 (PDT) Message-ID: <103fea0a-8a5e-a8ec-e956-a4341906218e@redhat.com> Date: Wed, 19 Apr 2023 13:10:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH 03/26] mm: make pageblock_order 2M per default To: "Kirill A. Shutemov" , Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Mel Gorman , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-4-hannes@cmpxchg.org> <20230419000105.matz43p6ihrqmado@box.shutemov.name> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230419000105.matz43p6ihrqmado@box.shutemov.name> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 3jor199j1ckaby8hzmm7z6s9pxe4jkcs X-Rspamd-Queue-Id: 0FE65180006 X-HE-Tag: 1681902631-614817 X-HE-Meta: U2FsdGVkX19AAAcYKYVonTjFVe0l9Gnmuw9miMUNTv3id2apG49o5A+0wqWFZeHHSvZz1dFuF78pSjRbuTI8kFrNJRE75Uxzb0/90T9BVXKAHg4J+F2naFlBbWaMxbiHmJcrbrDqxmTj+hf6HvV3TFvH5jHMW2tjtpYHV6DgSX66CQIGa9Uyyc7nqocpUO+rYbneCJKMT1Ka2AzUqhXXKzr9O3cwmIzM+amuYxSf+LnZSr5hxWiZhf7HoJG5OETpDhnDPldg36poYwkxNzqd5e74ebDNf2fjjFDnbfVI94BqmT5zP6ZU0R5xpzGoPNGy+KS3hTInCkhWsWW2U5kS2GwtJuTkFrpdRDEr+V3X7Swiv+r+zz1rVoe4qabFxsZcBcmqDOs8rMDMnGTyywLqn5+Lqzb28XRUEhEbwNuQhws6opcLILMg9T8EH9KZ2WD98nF2rVg5OuSp5jhyn6EnLlQLPUPMv/VeLeq7MplV32Lwp8IKcl+EVowm6SArlfDUuS4FqAw1LZLl6ibh33aR0JD1HZGGPyWWzdkxAPqBbNWvzRgpeHaouUf0vZAeeidVZU/mYwld+P590+5dsnEvX+FsxHi1rrTX3bhNoKpvBMjMQps2uTEXyiclScvhFYIWeJz5rxWhydjNUHTwHJJha7EPY1lex6k76k3Hk1Xz6wKXidv1Ibk10X5Drh0cEp8iMCP1vTjWgc8xQMuEi4PqaGRc51MAfhYZvlfoM/3b+DZGcgF5BCQ14NE4SIjK+z3PmsvHzYa/b23q0w604jo5EQ9Nd0XfX3BxDjjjszZ5kBUxDsBDvlMYemoa7WzUZRZwdnYxtfitNh+RNgQvZUYnngNKQ/r+m1K1Y+E83NToP9LTByg88jK0xZezLUNjNxZfXGYsW6iCeQI4SxHO94vmz2UukUCPLSHQgl1RI/DGxlYNFSpmPOapig0Az0poaTjPFBzI+ZBzBt3vGyj+Iaa mRmyfgAc lvZCUdw6RCvJE5gYyA7T+noSQd9Oz3Uau922nTGhePbmN7S884+7sh67JePoIYYBzbtGUFb4Pao5c2O1wDhI3JejOMOE6I9Sze/50Q/V92bZlT56AEX6Ip99BZ2HFpX4Ps1xJadT2zFllTHYVjaQpqCXlIfXo2UR3q9HPIroBP8EUa6uRCIiRvJcBncYFcvwraWmaVflBeqByKjqj7D9OqyhVdZkYp4j1fMIObYyj7J+OlEFPi8tC1pI8hwFBcfIsdTa1lQPywPPDLIpPT21xpNdRX31IrxmbcGU+9V9G0w9sBme8oHO4IPR//fKo8yU7tIDFD1KYunNLaX48jgYGl6OUKmqILjBvk0sCrhhM3rUYs6XRimJ4BBu7IHP4G16RTzt2gxCmYMIfk4WIfOfbzqHd4kKTczpzgMi0aF4yAZpshM5JuOWwdcGjYQ0zg8VtlB2K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.04.23 02:01, Kirill A. Shutemov wrote: > On Tue, Apr 18, 2023 at 03:12:50PM -0400, Johannes Weiner wrote: >> pageblock_order can be of various sizes, depending on configuration, >> but the default is MAX_ORDER-1. > > Note that MAX_ORDER got redefined in -mm tree recently. > >> Given 4k pages, that comes out to >> 4M. This is a large chunk for the allocator/reclaim/compaction to try >> to keep grouped per migratetype. It's also unnecessary as the majority >> of higher order allocations - THP and slab - are smaller than that. > > This seems way to x86-specific. Other arches have larger THP sizes. I > believe 16M is common. > arm64 with 64k pages has ... 512 MiB IIRC :/ It's the weird one. > Maybe define it as min(MAX_ORDER, PMD_ORDER)? Sounds good to me. -- Thanks, David / dhildenb