Re: [RFC PATCH] MAINTAINERS: add further core files to mm core section

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Mon, Jun 16, 2025 at 11:10:41PM +0200, David Hildenbrand wrote:
> On 16.06.25 22:38, Lorenzo Stoakes wrote:
> > There are a number of files which don't quite belong anywhere else, so
> > place them in the core section. If we determine in future they belong
> > elsewhere we can update incrementally but it is preferable that we assign
> > each file to a section as best we can.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > ---
> > REVIEWERS - let me know if these seem appropriate, I'm eyeballing
> > this. even if they are not quite best placed a 'best effort' is still
> > worthwhile so we establish a place to put all mm files, we can always
> > incrementally update these later.
> >
> >   MAINTAINERS | 28 ++++++++++++++++++++++++----
> >   1 file changed, 24 insertions(+), 4 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4523a6409186..a61d56bd7aa4 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15740,10 +15740,6 @@ F:	include/linux/memory_hotplug.h
> >   F:	include/linux/memory-tiers.h
> >   F:	include/linux/mempolicy.h
> >   F:	include/linux/mempool.h
> > -F:	include/linux/memremap.h
> > -F:	include/linux/mmzone.h
> > -F:	include/linux/mmu_notifier.h
> > -F:	include/linux/pagewalk.h
> >   F:	include/trace/events/ksm.h
> >   F:	mm/
> >   F:	tools/mm/
>
> Probably better to have some section than none ... was just briefly
> wondering if "CORE" is the right section for some of that. Some of that
> might be better of in a "MM MISC" section, maybe.

Responded in thread elsewhere on this but yes defo!

>
> > @@ -15764,16 +15760,40 @@ S:	Maintained
> >   W:	http://www.linux-mm.org
> >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> >   F:	include/linux/memory.h
> > +F:	include/linux/memremap.h
> >   F:	include/linux/mm.h
> >   F:	include/linux/mm_*.h
> >   F:	include/linux/mmdebug.h
> > +F:	include/linux/mmu_notifier.h
> > +F:	include/linux/mmzone.h
> >   F:	include/linux/pagewalk.h
> >   F:	kernel/fork.c
> >   F:	mm/Kconfig
> >   F:	mm/debug.c
> > +F:	mm/debug_page_ref.c
> > +F:	mm/debug_vm_pgtable.c
>
> Wondering if there should be a MM DEBUG section. But then, no idea who in
> their right mind would be willing to maintain that ;)

Thanks for volunteering! :P

Yeah I did think about this. But given the above it's maybe better to put in mm
misc until we a brave soul steps up? :)

I have a few other new sections that are possibly ones we should add:

CMA
DMA pool
statistics (e.g. vmpressure.c, vmstat.c)

But these could go to misc for the time being also.

Of these 3 possibly statistics is the one that makes the best case I think.

>
> > +F:	mm/folio-compat.c
> > +F:	mm/highmem.c
> >   F:	mm/init-mm.c
> > +F:	mm/internal.h
> > +F:	mm/interval_tree.c
> > +F:	mm/io-mapping.c> +F:	mm/ioremap.c
> > +F:	mm/list_lru.c
>
> Smells like reclaim/memcg.
>
> > +F:	mm/maccess.c
> > +F:	mm/mapping_dirty_helpers.c
> >   F:	mm/memory.c
>+F:	mm/memremap.c
>
> memory hotplug related. Well, one could argue that it's just a memory
> hotplug user. It's mostly ZONE_DEVICE handling. Wonder if that would be
> worth a separate section ...

Hm not sure? Again maybe best for misc for now until we decide :)

>
> > +F:	mm/mmu_notifier.c
> > +F:	mm/mmzone.c
> > +F:	mm/oom_kill.c
>
> This contains quite some meat. I wonder if a OOM section would be
> appropriate (Michal, I'm looking at you :) )

As Shakeel points out that's already done (see [0]).

[0]: https://lore.kernel.org/linux-mm/20250617085819.355838-1-mhocko@kernel.org/

>
>
> --
> Cheers,
>
> David / dhildenb
>