From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9F1C77B7E for ; Fri, 28 Apr 2023 17:02:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 058B66B0071; Fri, 28 Apr 2023 13:02:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02FBB6B0075; Fri, 28 Apr 2023 13:02:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E12EF6B0078; Fri, 28 Apr 2023 13:02:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D381B6B0071 for ; Fri, 28 Apr 2023 13:02:35 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9D1F3802D2 for ; Fri, 28 Apr 2023 17:02:35 +0000 (UTC) X-FDA: 80731418670.05.CFCE8CB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 56685A0044 for ; Fri, 28 Apr 2023 17:02:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CCSsqvLX; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682701353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zN+hlinWDo7HPckU96nAsQkShApM93gzKFjoIDnOxkE=; b=ouAlqtFinbx72iCZ70R5YzXk1NdiHX7106NcuJqtXIlJmfcPRHuypg1gL+en54EkePZTPI tb0gdUyRGHLyzfXd+F7yFI+hH7RWKwZtNQFZUrw1LiLPrOu4sa8GtfhHnS4AUPQWmbuuNX iWIgvFOZ/CUoz7Bd4bO/fieqzeylS3Q= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CCSsqvLX; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682701353; a=rsa-sha256; cv=none; b=8AxTPbpeUVfIJ/HpyR4wbOD1uAIYgZ2S7oZShPGOr5nVectJA6Jvk9RRNGua8VXd6HODfe DMFNDGHykXBe1Z93jf/P6OskNzMFpeUfmZcw3AZbpcnVBdRW+mLcoFJ+zdtCQspxrKSrc9 sDz/FNIdSY1FBN/pmO04lLIzUhGPOZg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682701352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zN+hlinWDo7HPckU96nAsQkShApM93gzKFjoIDnOxkE=; b=CCSsqvLXL5FgPo9M8q0qQm7yBQ6j2mjtE3Kfcsfswc6CFEF4tahE5WPH3taR9VHQm5NDxs bcRi0hf80Vh5nqOGxU4JrKZz7Y0haLmM3azRdNMZ3Fz4sDJgNSwygmeJKvC+93Pm6jX6kd X6gtZiEjBRJ/5GWzkAJkeiErbQh6XbI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-vlY70yBwOUmSuaCm2t4qDQ-1; Fri, 28 Apr 2023 13:02:27 -0400 X-MC-Unique: vlY70yBwOUmSuaCm2t4qDQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-2f2981b8364so5739399f8f.1 for ; Fri, 28 Apr 2023 10:02:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682701346; x=1685293346; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zN+hlinWDo7HPckU96nAsQkShApM93gzKFjoIDnOxkE=; b=bbd9CNtXeFSODfq6/CTljg9dd67xDY8Q4Mv5ZWd8sJM92uCPGf4qbvNvFIg1v3zRdM MSuLNFtKKuvdpLRNscsPnCt+koj/zyjPE7hkN3QKHJE5tvHogTRy1lvFo/xmavGU7nxa X8XRci6/Z8PLFGhqSRx5fdmykNk3jubAOX4kj+mgEoFaA5U7R9Jomh06pKNJ8ca9PSVq KPN5kdAMyDX0sElCQhp0Zs1Tf8ksNIPdJ6m1A6/u0xpt7DdGO1dtnk8ZSpw6PKFDt0rd PxmqWryIdUq35+pOJcF3CjHGB6VgqWFpn2iXsT4bWXIRhh/tk5SzGeaepu0ZsnGj+hwZ CO9A== X-Gm-Message-State: AC+VfDyRlW+CTnFasOZCVY6RGNMrTNZPK25sAh6GZOs6LBJAYsYj/f68 Qbr3Fmkj2AVE9vho7E4B3j5rugx3SeveUlLoclNNgoxVrI2VjQ4+tfR/zqu1Q3utkTGfIqSQy+l 6i2KclTAo+p4= X-Received: by 2002:a5d:40cd:0:b0:2ff:3a63:ed61 with SMTP id b13-20020a5d40cd000000b002ff3a63ed61mr4380608wrq.13.1682701345893; Fri, 28 Apr 2023 10:02:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5IGpmPcW+sW5hDbaIE0RZbDfpW/KW7f3SgvaJbedb3u6P7PhLZRwvYbDxXsxQPtSCsSBa1uw== X-Received: by 2002:a5d:40cd:0:b0:2ff:3a63:ed61 with SMTP id b13-20020a5d40cd000000b002ff3a63ed61mr4380577wrq.13.1682701345525; Fri, 28 Apr 2023 10:02:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:9300:1711:356:6550:7502? (p200300cbc72693001711035665507502.dip0.t-ipconnect.de. [2003:cb:c726:9300:1711:356:6550:7502]) by smtp.gmail.com with ESMTPSA id d13-20020adfe88d000000b002e55cc69169sm21510251wrm.38.2023.04.28.10.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 10:02:24 -0700 (PDT) Message-ID: <1039c830-acec-d99b-b315-c2a6e26c34ca@redhat.com> Date: Fri, 28 Apr 2023 19:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings by default To: "Kirill A . Shutemov" Cc: Peter Xu , Lorenzo Stoakes , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , Pavel Begunkov , Mika Penttila , David Howells , Christoph Hellwig References: <094d2074-5b69-5d61-07f7-9f962014fa68@redhat.com> <400da248-a14e-46a4-420a-a3e075291085@redhat.com> <077c4b21-8806-455f-be98-d7052a584259@lucifer.local> <62ec50da-5f73-559c-c4b3-bde4eb215e08@redhat.com> <6ddc7ac4-4091-632a-7b2c-df2005438ec4@redhat.com> <20230428160925.5medjfxkyvmzfyhq@box.shutemov.name> <39cc0f26-8fc2-79dd-2e84-62238d27fd98@redhat.com> <20230428162207.o3ejmcz7rzezpt6n@box.shutemov.name> <173337c0-14f4-3246-15ff-7fbf03861c94@redhat.com> <20230428165623.pqchgi5gtfhxd5b5@box.shutemov.name> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230428165623.pqchgi5gtfhxd5b5@box.shutemov.name> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: amdno6x4x4oh31ci769jcbessapycqj9 X-Rspam-User: X-Rspamd-Queue-Id: 56685A0044 X-Rspamd-Server: rspam06 X-HE-Tag: 1682701353-353867 X-HE-Meta: U2FsdGVkX1/AAwgWnRBy5OXqkSVZ02rNra1Aqu7DGgjvSkoNERRSWNbdPIGCg7Q3tI0wBf+HFICt5cZgIeIOyAdrilsQ9HW8kPv4mw+8Nks3m8MSzimDS/8ni0VZ/56ZqrhcZTYoVYSquTGt5FCklxDk6lHE/Z5AUqTFk4+a8R/wQXyvljbPKt1CFiWIK2SfTTeTODRdAceCW1CvvrtIK//ATSJs1acca0LT1ZixQI22WfIZUfrpZ+pyUfVWPMZuLmKhBwYYEK1MVRXt5owkhUolU9EcNPNghwBSPbThwv1BpNDKgs8h0hbqs9gsIX4PJXvZhTnehz/cxbbi27hiUOQyWHSJoS0L+sPJEeuHBH104ZxhFSv8ejMLRILm/ucHKs5KEHEyanlGcbSxskO8JQe+7LeWuL8Kawha754qWQLRzgboqCy+j7QBkxhT31yTHWnSbta1RC69wp0KmKXFJBWN7rFv3iFWSK/uqWawSWKzVgNS/Qs0VhtPLMzpPwo44ZyGZIvnv4/8yU5lzEERuge4rNoUKyM/2lAbfcyjzzavCIxQpTQZpRggDlC0S74tTfZDm4GgFL+RXAQhNHxI+7HD4A8kpde4ZpHEIiXpi+IYzC1Tj3mRMX6ieyMW/J82yMjfvZR0LvyfFj62KXc1DgZnVLCKdNs13NYWM99NjfIjINClP5GYXu13331xZaUg5BYT8UMUI4gjbZPgfzF/wZpsJPVUacIzqcDWX/FdICTLiQy8RcG0DKe57XPv1XjHfwJar1A0EBEkXNNc5mG1WFUJIctGAPUCtevMMejDAvbU7Lg36S+11G4LZ/+urVLYBGzfVLoEGgxnPAZm75UmqnCnMWu//lVwJSZzUquqor/6CJVDdfCmnmg3tPXi3xTF51/vz3+4PMF84sCSy7oP1XPU0vGxkuXIrbHE5e+Lx9j03ISXHTWzJwk6ff56JGIjLD01H8O6rjoplZVjx6c 2GRwmMJf 1u6Zv6BP3hIEnbj0hcsoJAm6Q83QI+1aQ6IMdxL+aCZ+e5v1+mAwhhr0hMtxtAE5slusaB6gcvytZNYRrXujrQW8RJVCBSBLM7UIzxjPCc/oStJwTwdzAkzvvaXscYfSUBKYoox2jhhB06oGn9jFoem5Hxc5YVp22Apc9O7Z1NchH+romDZ48g5TAsNbZJAdSJyC7jf9JPvv1ylWmAFjqxo/39F60bLzljwpAXxXPl22LEHnyX9PndWU5bK4R7D61XwJi8R+Fz9bxZVtTQlQmg75dv1FPUvqOsGOyF9YXPhfTTHXD6ESBifnMZRYj71fTQpuadsr8JjRrsHRe9+SeX/7llS/a+UIfsR0uthw/vkAhl+7kRSpzKi9ALlEp11PgGbmN7qk1fFsmOSCCPgOLwcCpbplEH2uNZiIcKZ8zULWwiwjqr1OiANwyMpzQjROtYfPYyIgOc4LHC+A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.04.23 18:56, Kirill A . Shutemov wrote: > On Fri, Apr 28, 2023 at 06:51:46PM +0200, David Hildenbrand wrote: >> On 28.04.23 18:39, Peter Xu wrote: >>> On Fri, Apr 28, 2023 at 07:22:07PM +0300, Kirill A . Shutemov wrote: >>>> On Fri, Apr 28, 2023 at 06:13:03PM +0200, David Hildenbrand wrote: >>>>> On 28.04.23 18:09, Kirill A . Shutemov wrote: >>>>>> On Fri, Apr 28, 2023 at 05:43:52PM +0200, David Hildenbrand wrote: >>>>>>> On 28.04.23 17:34, David Hildenbrand wrote: >>>>>>>> On 28.04.23 17:33, Lorenzo Stoakes wrote: >>>>>>>>> On Fri, Apr 28, 2023 at 05:23:29PM +0200, David Hildenbrand wrote: >>>>>>>>>>>> >>>>>>>>>>>> Security is the primary case where we have historically closed uAPI >>>>>>>>>>>> items. >>>>>>>>>>> >>>>>>>>>>> As this patch >>>>>>>>>>> >>>>>>>>>>> 1) Does not tackle GUP-fast >>>>>>>>>>> 2) Does not take care of !FOLL_LONGTERM >>>>>>>>>>> >>>>>>>>>>> I am not convinced by the security argument in regard to this patch. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> If we want to sells this as a security thing, we have to block it >>>>>>>>>>> *completely* and then CC stable. >>>>>>>>>> >>>>>>>>>> Regarding GUP-fast, to fix the issue there as well, I guess we could do >>>>>>>>>> something similar as I did in gup_must_unshare(): >>>>>>>>>> >>>>>>>>>> If we're in GUP-fast (no VMA), and want to pin a !anon page writable, >>>>>>>>>> fallback to ordinary GUP. IOW, if we don't know, better be safe. >>>>>>>>> >>>>>>>>> How do we determine it's non-anon in the first place? The check is on the >>>>>>>>> VMA. We could do it by following page tables down to folio and checking >>>>>>>>> folio->mapping for PAGE_MAPPING_ANON I suppose? >>>>>>>> >>>>>>>> PageAnon(page) can be called from GUP-fast after grabbing a reference. >>>>>>>> See gup_must_unshare(). >>>>>>> >>>>>>> IIRC, PageHuge() can also be called from GUP-fast and could special-case >>>>>>> hugetlb eventually, as it's table while we hold a (temporary) reference. >>>>>>> Shmem might be not so easy ... >>>>>> >>>>>> page->mapping->a_ops should be enough to whitelist whatever fs you want. >>>>>> >>>>> >>>>> The issue is how to stabilize that from GUP-fast, such that we can safely >>>>> dereference the mapping. Any idea? >>>>> >>>>> At least for anon page I know that page->mapping only gets cleared when >>>>> freeing the page, and we don't dereference the mapping but only check a >>>>> single flag stored alongside the mapping. Therefore, PageAnon() is fine in >>>>> GUP-fast context. >>>> >>>> What codepath you are worry about that clears ->mapping on pages with >>>> non-zero refcount? >>>> >>>> I can only think of truncate (and punch hole). READ_ONCE(page->mapping) >>>> and fail GUP_fast if it is NULL should be fine, no? >>>> >>>> I guess we should consider if the inode can be freed from under us and the >>>> mapping pointer becomes dangling. But I think we should be fine here too: >>>> VMA pins inode and VMA cannot go away from under GUP. >>> >>> Can vma still go away if during a fast-gup? >>> >> >> So, after we grabbed the page and made sure the the PTE didn't change (IOW, >> the PTE was stable while we processed it), the page can get unmapped (but >> not freed, because we hold a reference) and the VMA can theoretically go >> away (and as far as I understand, nothing stops the file from getting >> deleted, truncated etc). >> >> So we might be looking at folio->mapping and the VMA is no longer there. >> Maybe even the file is no longer there. > > No. VMA cannot get away before PTEs are unmapped and TLB is flushed. And > TLB flushing is serialized against GUP_fast(). The whole CONFIG_MMU_GATHER_RCU_TABLE_FREE handling makes the situation more complicated. -- Thanks, David / dhildenb