From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6DF0C433F5 for ; Wed, 3 Nov 2021 14:34:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4FD9D61050 for ; Wed, 3 Nov 2021 14:34:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4FD9D61050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BBFCC940007; Wed, 3 Nov 2021 10:34:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6ED56B0072; Wed, 3 Nov 2021 10:34:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A84F8940007; Wed, 3 Nov 2021 10:34:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 9A96F6B006C for ; Wed, 3 Nov 2021 10:34:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4964F8249980 for ; Wed, 3 Nov 2021 14:34:44 +0000 (UTC) X-FDA: 78767865288.06.6767C98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 394849000380 for ; Wed, 3 Nov 2021 14:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635950083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sBt63SHG96A9DgD47p6bvc+4BuRpJkNrq/VWF2GMPR0=; b=UR445JqUlGNE4EdLRVh25T1e5z99NKcmklHYjR4Q4hIInbfkGlPek5GnqI8wIbvWownOY/ RVg80Dq0IRo5QTTAgtGmGsEBs1KL7v2T7+wZUrAct5F7510qCISx6TaZVUdTpbKayWSqV/ SEP9XUDlL4HTH9lnJtYxSUwJs+WsQbc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-NU2BJUTbNw2ManfRoqAm1g-1; Wed, 03 Nov 2021 10:34:40 -0400 X-MC-Unique: NU2BJUTbNw2ManfRoqAm1g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6D93800053; Wed, 3 Nov 2021 14:34:37 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.144]) by smtp.corp.redhat.com (Postfix) with ESMTP id C5F115F4EA; Wed, 3 Nov 2021 14:34:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <163584174921.4023316.8927114426959755223.stgit@warthog.procyon.org.uk> <163584184628.4023316.9386282630968981869.stgit@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, Jeff Layton , Ilya Dryomov , Dominique Martinet , linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] folio: Add a function to get the host inode for a folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1037301.1635950073.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 03 Nov 2021 14:34:33 +0000 Message-ID: <1037302.1635950073@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 394849000380 X-Stat-Signature: z5w7hnscuhsgj9at47csgch4ezcmrdgp Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UR445JqU; spf=none (imf23.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1635950072-929612 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox wrote: > > + * For folios which are in the page cache, return the inode that is h= osting > > + * this folio belongs to. > = > This looks like an editing mistake. Either you meant > 'return the inode that hosts this folio' or > 'return the inode this folio belongs to' > (and i prefer the second). Yeah - I'll go with that. David