From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE0BC433F5 for ; Mon, 31 Jan 2022 11:42:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 708936B0078; Mon, 31 Jan 2022 06:42:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B8296B007B; Mon, 31 Jan 2022 06:42:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57F5E6B007D; Mon, 31 Jan 2022 06:42:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 4455C6B0078 for ; Mon, 31 Jan 2022 06:42:54 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 038DE96F39 for ; Mon, 31 Jan 2022 11:42:53 +0000 (UTC) X-FDA: 79090395468.06.0E5704B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf31.hostedemail.com (Postfix) with ESMTP id 8590D20005 for ; Mon, 31 Jan 2022 11:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643629373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tOXTBxgzYYVn2QXCw8QZ7CKKTkbQpmyv4faAp7utGos=; b=eum+H/QbqYfhlRdjqS5ibpZtIdcmMuJvweyl3eOjrDinT+a+Y0RJI3G+egjTZ0C8RILoiN t/Fxb1suqrlMrRfcLZ1eiHtMjR7owifmcJiutHiXFzYiRRGmrCqwfiNmONJVtGt5RpqsHv V0EK4+aN8v0jt5E2Q0onng1+VWgVFaw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-liIDzsHvO_yr8vmIKQLGHA-1; Mon, 31 Jan 2022 06:42:51 -0500 X-MC-Unique: liIDzsHvO_yr8vmIKQLGHA-1 Received: by mail-wr1-f69.google.com with SMTP id j21-20020adfa555000000b001db55dd5a1dso4716757wrb.15 for ; Mon, 31 Jan 2022 03:42:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=tOXTBxgzYYVn2QXCw8QZ7CKKTkbQpmyv4faAp7utGos=; b=1wxBsmkkppfIgNsCghD1SCTrEc/74jPkrHRqAD9SLlKX9AtM9cljIatvsd7qj/f/lW qxUgSDQ3NQete6Wl7jZksTTvYmQ8N4xQFtLhpL7IYAC9ZsJfnJLWjMsSba8QxGfoiQji EqtUCf4pc37+LZTJffvvS63kXNxEVlD9d4RfHjauu3T8UM/IeOYqzBeXoguY/UR8ExbK kaFMwRCEItzKHVNnBzq/LkWuyLLFX8pZQN9MXlcHWxoeFnSAAxGZju/Zrz7BZlff5Tc6 r/O5U8qgwgYcWGBqgyogbrh0FO6Z5CZTp31j5QM7gk57VsFYZhJgmo3qsM7XEh+O/JCP bJUw== X-Gm-Message-State: AOAM532asYx2e6qBm8adC5HZfzjEsDVGMHBtaKHLcLExaAOzvFothAT5 ruxcuhc383mg8OAJW74aHAwbPyo9jALbT2ifXPkgaa3DWcws3GIwH28mlFwPUZ0uw6WeroD6DxB iEupqr8OyRM4= X-Received: by 2002:a05:6000:42:: with SMTP id k2mr16978182wrx.79.1643629370770; Mon, 31 Jan 2022 03:42:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjql6TSVUvnRyPm35redu5/e4PWa1U/B9bmeapBfHVIbbP+l6wLhWfKJGgA94bnq+AKH3PpA== X-Received: by 2002:a05:6000:42:: with SMTP id k2mr16978162wrx.79.1643629370542; Mon, 31 Jan 2022 03:42:50 -0800 (PST) Received: from ?IPV6:2003:cb:c709:b200:f007:5a26:32e7:8ef5? (p200300cbc709b200f0075a2632e78ef5.dip0.t-ipconnect.de. [2003:cb:c709:b200:f007:5a26:32e7:8ef5]) by smtp.gmail.com with ESMTPSA id k12sm11958920wrd.110.2022.01.31.03.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 03:42:50 -0800 (PST) Message-ID: <10293d6c-c2d6-2277-0634-bdd237fc23de@redhat.com> Date: Mon, 31 Jan 2022 12:42:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v1 2/2] drivers/base/memory: determine and store zone for single-zone memory blocks To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Rafael J. Wysocki" , Greg Kroah-Hartman , Michal Hocko , Rafael Parra References: <20220128152620.168715-1-david@redhat.com> <20220128152620.168715-3-david@redhat.com> <20220131112909.GB18027@linux> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220131112909.GB18027@linux> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 3rftsaqn8tzkqrghu8tqr4wumkps6hqx X-Rspam-User: nil Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eum+H/Qb"; spf=none (imf31.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8590D20005 X-HE-Tag: 1643629373-631917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [...] having accidentally skipped two comments. > >> There are three scenarios to handle: > ... > ... > >> @@ -225,6 +226,9 @@ static int memory_block_offline(struct memory_block *mem) >> unsigned long nr_vmemmap_pages = mem->nr_vmemmap_pages; >> int ret; >> >> + if (!mem->zone) >> + return -EBUSY; > > Should not we return -EINVAL? I mean, -EBUSY reads like this might be a > temporary error which might get fixed later on, but that isn't the case. We should, and I could have sworn I fixed that up last-minute. >> +static struct zone *early_node_zone_for_memory_block(struct memory_block *mem, >> + int nid) >> +{ >> + const unsigned long start_pfn = section_nr_to_pfn(mem->start_section_nr); >> + const unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block; >> + struct zone *zone, *matching_zone = NULL; >> + pg_data_t *pgdat = NODE_DATA(nid); > > I was about to complain because in init_memory_block() you call > early_node_zone_for_memory_block() with nid == NUMA_NODE_NODE, but then > I saw that NODE_DATA on !CONFIG_NUMA falls to contig_page_data. > So, I guess we cannot really reach this on CONFIG_NUMA machines with nid > being NUMA_NO_NODE, right? (do we want to add a check just in case?) > >> +#ifdef CONFIG_NUMA >> +void memory_block_set_nid(struct memory_block *mem, int nid, >> + enum meminit_context context) > > But we also set the zone? (Only for boot memory) Yes, it's derived from the node internally, though, and not supplied explicitly. Renaming it could be misleading IMHO. -- Thanks, David / dhildenb