From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E74C74A5B for ; Wed, 29 Mar 2023 23:37:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 914C06B0078; Wed, 29 Mar 2023 19:37:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C4F36B007D; Wed, 29 Mar 2023 19:37:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78CDF6B007E; Wed, 29 Mar 2023 19:37:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 66A1E6B0078 for ; Wed, 29 Mar 2023 19:37:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3D42A407FC for ; Wed, 29 Mar 2023 23:37:05 +0000 (UTC) X-FDA: 80623548810.02.AE139F5 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by imf17.hostedemail.com (Postfix) with ESMTP id C485340003 for ; Wed, 29 Mar 2023 23:37:02 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="k/FQyrwk"; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=BEfOkYGG; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf17.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680133023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ye5uVDhHYiNIqI0JdBUFxCn8OM1mdc0S9cE9tlpDOgk=; b=dLE9Rb2VIaqLaSsr4dP9mhgalCt5ksMDt4HqlQ9aNcgnWrshHpATkBvNODLrVFfjL3VQER JqpHj+kkPzZTIFp8mgeT4XOgfc8uhRy25Z/yAMjkoxLG9po/Ez3xgzdAVpGkGVu6oQ4zj5 V+v/UFqjuZCWsQ3D7JM+aVHKIlOYUkM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="k/FQyrwk"; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=BEfOkYGG; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf17.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680133023; a=rsa-sha256; cv=none; b=wwcORvr6HGDyk2LYIwErgLVlG/e16anjfX6dLTJAkNB5M/ou+1yV7/jprgyrNBvZEfflqv F6XpXvool++RCMocerKIo9zTaHWbRFmAXBBOOH7ibPA46fOyApwbBnVSQoYS+8BzvooPen /tMEWxTdYRJF1HLdYyZfzuxCckWYQXw= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680133022; x=1711669022; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=D+aEMixN3+lt/Ao/5W/66ZnjrxKALm8DtG5/s/spqgo=; b=k/FQyrwkhBg9+B+grtGXItx2jC4/rss+hE4m21YtoKiGZ6X0V5uDdHKa NL0iXrfuQtOs2bmZfYKlHXHYetyPkIrDGVFeisCBU1k8aLAg9uBYkNrQV U4KphdXs6N0BvC48sCXNLLeyzKdukmIWmygpdjZi9AgFugKIbDZc/F6yh 2PjrnQHLZGZWNoi655Ogtsh8v2BqYcKAlghPKYH2gmdA/LZU2jfAeUWOS TEMkgZUOj79V+3gFcGm0bRNThXUgrtaizdbLZAdwNI6ZFmi3krgRWVmch 1yaqRqg0fpoSpOqVujG/ZR7vmPMzWegzriPWZmc3TrkgN7mk+f6sqQkCt A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="225113832" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:37:01 +0800 IronPort-SDR: u5oGSxkwQf1AZ6z2Rs3BI6QTB3h7M+hFdzHb4c2kH3YgrV8cd0vC7UDyWTtRxDRRyaxwTwAKyC M6T3cfRJ+3HoO2rh08gQwJu0ovbhAxQeWYNrdHEy3YO9W1Cgb1d/4Y1IQ/efZGto1lQ2BfuC2j InAb8I2+xt1Owgo0zLH2aspOlNgnqj5EMZCxPnCNejr/b9K1iYKt618RK760YmJU75Yv6Qz7SI y+KO2bqWIiv54xgGuuXJDlCQxPzTqw8BlNQJtN52Cf3JktjRsRXliMkVpdpwxLGYr8jdc12VHW knQ= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:53:10 -0700 IronPort-SDR: WhED06KYUH1VDPP8hIPPl1UgX5QjzWb+OSqpNquFi4u7H1Jasscy2FyaJbEjpJIoJ2BKYTmLi8 NdI9J3WO2rUAuLaGM3P0ujV2kACjt2gYzX9j+dfOxhIlrhJgzo4YoVM6XQkSPfrQWL3boiF4fl PTko6teF1TLE+eogif+i/mO2PgRp4NcXB60IZYcTUnjtH/ux/CG3BdadGRVxZu5O85zPEySwOx oKkzNqGFRFYlxdVSpZD1HnHwsD4I3p1s2P1h3A/Uqo8Mj27OUnBeGVb5v8Dno0CXiVwqIzzyDI SY8= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:37:02 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2yP2zGyz1RtVy for ; Wed, 29 Mar 2023 16:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680133020; x=1682725021; bh=D+aEMixN3+lt/Ao/5W/66ZnjrxKALm8DtG5 /s/spqgo=; b=BEfOkYGGZfGNwIpK9BEJ0FcFAcVLpJnvJCRHtqvX1ZSykJX+oaz TiKbQqo/rlFcgsGqwufvYk8MIKGTrAb9+RSsrJd3SZRo35htZKTw14P+p/eD7q/J ceqYnoioxpQ1yuPl8XxWYNWTguv/974yBA9klFhcKgFSo99Ul+ebGjc2RjgypZF9 Edw+QnL+wy8s1G7+GYq/bnFol1i1bpAhLPRysri8L0LJfnjE4aU2+znrrOFBtHLe kPJoBqaYr+hUOYgCZHb6OjFE3dVfncY3OnznL/HrXrJLgp+49NV58WitEWdLbK+H SGYLaXAVc//3j4H7s6ktsYfZi2PJTJuLWOw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FA1ziZiHtm12 for ; Wed, 29 Mar 2023 16:37:00 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2yK4J91z1RtVm; Wed, 29 Mar 2023 16:36:57 -0700 (PDT) Message-ID: <1027d62b-d09f-e9fb-b8fb-9876fda97f82@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:36:56 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 14/19] floppy: use __bio_add_page for adding single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C485340003 X-Stat-Signature: y7mr4swnbcz14fagfx1gzfa6ejpqum3x X-HE-Tag: 1680133022-345782 X-HE-Meta: U2FsdGVkX1/b19mktkF6R3UJHHaMDcFCdMxvXsBEZs6D/EvxJS4L9hu4+VkIw3VGrEwCods+NSMgOMa5V3zVqlweejHsmidM1EBGfGGCEmLCJlLxONgZjC7Vx5F4NwpBX8S1lDyX0qAGhcj+gysIJ+gsL5TKG3WrC17FVWG1cFOQ+DQDt76P9k7telIUKgUAQ3WaNLld8l9wFIxe3gYwLthkZ5dfCQPb/TPQBxQ0Q+AIXGNWk2nQxBNWbc42jWvuRMF1DsdtbKvvs241X5V61AiSDz7KFuJyvC5wKw7ITOlHK5tjOoDUz8/9EsjcvyvEGwWnUN9GZmz/TvgG2nfxJosnZFJLuw9oNUn88VcG0hhZQY61if2+iGmMqd/ofb9I8NudM4IHVBK1TOtbrAvRuS+dfEWA/aWmD8RVRwlUVijYIKICkvn37SaC5UiaR4S43s+EmqC04KUsLx+e/0phFuUatKyI0AtS7jh4IhpgUjhvX3Nc5l3yo3Kv9+J/WxzUhJ9YEfZyrk/h/vWYi90voj6BdqaR3MbH0HHXWGn/W4EQnvBoz7Orl6oRZjB/rcqlYok5G2HSJ8UveETC+wRYUIIM38MoGY/pQz1KqFp/ahntW+bNrqob/1cbrP+lap0Sb8o8RzG8mOnVlfDlXBzETFhMB22xzelAmRpRRq+rjFBJIpSQ44r4pBkO/L7HcHsj8gbgu8Nk5Y8IHYwDkzlu5VbOWhPh6hAM1GUJMS7tLI1+eEKRDen46IT/m/0Uweu1+SR6295vYsLWsWQM76fqQ5BB9NC/vyfYj3Re9JDG5ErusNoK+cYTFx23vPs+s5QKeYCiKzwBFJp7q2xh91u1jCEdGvbv7nOSHIftLhMfLbjKtimJ3SC/9Q1ykwlc6rxKb5f1JzggCRcA9hodZMt+Y6qLQQmKt0NYUcBfQh+dXILjbck8W56WxJDGonw2O1RN/Ui+CzfW3Kz0rRB3WOW 7xd8cupO 9XAtGCu7tBOyZTyr06C2GlM0+9A5ZwGaGSLNUXuVEutwryfoBaep24sAv0iugdMYd3DCw4nD60/aDwqo7b/rsrihBCpmOCb22sylUm5hgbQPoe40hUuiLFqil421QP0DtFPb7yCPTSFKPW97AnbIc6SNNdsXI29mOZAiLOKTScXyV4wb1ZFAL+fN5Icc5pSbBTrOFdVNv7pC8oUbazuBARnF8QOMCNvyM6r9kzCONVG8O5DjqVo26IsHEsYPzwksaOoqjruZORuLsjQc04K4EPjW8XccQBR0naUM8fRjSJquFgiFP9xt/luJG++ak6VpXm1qG1QZQOtJ7QKJ4FxOXH+S5juIEigJeH2z/m+k6WKXPXyL/5mpZp/2C1vcsJAZMOdHLCpPlxHLm7U5mFOfJ5gcKqKNDO7dhSlK7VKPabcfODlljRyqsWIQgkk/HMruvoGw5VdQ00H2oQobb7rskMrWFa/eHVi4D4sIlnV+yIJBHHAo5mF9iY1jmB2ehp4/ca62E02xbiOiRGW6GIrd5VRwQroFOTmqKpikJIYwlKR6FcFT2/0Ju0Zj2dpKfQ/fZlT67B0w4+Fe4WXAAGPROfqQB53IXYC8USglMC3uQUNs+AAUfHufnhO+NDIttlzfXBihn+D3DpdNrouO2jCw8nP78uWXVedmkoAcXf91D/raYp/jwvaelTvdMew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:06, Johannes Thumshirn wrote: > The floppy code uses bio_add_page() to add a page to a newly created bio. > bio_add_page() can fail, but the return value is never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research