Re: [PATCH] low-latency zap_page_range

[Robert Love <rml@tech9.net>]

On Mon, 2002-07-22 at 11:05, Linus Torvalds wrote:

> How about adding an "cond_resched_lock()" primitive?
> 
> You can do it better as a primitive than as the written-out thing (the
> spin_unlock() doesn't need to conditionally test the scheduling point
> again, it can just unconditionally call schedule())
> 
> And there might be other places that want to drop a lock before scheduling
> anyway.

Great idea.  I have similar functions in my lock-break patch...

This introduces "cond_resched_lock()" and "break_spin_lock()".  Both
take a lock has a parameter.  The former only drops the locks and
reschedules if need_resched is set.  It is optimized to only check once,
etc.  The later simply unlocks then relocks.

Patch is against your BK tree.

	Robert Love

diff -urN linux-2.5.27/include/linux/sched.h linux/include/linux/sched.h
--- linux-2.5.27/include/linux/sched.h	Sat Jul 20 12:11:07 2002
+++ linux/include/linux/sched.h	Mon Jul 22 11:16:55 2002
@@ -865,6 +867,30 @@
 		__cond_resched();
 }
 
+/*
+ * cond_resched_lock() - if a reschedule is pending, drop the given lock,
+ * call schedule, and on return reacquire the lock.  Note this assumes
+ * the given lock is the _only_ held lock and otherwise you are not atomic.
+ */
+static inline void cond_resched_lock(spinlock_t * lock)
+{
+	if (need_resched()) {
+		spin_unlock_no_resched(lock);
+		__cond_resched();
+		spin_lock(lock);
+	}
+}
+
+/*
+ * break_spin_lock - drop and immeditately reacquire the given lock.  This
+ * creates a preemption point if it is the only held lock.
+ */
+static inline void break_spin_lock(spinlock_t * lock)
+{
+	spin_unlock(lock);
+	spin_lock(lock);
+}
+
 /* Reevaluate whether the task has signals pending delivery.
    This is required every time the blocked sigset_t changes.
    Athread cathreaders should have t->sigmask_lock.  */

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/