From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "David S. Miller" <davem@redhat.com>
Cc: rml@tech9.net, Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
riel@conectiva.com.br, wli@holomorphy.com
Subject: Re: [PATCH] generalized spin_lock_bit
Date: 21 Jul 2002 01:26:25 +0100 [thread overview]
Message-ID: <1027211185.17234.48.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20020720.152703.102669295.davem@redhat.com>
On Sat, 2002-07-20 at 23:27, David S. Miller wrote:
> Why not just use the existing bitops implementation? The code is
> going to be mostly identical, ala:
>
> while (test_and_set_bit(ptr, nr)) {
> while (test_bit(ptr, nr))
> barrier();
> }
Firstly your code is wrong for Intel already
Secondly many platforms want to implement their locks in other ways.
Atomic bitops are an x86 luxury so your proposal simply generates
hideously inefficient code compared to arch specific sanity
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-07-21 0:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-20 20:21 Robert Love
2002-07-20 20:40 ` Linus Torvalds
2002-07-20 21:15 ` William Lee Irwin III
2002-07-20 21:19 ` Robert Love
2002-07-20 21:20 ` Robert Love
2002-07-20 23:25 ` Linus Torvalds
2002-07-20 22:27 ` David S. Miller
2002-07-20 22:46 ` Robert Love
2002-07-21 0:26 ` Alan Cox [this message]
2002-07-21 1:31 ` David S. Miller
2002-07-21 13:48 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1027211185.17234.48.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox