From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F5AC433F5 for ; Tue, 29 Mar 2022 06:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17B6F8D0002; Tue, 29 Mar 2022 02:45:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12BDA8D0001; Tue, 29 Mar 2022 02:45:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01A358D0002; Tue, 29 Mar 2022 02:45:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id E60BF8D0001 for ; Tue, 29 Mar 2022 02:45:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 227611828AC95 for ; Tue, 29 Mar 2022 06:45:41 +0000 (UTC) X-FDA: 79296488082.20.C5188C7 Received: from mx1.emlix.com (mx1.emlix.com [136.243.223.33]) by imf07.hostedemail.com (Postfix) with ESMTP id 80E0740005 for ; Tue, 29 Mar 2022 06:45:40 +0000 (UTC) Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id D545D5F8EA; Tue, 29 Mar 2022 08:45:38 +0200 (CEST) From: Rolf Eike Beer To: Christoph Hellwig Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: mm: use mmap_assert_write_locked() instead of open coding it Date: Tue, 29 Mar 2022 08:45:37 +0200 Message-ID: <10178697.CBVEcFiDRS@mobilepool36.emlix.com> In-Reply-To: References: <5827758.TJ1SttVevJ@mobilepool36.emlix.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5766660.gleqY7jeCr"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Stat-Signature: 685uydndsuuagwp3b8m81rskbbb61gyf Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of eb@emlix.com designates 136.243.223.33 as permitted sender) smtp.mailfrom=eb@emlix.com; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 80E0740005 X-HE-Tag: 1648536340-138556 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --nextPart5766660.gleqY7jeCr Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Rolf Eike Beer To: Christoph Hellwig Date: Tue, 29 Mar 2022 08:45:37 +0200 Message-ID: <10178697.CBVEcFiDRS@mobilepool36.emlix.com> In-Reply-To: Am Dienstag, 29. M=C3=A4rz 2022, 08:36:39 CEST schrieb Christoph Hellwig: > On Mon, Mar 28, 2022 at 10:24:51AM +0200, Rolf Eike Beer wrote: > > In case the lock is actually not held at this point this also avoids a > > stale lock reference if built with NDEBUG. >=20 > The change looks good: >=20 > Reviewed-by: Christoph Hellwig >=20 > But I don't think NDEBUG is a thing in the kernel. You are right, it was in tools/include/linux/kernel.h and I didn't spot the= =20 prefix. Andrew, maybe you could just delete the sentence when you add the=20 Reviewed-by? Eike =2D-=20 Rolf Eike Beer, emlix GmbH, https://www.emlix.com =46on +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR B 3160 Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Ust-IdNr= =2E: DE 205 198 055 emlix - smart embedded open source --nextPart5766660.gleqY7jeCr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iLMEAAEIAB0WIQQ/Uctzh31xzAxFCLur5FH7Xu2t/AUCYkKrEQAKCRCr5FH7Xu2t /LXcBADMuAegclXembgVJmHq0YcEloLQWTaJRtS92hzIVkoOWoPOLiv9eDVPRin7 prtThu86pU+RMyxgDF9t0rO304qTCVXtZ3yuL8O1g1DGEBp+aCIaXvpBW2CuxUO+ BCVCmXDNrGHIx7ZS7ZVs/trKfFOROvdkxLcLnAILsM4636Orjw== =zfeV -----END PGP SIGNATURE----- --nextPart5766660.gleqY7jeCr--