From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F461C27C53 for ; Sun, 9 Jun 2024 16:04:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2598F6B0088; Sun, 9 Jun 2024 12:04:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 208B26B0089; Sun, 9 Jun 2024 12:04:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A9896B008C; Sun, 9 Jun 2024 12:04:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E1E216B0088 for ; Sun, 9 Jun 2024 12:04:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7DFBD407F2 for ; Sun, 9 Jun 2024 16:04:00 +0000 (UTC) X-FDA: 82211821440.23.3BBA60D Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 94D8E12000B for ; Sun, 9 Jun 2024 16:03:57 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RT8on42j; spf=pass (imf29.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717949037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=2VNLbj93PjSART7sD685Za7R6d9S+vSVdbT1Jxc7+AY=; b=3ipDj5EYNxCQcu7OT/VCeGNn/FJldsFzXvJu/lRFviA6rbVLdt/3QiDVcVRrewCRoaWN0x PuVlQ9r/ykWnzecQ4SHrvmxrqjfpuJDhJzkIikW4ZHcjnYTYqrmDUGMPf3YiGVMU+QpVPR Yt0Kz2cJHRpX2Xo1ADVJJ0xBntD63ug= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717949037; a=rsa-sha256; cv=none; b=dE0VwKc2r+aynAkO0Zh84GUocrAUnyDn7LVttimemiwTwc0h0HQotWNu/U9tSEXT97ihuo b9kuAgauPNlyhr00sA3E69KmllSQrajys0JCTducST7h5MS0zoSpXdrKzK5WiuyapSrY8f vheQPi1JJO4K/oKQq7VTKfaPQKJwiO8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RT8on42j; spf=pass (imf29.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52bc035a7ccso2336696e87.2 for ; Sun, 09 Jun 2024 09:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717949036; x=1718553836; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2VNLbj93PjSART7sD685Za7R6d9S+vSVdbT1Jxc7+AY=; b=RT8on42jpHa2RDNRm7sreAz/RXMeo+1JzVSPfBgOu+RKjsLeq27WV4w4yY1pQWDPT1 ERsdc6XnYxE7rn/3TQQg88O9EY2fTVggeWNk6BIPgUgeekoiCgoLpLSDnu9YY7rZa6f4 PShMUhthOI/uK9mIN+vz9ZDR/xrBoIlYs9Un7cCFzDCQ4/qzfDxi6xGk3BJV4/vBArYS 1QZT1j3NaBnv0OC7ribzDheQeWjcZDmGoozH2CKQjMIJU071YLmiVk7URzvgoCPQ/BBt 3iEjIvEvNIRJ+QWL0kbMV+v7SdoNmz2oUty0O0EzAd2oJ1iVvgcgHyirxzxDc81l42Ih G7FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717949036; x=1718553836; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2VNLbj93PjSART7sD685Za7R6d9S+vSVdbT1Jxc7+AY=; b=qvH8EggWQ3XPFY0G7osLwdeCD0jxBRDR1v5Zr8FA2gkKxSZnahsn6Dx+jaMCDPr2eP 8Iqme21mdPFe9/lfKLRXrMdgdtKwoLPnQGvGkl7Erp4GAyZnH7q3nHZNM7G/g11FlVxg SGTN7sIjmljAN45QlN/CTVyLx3N6dXro12WT9gbSdCMR8LfTjY4GY+uptHNBs3xg+rkn MqZDGnzwrtKVRxf3+MXiF/6cdi0Q6zvP51aj/DA1uyXqfJcYvGx2aZcRprYrwMqs70NJ t1qUWxLodPDfbyZnKwy4//KSm5XteBi9RQlV+lVwa9X8jERtmn23lqNJW2/xKnNNBJME MSBQ== X-Forwarded-Encrypted: i=1; AJvYcCWy9R2VaQTABlw76ZzR8WHdu2qP20HUcTzN1UHoGUnlgCCWZajKxWsYtTpADuiQwmj5h/TUiFSvVA/kKxkvogxyOII= X-Gm-Message-State: AOJu0YwiUHqRo9+JWoCxIWbTEBpfMT/7Td452oVleMUEXiZKZMx2JDGx OVHu84rSIJUfnSXfnQJjagITqFxnlF5jgKPrUcU9bMuP6tkHfvHdHKsgohfFXQo= X-Google-Smtp-Source: AGHT+IGVIKuHGzbO1QP1oVSmFQWhwh0Upqk/8HkvnNom2ucX7YAhQ+a9WXovzeXN3e+1uk9SG/pSwQ== X-Received: by 2002:a19:5f5b:0:b0:520:c2c1:153a with SMTP id 2adb3069b0e04-52bb9fd2521mr4412443e87.58.1717949035267; Sun, 09 Jun 2024 09:03:55 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c1aa3e4sm114257815e9.15.2024.06.09.09.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jun 2024 09:03:54 -0700 (PDT) Date: Sun, 9 Jun 2024 19:03:50 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Kefeng Wang , Andrew Morton Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , ying.huang@intel.com, Baolin Wang , David Hildenbrand , John Hubbard , Mel Gorman , Ryan Roberts , liushixin2@huawei.com, Kefeng Wang Subject: Re: [PATCH] mm: fix possible OOB in numa_rebuild_large_mapping() Message-ID: <100add53-aa58-44ce-a15d-8438001fb2b9@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607103241.1298388-1-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 94D8E12000B X-Rspam-User: X-Stat-Signature: g87afcdoynsgj1dj483a8mkagg5tzkyj X-HE-Tag: 1717949037-116572 X-HE-Meta: U2FsdGVkX18rQem3fDk7c8r+1BoAOF4jerQS5YRsCkSRqFU5TD70TGYz6U5GZvvCgPGSyUL2vkXrqokyKa/jeSwBsdP6SCbofocwh7tnPLf25kEmKBlcy6vE+O5RRJ5aPA3vaOUaDXg/2PATAqfoYUq/xXOzfu3qoNwDoX5UJySyjL4JmET5HQzRxrADfd2qrAfR9BeeCWZr2TSA3+HPcQqvNH3x/hLqLphgRRqXKB7LRQf9vlhORHdjmuvW9iRudboIwb6sCnqsVLBx7GPrmFy7A3AvzViKCUAb8HcPaTzih+TnjeZwB+PUEpsmRRk28FCjiI7fZxGvMMnczKskJrEQsV04UEcfSnnfwaKd0rxyolewuy2aM8fI+ZBxAFWw1d32yXYvJib+VbM9ry8p8/BTXHLiwvzGwAorLL232wFID6j/tDMzZhwqDNqFtbKTFiTP3yWwFkfU3AXhvmYSXitK4Th33op/XAJQoa6YAQpM29t1oq61msQkYdnbIpvXJnyxuAp8Bpu1gMycds3+XoQBmHfgM81Q22+5qtuV/VFd8Xfh/2AlZF8Gh3YfZ6SccJohfZFJeA6Ik3wjQeGPBCrTJl2Vpf/GYuodN9eq0wJlhZQhDhixxmwLrX7q13l4HzkgYjiH+Z/k2yeQboTnVoPA+d8DVcYJb+VBFbbhl+/Hlf+BYdHM3Aw247usoFZzFqzpjS2f1i7U8R2v2u0zI9Nhdb7rn5EBxcDnTu5vjraR0xCH6zzKZ/iZFfQDQxy70IWnkh1Fq6bGsUtytWbHcvWJCcaQj+o8hKMJP+8q49v3rg++G41/cWimcH9F2i/gpDNs4u1WhmYMYsBoTlzuMlzLDzV2hI3sRvQKkyphmLJirfEi1g4uN1GDh1NOYytxUKCBYGeOfLd+iL5VS+3oKnRSbrKmEYSGDO/BggbQCOpX4ebTCCEY3XH/AeHvxFSDlg7LmOtWk5Ky5+DWbqQ csnl9lvB 0zKTA2dsiKuS1yk053CMNMoMUFRY+E3wQVqzziMTk3G2fRx/kbtjb6jQ7U3km12IeBVD5eNU86187Bgp9ztwkor9BdXQT6CvAEX5czDXOat63h30p28v0mX7LRXiQtpx01I0cftFaXi0eAb1Dt6RvJ1UPZH7eeSjHyh/GfOnJzA93izLlHcqli+IEeiqaSOzhfWeXxk5KMFcDW+p6xTRm/xgoiIfZIh4sGK4qcdXVsCTwnt8FXgbpLY521ZgxkJna6zYpcWUGjAOAQNUn4d5Cj1i7O4veK4yiMDBKGAJFT0sHgF8l6md1YnPJB4/WMs077HTKYSyozPUZk520wqtor2gV7S3PZyQZ9fewsLA1rdhu0TXcrhjAd39Wp8t5bb4hDdUayy0ZkFhJesIHSJc39AWbyWmpPnAC2/gGkaY7r00wwsMJXndxS4BzcAjWGWiblpw/sIo9EFE7As1D+gO0QJvf8p179RQ44F8DVfEmdQ3BNvy7bfYVHFY00MmTWEbSqRJgDgXLBvyj/Rp7+l+jHCbr9RDUoZcbEx32xeEPDjapAmAlxjJzmocSDrHDIyUOmE6JQ0l5EC/uVu2h45fDyxB4hMC9e99c8Auw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kefeng, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-fix-possible-OOB-in-numa_rebuild_large_mapping/20240607-183609 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240607103241.1298388-1-wangkefeng.wang%40huawei.com patch subject: [PATCH] mm: fix possible OOB in numa_rebuild_large_mapping() config: mips-randconfig-r081-20240609 (https://download.01.org/0day-ci/archive/20240609/202406092325.eDrcikT8-lkp@intel.com/config) compiler: mips-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202406092325.eDrcikT8-lkp@intel.com/ smatch warnings: mm/memory.c:5370 do_numa_page() error: uninitialized symbol 'nr_pages'. vim +/nr_pages +5370 mm/memory.c 2b7403035459c7 Souptick Joarder 2018-08-23 5265 static vm_fault_t do_numa_page(struct vm_fault *vmf) d10e63f29488b0 Mel Gorman 2012-10-25 5266 { 82b0f8c39a3869 Jan Kara 2016-12-14 5267 struct vm_area_struct *vma = vmf->vma; 6695cf68b15c21 Kefeng Wang 2023-09-21 5268 struct folio *folio = NULL; 6695cf68b15c21 Kefeng Wang 2023-09-21 5269 int nid = NUMA_NO_NODE; d2136d749d76af Baolin Wang 2024-03-29 5270 bool writable = false, ignore_writable = false; d2136d749d76af Baolin Wang 2024-03-29 5271 bool pte_write_upgrade = vma_wants_manual_pte_write_upgrade(vma); 90572890d20252 Peter Zijlstra 2013-10-07 5272 int last_cpupid; cbee9f88ec1b8d Peter Zijlstra 2012-10-25 5273 int target_nid; 04a8645304500b Aneesh Kumar K.V 2019-03-05 5274 pte_t pte, old_pte; d2136d749d76af Baolin Wang 2024-03-29 5275 int flags = 0, nr_pages; d10e63f29488b0 Mel Gorman 2012-10-25 5276 d10e63f29488b0 Mel Gorman 2012-10-25 5277 /* 6c1b748ebf27be John Hubbard 2024-02-27 5278 * The pte cannot be used safely until we verify, while holding the page 6c1b748ebf27be John Hubbard 2024-02-27 5279 * table lock, that its contents have not changed during fault handling. d10e63f29488b0 Mel Gorman 2012-10-25 5280 */ 82b0f8c39a3869 Jan Kara 2016-12-14 5281 spin_lock(vmf->ptl); 6c1b748ebf27be John Hubbard 2024-02-27 5282 /* Read the live PTE from the page tables: */ 6c1b748ebf27be John Hubbard 2024-02-27 5283 old_pte = ptep_get(vmf->pte); 6c1b748ebf27be John Hubbard 2024-02-27 5284 6c1b748ebf27be John Hubbard 2024-02-27 5285 if (unlikely(!pte_same(old_pte, vmf->orig_pte))) { 82b0f8c39a3869 Jan Kara 2016-12-14 5286 pte_unmap_unlock(vmf->pte, vmf->ptl); 4daae3b4b9e49b Mel Gorman 2012-11-02 5287 goto out; 4daae3b4b9e49b Mel Gorman 2012-11-02 5288 } 4daae3b4b9e49b Mel Gorman 2012-11-02 5289 04a8645304500b Aneesh Kumar K.V 2019-03-05 5290 pte = pte_modify(old_pte, vma->vm_page_prot); d10e63f29488b0 Mel Gorman 2012-10-25 5291 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5292 /* 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5293 * Detect now whether the PTE could be writable; this information 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5294 * is only valid while holding the PT lock. 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5295 */ 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5296 writable = pte_write(pte); d2136d749d76af Baolin Wang 2024-03-29 5297 if (!writable && pte_write_upgrade && 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5298 can_change_pte_writable(vma, vmf->address, pte)) 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5299 writable = true; 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5300 6695cf68b15c21 Kefeng Wang 2023-09-21 5301 folio = vm_normal_folio(vma, vmf->address, pte); 6695cf68b15c21 Kefeng Wang 2023-09-21 5302 if (!folio || folio_is_zone_device(folio)) b99a342d4f11a5 Huang Ying 2021-04-29 5303 goto out_map; nr_pages not initialized d10e63f29488b0 Mel Gorman 2012-10-25 5304 6688cc05473b36 Peter Zijlstra 2013-10-07 5305 /* bea66fbd11af1c Mel Gorman 2015-03-25 5306 * Avoid grouping on RO pages in general. RO pages shouldn't hurt as bea66fbd11af1c Mel Gorman 2015-03-25 5307 * much anyway since they can be in shared cache state. This misses bea66fbd11af1c Mel Gorman 2015-03-25 5308 * the case where a mapping is writable but the process never writes bea66fbd11af1c Mel Gorman 2015-03-25 5309 * to it but pte_write gets cleared during protection updates and bea66fbd11af1c Mel Gorman 2015-03-25 5310 * pte_dirty has unpredictable behaviour between PTE scan updates, bea66fbd11af1c Mel Gorman 2015-03-25 5311 * background writeback, dirty balancing and application behaviour. bea66fbd11af1c Mel Gorman 2015-03-25 5312 */ 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5313 if (!writable) 6688cc05473b36 Peter Zijlstra 2013-10-07 5314 flags |= TNF_NO_GROUP; 6688cc05473b36 Peter Zijlstra 2013-10-07 5315 dabe1d992414a6 Rik van Riel 2013-10-07 5316 /* 6695cf68b15c21 Kefeng Wang 2023-09-21 5317 * Flag if the folio is shared between multiple address spaces. This dabe1d992414a6 Rik van Riel 2013-10-07 5318 * is later used when determining whether to group tasks together dabe1d992414a6 Rik van Riel 2013-10-07 5319 */ ebb34f78d72c23 David Hildenbrand 2024-02-27 5320 if (folio_likely_mapped_shared(folio) && (vma->vm_flags & VM_SHARED)) dabe1d992414a6 Rik van Riel 2013-10-07 5321 flags |= TNF_SHARED; dabe1d992414a6 Rik van Riel 2013-10-07 5322 6695cf68b15c21 Kefeng Wang 2023-09-21 5323 nid = folio_nid(folio); d2136d749d76af Baolin Wang 2024-03-29 5324 nr_pages = folio_nr_pages(folio); 33024536bafd91 Huang Ying 2022-07-13 5325 /* 33024536bafd91 Huang Ying 2022-07-13 5326 * For memory tiering mode, cpupid of slow memory page is used 33024536bafd91 Huang Ying 2022-07-13 5327 * to record page access time. So use default value. 33024536bafd91 Huang Ying 2022-07-13 5328 */ 33024536bafd91 Huang Ying 2022-07-13 5329 if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) && 6695cf68b15c21 Kefeng Wang 2023-09-21 5330 !node_is_toptier(nid)) 33024536bafd91 Huang Ying 2022-07-13 5331 last_cpupid = (-1 & LAST_CPUPID_MASK); 33024536bafd91 Huang Ying 2022-07-13 5332 else 67b33e3ff58374 Kefeng Wang 2023-10-18 5333 last_cpupid = folio_last_cpupid(folio); f8fd525ba3a298 Donet Tom 2024-03-08 5334 target_nid = numa_migrate_prep(folio, vmf, vmf->address, nid, &flags); 98fa15f34cb379 Anshuman Khandual 2019-03-05 5335 if (target_nid == NUMA_NO_NODE) { 6695cf68b15c21 Kefeng Wang 2023-09-21 5336 folio_put(folio); b99a342d4f11a5 Huang Ying 2021-04-29 5337 goto out_map; 4daae3b4b9e49b Mel Gorman 2012-11-02 5338 } b99a342d4f11a5 Huang Ying 2021-04-29 5339 pte_unmap_unlock(vmf->pte, vmf->ptl); 6a56ccbcf6c695 David Hildenbrand 2022-11-08 5340 writable = false; d2136d749d76af Baolin Wang 2024-03-29 5341 ignore_writable = true; 4daae3b4b9e49b Mel Gorman 2012-11-02 5342 4daae3b4b9e49b Mel Gorman 2012-11-02 5343 /* Migrate to the requested node */ 6695cf68b15c21 Kefeng Wang 2023-09-21 5344 if (migrate_misplaced_folio(folio, vma, target_nid)) { 6695cf68b15c21 Kefeng Wang 2023-09-21 5345 nid = target_nid; 6688cc05473b36 Peter Zijlstra 2013-10-07 5346 flags |= TNF_MIGRATED; b99a342d4f11a5 Huang Ying 2021-04-29 5347 } else { 074c238177a75f Mel Gorman 2015-03-25 5348 flags |= TNF_MIGRATE_FAIL; c7ad08804fae5b Hugh Dickins 2023-06-08 5349 vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, c7ad08804fae5b Hugh Dickins 2023-06-08 5350 vmf->address, &vmf->ptl); c7ad08804fae5b Hugh Dickins 2023-06-08 5351 if (unlikely(!vmf->pte)) c7ad08804fae5b Hugh Dickins 2023-06-08 5352 goto out; c33c794828f212 Ryan Roberts 2023-06-12 5353 if (unlikely(!pte_same(ptep_get(vmf->pte), vmf->orig_pte))) { b99a342d4f11a5 Huang Ying 2021-04-29 5354 pte_unmap_unlock(vmf->pte, vmf->ptl); b99a342d4f11a5 Huang Ying 2021-04-29 5355 goto out; b99a342d4f11a5 Huang Ying 2021-04-29 5356 } b99a342d4f11a5 Huang Ying 2021-04-29 5357 goto out_map; b99a342d4f11a5 Huang Ying 2021-04-29 5358 } 4daae3b4b9e49b Mel Gorman 2012-11-02 5359 4daae3b4b9e49b Mel Gorman 2012-11-02 5360 out: 6695cf68b15c21 Kefeng Wang 2023-09-21 5361 if (nid != NUMA_NO_NODE) d2136d749d76af Baolin Wang 2024-03-29 5362 task_numa_fault(last_cpupid, nid, nr_pages, flags); d10e63f29488b0 Mel Gorman 2012-10-25 5363 return 0; b99a342d4f11a5 Huang Ying 2021-04-29 5364 out_map: b99a342d4f11a5 Huang Ying 2021-04-29 5365 /* b99a342d4f11a5 Huang Ying 2021-04-29 5366 * Make it present again, depending on how arch implements b99a342d4f11a5 Huang Ying 2021-04-29 5367 * non-accessible ptes, some can allow access by kernel mode. b99a342d4f11a5 Huang Ying 2021-04-29 5368 */ d2136d749d76af Baolin Wang 2024-03-29 5369 if (folio && folio_test_large(folio)) Are folio_test_large() and folio_is_zone_device() mutually exclusive? If so then this is a false positive. Just ignore the warning in that case. 8d27aa5be8ed93 Kefeng Wang 2024-06-07 @5370 numa_rebuild_large_mapping(vmf, vma, folio, nr_pages, pte, 8d27aa5be8ed93 Kefeng Wang 2024-06-07 5371 ignore_writable, pte_write_upgrade); d2136d749d76af Baolin Wang 2024-03-29 5372 else d2136d749d76af Baolin Wang 2024-03-29 5373 numa_rebuild_single_mapping(vmf, vma, vmf->address, vmf->pte, d2136d749d76af Baolin Wang 2024-03-29 5374 writable); b99a342d4f11a5 Huang Ying 2021-04-29 5375 pte_unmap_unlock(vmf->pte, vmf->ptl); b99a342d4f11a5 Huang Ying 2021-04-29 5376 goto out; d10e63f29488b0 Mel Gorman 2012-10-25 5377 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki