From: "Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
To: "Wu, Fengguang" <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
Linux Memory Management List <linux-mm@kvack.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: RE: [next:master 4658/4676] undefined reference to `copy_user_page'
Date: Thu, 22 Jan 2015 15:12:15 +0000 [thread overview]
Message-ID: <100D68C7BA14664A8938383216E40DE040853FB4@FMSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <201501221315.sbz4rdsB%fengguang.wu@intel.com>
Looks like mips *declares* copy_user_page(), but never *defines* an implementation.
It's documented in Documentation/cachetlb.txt, but it's not (currently) called if the architecture defines its own copy_user_highpage(), so some bitrot has occurred. ARM is currently fixing this, and MIPS will need to do the same.
(We can't use copy_user_highpage() in DAX because we don't necessarily have a struct page for 'from'.)
-----Original Message-----
From: Wu, Fengguang
Sent: Wednesday, January 21, 2015 9:40 PM
To: Andrew Morton
Cc: kbuild-all@01.org; Linux Memory Management List; Wilcox, Matthew R
Subject: [next:master 4658/4676] undefined reference to `copy_user_page'
Hi Andrew,
It's probably a bug fix that unveils the link errors.
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e1e12812e428bcaf19e23f83e09f602d161b8005
commit: c429f45c501ac95383be9e37467d4e6ca08782c1 [4658/4676] daxext2-replace-the-xip-page-fault-handler-with-the-dax-page-fault-handler-fix-3
config: mips-allmodconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout c429f45c501ac95383be9e37467d4e6ca08782c1
# save the attached .config to linux build tree
make.cross ARCH=mips
All error/warnings:
fs/built-in.o: In function `dax_fault':
>> (.text+0x5dc6c): undefined reference to `copy_user_page'
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-22 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 5:40 kbuild test robot
2015-01-22 15:12 ` Wilcox, Matthew R [this message]
2015-02-05 20:21 ` Andrew Morton
2015-02-05 20:22 ` Wilcox, Matthew R
2015-02-05 20:25 ` Andrew Morton
2015-02-05 20:45 ` Wilcox, Matthew R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=100D68C7BA14664A8938383216E40DE040853FB4@FMSMSX114.amr.corp.intel.com \
--to=matthew.r.wilcox@intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox