From: Dave Hansen <dave.hansen@intel.com>
To: Colin Cross <ccross@google.com>, Kees Cook <keescook@chromium.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"Michal Hocko" <mhocko@suse.com>,
"Alexey Gladkov" <gladkov.alexey@gmail.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Michel Lespinasse" <walken@google.com>,
"Michal Koutný" <mkoutny@suse.com>,
"Song Liu" <songliubraving@fb.com>,
"Huang Ying" <ying.huang@intel.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Yang Shi" <yang.shi@linux.alibaba.com>,
chenqiwu <chenqiwu@xiaomi.com>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Mike Christie" <mchristi@redhat.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"Amit Pundir" <amit.pundir@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Christian Brauner" <christian.brauner@ubuntu.com>,
"Daniel Jordan" <daniel.m.jordan@oracle.com>,
"Adrian Reber" <areber@redhat.com>,
"Nicolas Viennot" <Nicolas.Viennot@twosigma.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
"John Stultz" <john.stultz@linaro.org>,
"Pekka Enberg" <penberg@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Oleg Nesterov" <oleg@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Jan Glauber" <jan.glauber@gmail.com>,
"Rob Landley" <rob@landley.net>,
"Cyrill Gorcunov" <gorcunov@openvz.org>,
"Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
"David Rientjes" <rientjes@google.com>,
"Hugh Dickins" <hughd@google.com>,
"Rik van Riel" <riel@redhat.com>, "Mel Gorman" <mgorman@suse.de>,
"Tang Chen" <tangchen@cn.fujitsu.com>,
"Robin Holt" <holt@sgi.com>, "Shaohua Li" <shli@fusionio.com>,
"Sasha Levin" <sasha.levin@oracle.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Minchan Kim" <minchan@kernel.org>
Subject: Re: [PATCH v7 3/3] mm: add a field to store names for private anonymous memory
Date: Thu, 3 Sep 2020 11:00:10 -0700 [thread overview]
Message-ID: <1007943b-1f93-8734-96f2-041cf69340dc@intel.com> (raw)
In-Reply-To: <CAMbhsRS6OWxfWqgSnAgQaK-Mvb0C-qUSE7az1uinpGe_JuXyvA@mail.gmail.com>
On 9/3/20 10:54 AM, Colin Cross wrote:
> On Thu, Sep 3, 2020 at 10:31 AM Kees Cook <keescook@chromium.org> wrote:
>> I would prefer having strict validation of the input over escaping the
>> output, so to that end how about making close to "variable name" sane:
>> [-\.a-zA-Z0-9_ ] ?
>
> A quick skim of existing Android cases shows at least ":()" as well.
> I'm not sure what you mean by validation of the input - the input to
> the prctl is a userspace pointer, which is stored in the kernel for
> later reads. Storing the string in the kernel at prctl time would be
> infeasible. The kernel can only validate the value when producing
> /proc/pid/maps. It could replace disallowed characters with _ though.
>
>> if it should be wider than that, how about printable minus \n \r \f \v [ ] ?
>
> That would work fine for Android.
Looks like /proc/$pid/maps and smaps filter out \n (and probably more)
for filenames. I created a file named "foo\nbar" then mmap'd it.
Here's what I got:
> 01324000-7f1854634000 rw-s 00000000 00:30 9308668 /home/dave/foo\012bar
Can we leverage what we already do for filenames?
next prev parent reply other threads:[~2020-09-03 18:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 16:14 [PATCH v7 0/3] Anonymous VMA naming patches Sumit Semwal
2020-09-01 16:14 ` [PATCH v7 1/3] mm: rearrange madvise code to allow for reuse Sumit Semwal
2020-09-01 16:14 ` [PATCH v7 2/3] mm: memory: Add access_remote_vm_locked variant Sumit Semwal
2020-09-01 16:14 ` [PATCH v7 3/3] mm: add a field to store names for private anonymous memory Sumit Semwal
2020-09-03 13:25 ` Kirill A. Shutemov
2020-09-03 13:43 ` Matthew Wilcox
2020-09-03 13:58 ` Kirill A. Shutemov
2020-09-03 15:59 ` Colin Cross
2020-09-03 17:31 ` Kees Cook
2020-09-03 17:54 ` Colin Cross
2020-09-03 18:00 ` Dave Hansen [this message]
2020-09-03 18:00 ` Kees Cook
2020-09-03 18:09 ` Dave Hansen
2020-09-03 18:26 ` Colin Cross
2020-09-03 18:40 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1007943b-1f93-8734-96f2-041cf69340dc@intel.com \
--to=dave.hansen@intel.com \
--cc=Nicolas.Viennot@twosigma.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amit.pundir@linaro.org \
--cc=areber@redhat.com \
--cc=bvanassche@acm.org \
--cc=ccross@google.com \
--cc=chenqiwu@xiaomi.com \
--cc=christian.brauner@ubuntu.com \
--cc=corbet@lwn.net \
--cc=daniel.m.jordan@oracle.com \
--cc=ebiederm@xmission.com \
--cc=gladkov.alexey@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=holt@sgi.com \
--cc=hughd@google.com \
--cc=jan.glauber@gmail.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mchehab+huawei@kernel.org \
--cc=mchristi@redhat.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=mkoutny@suse.com \
--cc=oleg@redhat.com \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=rob@landley.net \
--cc=sasha.levin@oracle.com \
--cc=serge.hallyn@ubuntu.com \
--cc=shli@fusionio.com \
--cc=songliubraving@fb.com \
--cc=sumit.semwal@linaro.org \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox