From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5960DEB64D7 for ; Wed, 21 Jun 2023 18:02:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED68A8D0005; Wed, 21 Jun 2023 14:02:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E85D18D0002; Wed, 21 Jun 2023 14:02:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D75448D0005; Wed, 21 Jun 2023 14:02:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C91888D0002 for ; Wed, 21 Jun 2023 14:02:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 87BFE14084D for ; Wed, 21 Jun 2023 18:02:57 +0000 (UTC) X-FDA: 80927525994.14.2F755BC Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf18.hostedemail.com (Postfix) with ESMTP id DA1CA1C000A for ; Wed, 21 Jun 2023 18:02:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WlDhY0OA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687370541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ghR3ONQ0xCWF/XsVVqlYhvKkezqnfnGRVsn4IWmNqPA=; b=e+QKERjJj/moBgLIRo+nxorm6rfRN49zC+FTEY9MyE57EKc897RkPh+28PoBz0x8JBrGkl TjKW84H/sPJG1GGt1bEXWq2AaNRkBiOOfHgpR+ko8dcvboPh/qF2wIbMZupdBoOZXKEwoQ fA0qp/qN9g2Mn4OoHcyBRnneuhX5md0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WlDhY0OA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687370541; a=rsa-sha256; cv=none; b=tc6t6IFtJdaAzYuJP2a5JFI+zfYEdShD1pau41O3Trw2R36ZvezUKJU6Zcv2PkOx+eXL52 XLlZN2O0a/5cd3THVqc3XZrI8ak5xy9/8LI/sxNzky+vp7U1+H7fgZ3IXHTUfqIRKp9hc6 zC2OuzSCFXND+Q9Gc+cWi914nlk96ks= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-25e820b8bc1so3042430a91.1 for ; Wed, 21 Jun 2023 11:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687370539; x=1689962539; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ghR3ONQ0xCWF/XsVVqlYhvKkezqnfnGRVsn4IWmNqPA=; b=WlDhY0OAVtt9U/sOOElyyyzC8WQUo6poFN2oaUUbgXb/+d/IcLxLnp/l+UzGUwpnTP qNVRgaSawr/Lks/MVqkXW3vhZ6kxmceUTjHXM6jlyF1GptNr1dqW3DS3mHch/GovOfRj eeIG+2GeD7qLThk604Ls1Dm6ulCuVqsz3HJeNzmw20ui3f1km/wN1Lsn8new91sCB9f4 Y/9gdFH2EtmVLBvhgPnz+wuC+/IaW12lqMa1hMv5oCDcKrdyydt7o/GSHiNNyTmCgyjE n6f4GEOsh48n3nZWOX6uYilALlQZViylNfVYvHM7mBlUYr3PiCQJ7ZWpUMc3s5dLxZUE OjEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687370539; x=1689962539; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ghR3ONQ0xCWF/XsVVqlYhvKkezqnfnGRVsn4IWmNqPA=; b=jvbLZNyigmEMrtGRi46PiAT77HUGRU6dgLr1+yk8wzya/YPndaR8ZK1H4G2GvJjwe9 19/OCCpccYcGuUw6REEN8092HBaicEQDl7Qp5IaELCnRC4GNFRuI0UaU+tkrRzjJ/irQ gkluWL/1aSvaeD7RdW3h3uolcmIK+lyopY9q21SKosOLQs6bE2J/bbMc+tlBUk5sqVxh GJm9QF047hZHjkYo6gUkzcThOzYGDBPDTYCNxkr8coq5nyhEipmElAwQ8YhZIQAsc+Qr ma0Argyxvs4HKPNT1RPwAoy0Mme7D6IgpYN7h8Et/MBHSPNreDk3IjKxVnu+v2AWwWOm HXlg== X-Gm-Message-State: AC+VfDyI5Rec9wmLR9p7ym1fby6ZnCEm1QDCxV4zPEy40JC8JJoxDs1b zKo8eLGLAmPfvXk8ppzN1VE= X-Google-Smtp-Source: ACHHUZ6mRoAo2s2oCkgP3Wp2nUTJXsXUGVHNcWUvqJUw9GFNXu1TCgqL3BU4dWywAqRpkfH2O6TdSg== X-Received: by 2002:a17:90b:4c8d:b0:25e:a5b2:8463 with SMTP id my13-20020a17090b4c8d00b0025ea5b28463mr11111864pjb.8.1687370539354; Wed, 21 Jun 2023 11:02:19 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id r10-20020a638f4a000000b005439aaf0301sm3329045pgn.64.2023.06.21.11.02.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2023 11:02:18 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs From: Nadav Amit In-Reply-To: <20230620144618.125703-3-ypodemsk@redhat.com> Date: Wed, 21 Jun 2023 11:02:05 -0700 Cc: mtosatti@redhat.com, ppandit@redhat.com, David Hildenbrand , "Russell King (Oracle)" , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , gor@linux.ibm.com, agordeev@linux.ibm.com, Christian Borntraeger , svens@linux.ibm.com, "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Kees Cook , "Paul E. McKenney" , frederic@kernel.org, Will Deacon , Peter Zijlstra , ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, Arnd Bergmann , rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, Andrew Morton , sebastian.reichel@collabora.com, Mike Rapoport , aneesh.kumar@linux.ibm.com, the arch/x86 maintainers , linux-arm-kernel@lists.infradead.org, linuxppc-dev , linux-s390 , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <10050BB1-15A4-4E84-B900-B21500B2079B@gmail.com> References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> To: Yair Podemsky X-Mailer: Apple Mail (2.3731.600.7) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DA1CA1C000A X-Stat-Signature: ugr8qdjjgj3694pfjhn99jdj53tjsfwn X-HE-Tag: 1687370540-728362 X-HE-Meta: U2FsdGVkX19koA62ficL05pft+9o6lSKAf0DvmeYhCOmHMNxK2elf1xt9r+hOWYQh1tkdqg1RTqV3FWnZ2ZYRLcUFxHHO4FSr4w1wx4ySVT94FU9bRQzAzn4K+tNMCPgF7ryN6N8MkQDZG/FnHdcVdfkXIJ37NRnbtk856YXnQ+hkjaFa+B3W8ecNC9sqiz7qywHxK9UiWrbB9R40R6jLDCOBdbeGVoCM3ixE+Mbq7RSNtEa1TYfBIEJsZcwEvy7x/PFDVYcxEEM8DKtyF9smFgx6pQsOAywq1051Zx/BDAzR94U305sXazy0eFUeIEF4fyqBSMatx6+TgDhN26gOierkcAN7+QuNejzo/k4X13xLiOtyks29rxJLbYeMlRDTvtgCz1hCkMLo7grhLgSalWH8S/XLrHAT7v7U8K2a+XqGfYperQJuau6ibT0xepME/J7rZtXXTr0KhX0b7VB0AQ2qnJJcCAWzjWnG9kV0RRoMfQ9Y4ov+6UPm2xUJWNXsj+LfFb+KjRdnxMuFTwrd6KNIasnKv4Sd47tLb8//2FeQuW+Wd/qWKDrRyS5ueNfdZ3AbgeszG8TRk9UEuO7PCgXC0xdmarVy2te6+vWH9XdE+a6ExyjtRl9oCjyoPx/zzKY+8cs1EwgUYNPTV69kxdZ3tbKiDQclYmHxU9CaMxjGXPS2vvJKGpHaWY6YoWeKmuYkykpbNS/FRZwS6i4m098TzG0560zUqknWq0kc6Xgiby39FbswPyAKbTzV/izrKbQcl0UsYQfJKA2+24D8kQgCBPw1Vk8cBJAbbst/VaJEiFJs/Y0Ods52jv4ZB3HPHPMn2zmSCw8O6/ohTYkmXNFlrb1h23Sg1J3JrpcLtipkvrVXw13AwKReaT9o0hN3XZ3ELb32k7YelSW4g/N/+ExJ7cCyvRaRSsdZKppH0v6SiL//2QuN5S4Y47tAUWcK8PuoVuD+z0IC+JUul9 zZH3e/ty zc6CMePtGS8VBQsrGAtazhQEPq0sjJmtCvlnIPAq7RtambjErmrsMkS5dL/QYIGNCCGbVjHTW5zaa0KRvawQyRey7u69xs6avAxQ/ZDo5Bih1kKUyb2g/rpG9BW7wRDjoRk6sZayUVjw/4tlQi8gr/EyGVokzyfxZxsKmNiLKARWnEJMVBcqMVbObUGau7JaPta4hbmseSBpkRFyNvfjD5LWMLEAOIsv/9zb2ccRtwnhC3BupROqlr3J+hutWhx5VayxCcs8y1V7bsHaSbrc5gFmODRp4w4NDogKEijQ/nYQP15pSu+JztsBX5rz43QjQ7enHM2i65i/xg8HAW4Y/1CaUIL5WMFlwo9+hQioUUg3lP/6tnE39EYYU0xiV8ouGS24mh5cmEiubbP5SC1pMzRn8D9CmZUMT8xyR44OTZZdlwEbNt+iGeWs/KdV0SDIYVqyrUmF1BBJLWH/VOuI7UvwrLbMzcSggQDqNNs7OF1m6HvPK64iFpmoS++upmbF31kMzl8Gfn8no62UmR4n/ZdVveCFvOUFm8ylhmXtcmkM806ireQnqJl5GTcCLkpGxGrXpnuoDPh93Kerw502tVMJRW8LiwfNHT6Yq9iKHlPiGsmxc7ZVpbV/fFDhbfnc6wImS1dnnUKUvrJk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >=20 > On Jun 20, 2023, at 7:46 AM, Yair Podemsky = wrote: >=20 > @@ -1525,7 +1525,7 @@ static void collapse_and_free_pmd(struct = mm_struct *mm, struct vm_area_struct *v > addr + HPAGE_PMD_SIZE); > mmu_notifier_invalidate_range_start(&range); > pmd =3D pmdp_collapse_flush(vma, addr, pmdp); > - tlb_remove_table_sync_one(); > + tlb_remove_table_sync_one(mm); Can=E2=80=99t pmdp_collapse_flush() have one additional argument = =E2=80=9Cfreed_tables=E2=80=9D that it would propagate, for instance on x86 to flush_tlb_mm_range() ? Then you would not need tlb_remove_table_sync_one() to issue an = additional IPI, no? It just seems that you might still have 2 IPIs in many cases instead of one, and unless I am missing something, I don=E2=80=99t see why.