From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57729C48292 for ; Mon, 5 Feb 2024 18:17:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 761686B007E; Mon, 5 Feb 2024 13:17:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69BD76B0083; Mon, 5 Feb 2024 13:17:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F35D6B007E; Mon, 5 Feb 2024 13:17:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 003E56B0081 for ; Mon, 5 Feb 2024 13:17:22 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BED13160A05 for ; Mon, 5 Feb 2024 18:17:22 +0000 (UTC) X-FDA: 81758557524.11.9716D3E Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf15.hostedemail.com (Postfix) with ESMTP id EC298A001D for ; Mon, 5 Feb 2024 18:17:20 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=W4jqSCxk; spf=pass (imf15.hostedemail.com: domain of rientjes@google.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707157041; a=rsa-sha256; cv=none; b=NN9cvNd65OK2xgeEqPMtZ/Ch4jWYj5vEJBHtn91cRHo45QREd/mZS+waGS6r+j+fdpboNW 1LAQalsFJ4aIDGo/xScBecNweog/sGXguueYmLB9GjayVEcYVfxCgmSpKJV0IZO9m+IYda FVey4UZFh4ODJu23EMFIsGmQRYid6VE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=W4jqSCxk; spf=pass (imf15.hostedemail.com: domain of rientjes@google.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707157041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cX9WAPSzH4fqkr2cx56EeyUyPmftS4JQYp9iTqHs4jU=; b=tnmCtjxZQwjdTuHNJ8ZRZ2nK3GFcJlUi5WzBhEpz5tRFPv9rJ3TccrG16l+mPuoIH+FVZF +KURTt9lU9jVW8dztrGEISeABCDUO03MqvSK9LRNZKMYubx6hGpKwr+aX04lPQJdzbEQT3 GfFXkjAL1btSZG4Msz1uRQ0NKkE3m4M= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d94691de1eso14135ad.1 for ; Mon, 05 Feb 2024 10:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707157040; x=1707761840; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=cX9WAPSzH4fqkr2cx56EeyUyPmftS4JQYp9iTqHs4jU=; b=W4jqSCxkH1+suSBl4w0YiyH0KHKEYFw+d4Wxu0/fVF+6eYCQHHqWovHPrYfq+p60/7 Zafg///rpF4xDNVOoQnWxeK0bIjerkLhGaQxnJ1uPMVbxz6Pu0p4HFxVZRLHPi6m5cMg HRMEM2y0qXJmImx+GLZYNU1CkwOGelwTolxla74HBgBhtenbEp6XeF1yet6M02bkiGhj 1KGoGgzSxFWkdWyAG3MuFI3PUW/nNfZ7aOtVw5Zntm5CA3X30PUGeBOGOF3M4c5QJy+f MH8gNlYsM5oXiaUFQCnmmNdBjgGl0moYBlQl0uGgHui7JMOLtde0GdM9hPkZ58K0hMas Wvww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707157040; x=1707761840; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cX9WAPSzH4fqkr2cx56EeyUyPmftS4JQYp9iTqHs4jU=; b=SB4il5vDim31MRtl6jx6lvOsI+VAziiJxA2MpO56qFE1G6h8dMGFljhmJw5WfP04Sy HK0DLDiLs/O74h/U242jHhX9m7t7PQDiFHs1waIvnPfZlc1Tkc6RNJWK8C/AD9jXrFC3 fFeuuGQ9vwEBnLDa2hxfjkrHqesTLTge03FYgfkRXKdw27WAeYsW1rl9TWmMHxZkk3j3 z5LkjTekz4+1Ni5rue7L0kFNKnM0jtDZVIDfdOIV1Y0oAW4Gr+ZxkLA4Yqz5l+KwzrDI vLyCclNAAsdoGwrf/jI+3NR5rGHs1q4b9er6u/F8AJwnsFkEWZGU0mtqihRlGuQOYUu+ yHSw== X-Gm-Message-State: AOJu0YzKKwkQOBqRvuAvUWzsttkTZ0EukEKHh2c9X9egIrmTzXtbRmDP FFyp4vr0aXezpY5Vmv1olgl6VxibVp2UY5L1crXnP8eAmKmhjcrTwrm2Hoillw== X-Google-Smtp-Source: AGHT+IFD2bxvnxC7BpQTp8KmxRVWUA+M/qBIDa14XXXsuIVQO9Nh3SCU2daAzOIynb5YUxw92RfoxQ== X-Received: by 2002:a17:902:d4c5:b0:1d9:3524:3db2 with SMTP id o5-20020a170902d4c500b001d935243db2mr18895plg.11.1707157039512; Mon, 05 Feb 2024 10:17:19 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXsxPxLfa2k54v4x5TlGXwZXe1WxnrM5K3MasLtL0cn2JrO90COHkhNgnl0vzB4rw8viOinysHy90WT9cQUFcQ6O9UaCggIf1lU7qbfzQDBZr030iGczwa7K6KT+uEu65oRoPDEplBeOa5TyGGVStwXwXfNYunUe9lZ6ERNKkEcf+gIeacpu8Vp/L6J9PPeAzyzvPUatk53kMeBle07NNZjUZpDKOKwY4hBjLe+1Z25eVfNgftx69+ucJk8fRrb82c/zsKOFSYIV5F4cjUCdfSemDq6 Received: from [2620:0:1008:15:1e99:232a:d721:3dff] ([2620:0:1008:15:1e99:232a:d721:3dff]) by smtp.gmail.com with ESMTPSA id ch11-20020a17090af40b00b00296a265acbbsm2117063pjb.25.2024.02.05.10.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 10:17:19 -0800 (PST) Date: Mon, 5 Feb 2024 10:17:18 -0800 (PST) From: David Rientjes To: Robin Murphy cc: joro@8bytes.org, will@kernel.org, pasha.tatashin@soleen.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, john.g.garry@oracle.com Subject: Re: [PATCH v3 2/3] iommu/iova: Reorganise some code In-Reply-To: Message-ID: <0ffc92e6-9640-293b-8fbf-b2e45badad91@google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EC298A001D X-Stat-Signature: c7brryj1donjf4brkuspg1ni6m1gki85 X-Rspam-User: X-HE-Tag: 1707157040-18501 X-HE-Meta: U2FsdGVkX19qn1p4wa3Uhk7hICdjbCXUBUuyk6rjiQ82xTOrf45TRwW7vEii0TDKccwsJjVBCWMmqbthUihdk2cv/axbiK7UulahMWFRvU1+IVYrSCsRILGnUzhq3PLFNLBwejft9eXWRTplLeriNrz+3AOVT3/l0E3p3J3x3h8HLbUm8ZScsf1n0kdNqSX3lh4J7QK43HNLMIwqpoFrgRoIoElz0fIC083HKa4dZe1CUwnZtcjO9C/HWfMOOPgEe8XQocLn7HR5cl3+54mEozJqDVMphDDYWlAVXIFVYskW6DXL0FJQaIPBk+HUaNQXgO6dZ9OAvpNDTOtgBwK1pW8+jYz69G2AJd/PkRJya07CYiu88b7cb+c2tMoOemQ9w95HK5EtbceTxlFoI0pEctwyiqWpo83iTlOBoCdiDsrugSpKXOoszGgMCg1DYk1d7nCVKYxKuXxrp9Tq0PrvHxFg8/GzlFV2VF+wpnNEtE95wWlqPaJKH8EPrImcLWvVvruxlRGP+kmFZ9OnXTg/dEGTpW5WUkxW9vjhDFH0Hb9y3RtQCfRF8AUYw3ysUL8txoSNsN9HkDDYb4SrT6tVgdeP4ZY5pnvmT9xDCIu7pnq9HSS3YqvujOIZTL8L6AfjfMVQvlAD3Ih8BlJZa4ZcwxQwlFiZ5saOnOSkiFxioKaa5qG6Cyk4DAjRFu6cItb7tj2CHcI+QJfRIFZjJY3PJVyg5M60b99IP4s4gbTmT3AeOexmu0n6NAq5axH2SRolJBKQQfoGc3H0ugjDiloG6tV/M3RDubtGZHF+gCGgxAic/S9oUAtgUZUWgg/ktcTh7/nQdv6baWPAfoWwIwYcdaso+6LDZbJuxHfbPeCKjqaaWOR6uqVITkQ66NZj42qbpC1Pb+lW9g2/qPFMnZNenIEoM/a5TlEOtCMis+Uo02D9398Nt2rVJtS7PoSBtbdSEBGve2D1F51FvSEy17H v1LIQrne NIomkqK7h3TVnp3TxUrKm3gvKF6zVwZooQgJYkQm6rms3pUfv9ETpxoibQxYSxf4raUCv70haD28BU2GTAkmCj6+LBq/zg18P0J+HfgL4t1z4gM2ALuDn6ONjm+YeiWQ3gA3ZfXFN+p7SBnmuL+aQJ0us9HG8Bwz5v06bgtimPhA/0taYCfhM7d9+MgWwO8GID6ihep2g+YCVAXHeOVoPzNFglL8KkpbXzLha0zk8Ntq18e2xyIOIHSH60X+kBYRURgcUrKe/yhicjgj9bw0hDwPz96+jJ7VrzHL1z3n0ZAA6GS6cH7Wl2ExAW1ef70pK1SRfar0YYqlmGw8q0VsC1JMGzaNUE5f5DclN4HmZc2d6EY9AoJ/VZn3oOrttdAQLecqtehgfzm12kvG8/r9P6fg0Km/OlM2fWKU+bYX75hhRlPOyJ2dLDfdBsc7Zk/AAREnqOV+8Q8knPy8pw9c3h1epl7y8zL++AoHE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 Feb 2024, Robin Murphy wrote: > The iova_cache_{get,put}() calls really represent top-level lifecycle > management for the whole IOVA library, so it's long been rather > confusing to have them buried right in the middle of the allocator > implementation details. Move them to a more expected position at the end > of the file, where it will then also be easier to expand them. With > this, we can also move the rcache hotplug handler (plus another stray > function) into the rcache portion of the file. > > Signed-off-by: Robin Murphy Acked-by: David Rientjes