From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D38EC433EF for ; Thu, 13 Jan 2022 15:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D86A6B0073; Thu, 13 Jan 2022 10:46:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0889E6B0074; Thu, 13 Jan 2022 10:46:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6BCB6B0075; Thu, 13 Jan 2022 10:46:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id D92576B0073 for ; Thu, 13 Jan 2022 10:46:55 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8F37889B4A for ; Thu, 13 Jan 2022 15:46:55 +0000 (UTC) X-FDA: 79025691990.20.AE88096 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 1F9E4140005 for ; Thu, 13 Jan 2022 15:46:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F129C1F387; Thu, 13 Jan 2022 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642088813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NMMOJAr/nOnpKZlb714JwJhyEXP557sdSv675jlH2BI=; b=KxAtbzDG1pyPsyzqVmQlxbZId53X3xrbCB2dWLLkW8gb+o16O3JGeenJnHjBdXuP6kQ6DZ fCtOAqIRH9ZWHRNKfUwzYrTuDoYFeN+702Drbswj4rlrXylg8vPj10uuiV2XAHrHWDo6pP d2sTsJpNLve7hosSWaodZJC3E+wJMiI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642088813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NMMOJAr/nOnpKZlb714JwJhyEXP557sdSv675jlH2BI=; b=wS4tK9Fe0o85B2PtNRKsLE0hZKULejN2ObmGQYsEhGPKE564/JjCINO7xD+6s7I9luxB0e S2uZWXnfn+ZpdNAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 97CC11330C; Thu, 13 Jan 2022 15:46:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QLNdJGxJ4GHmHwAAMHmgww (envelope-from ); Thu, 13 Jan 2022 15:46:52 +0000 Message-ID: <0ff40eb4-aa9b-ef12-5278-e9dce2354a59@suse.cz> Date: Thu, 13 Jan 2022 16:46:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v4 09/66] mm/mmap: Use the maple tree in find_vma() instead of the rbtree. Content-Language: en-US To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand References: <20211201142918.921493-1-Liam.Howlett@oracle.com> <20211201142918.921493-10-Liam.Howlett@oracle.com> <4207b5a3-efac-40f3-6b42-6713c9283cdd@suse.cz> <20211215180903.huv74nff62lgepsa@revolver> From: Vlastimil Babka In-Reply-To: <20211215180903.huv74nff62lgepsa@revolver> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1F9E4140005 X-Stat-Signature: bhxifqaexqpsbanux8b9hwcmjwscajft Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KxAtbzDG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wS4tK9Fe; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-HE-Tag: 1642088813-439425 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/15/21 19:09, Liam Howlett wrote: >> - the future lookup of address vma->vm_end will return this vma, although >> the address doesn't belong to it. Wouldn't be surprised if this caused >> infrequent mysterious bugs? >> >> Both will resolve with vmacache removal later, but better still fix this. > This is certainly worth fixing. I am surprised that I did not hit a > random bug as you said above, I would expect it to occur as well. > Although, I didn't run each patch individually for long unless I was > tracking down an issue on a rebase. Ah, it doesn't cause a bug because vmacache_find() checks the boundaries of vmas in the vmacache.