From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA83C433F5 for ; Fri, 30 Sep 2022 08:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43E888D0002; Fri, 30 Sep 2022 04:30:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EE058D0001; Fri, 30 Sep 2022 04:30:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 267DD8D0002; Fri, 30 Sep 2022 04:30:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 133458D0001 for ; Fri, 30 Sep 2022 04:30:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D1309ABDFF for ; Fri, 30 Sep 2022 08:30:45 +0000 (UTC) X-FDA: 79968080850.17.BB7F253 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id E359E8000C for ; Fri, 30 Sep 2022 08:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664526643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8CdgI6o1JPgGkTG2jpG4T+E2PTeCFnRXsC1gUO71n9I=; b=UPTO6c/2nv7aCpaR+MO5w/YkTIkVMUR8RAgLgofdhwNYhw2f9EdQkhF3SrfRuhjBgI6dKa fRu1NfIvim1sCTAjx2ALUEmO7zl24MyET+xwrYLFb3jKsTmTysMNVRjSNdp5aehtuzO0Wf QrDxThQ9bSgnaIHN6bwG/E+r9EvAaj0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-672-0m253S1fOGSlui_w6k5Xeg-1; Fri, 30 Sep 2022 04:30:41 -0400 X-MC-Unique: 0m253S1fOGSlui_w6k5Xeg-1 Received: by mail-wr1-f71.google.com with SMTP id e14-20020adf9bce000000b0022d18139c79so407421wrc.5 for ; Fri, 30 Sep 2022 01:30:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=8CdgI6o1JPgGkTG2jpG4T+E2PTeCFnRXsC1gUO71n9I=; b=V0hfa1uweZVIcNEKHnYSTlalLZhuDcn2SOuFAMk0aaVVOMhbEvyqlcw81wl4cQ0Zm1 kWOHrkUNKCPzBlHowkL1rhIP4lyqmr/hpV3MnpJUZYqDAuUr5cUTMkOhkOuOWkATpQbM /uf6XS7Qes1blz2kerRBuEbF17+DHCK+tUDg2l49MbqMQ6jXop2v7n89k9a6sX8WYfJu Ncdg8HGcn80DgMR2qQfabAMtEhuv0GpUkuBVEPDJajRXz4NSXRnhN39yQU2PzTvQMF1w g6wQVzW+qnreks3kWl0Gi+psZYDiomaHIIlT0ph1H++OzWd+sXXRenIvEz56X5qlxE0B T/cA== X-Gm-Message-State: ACrzQf07UtPQXvkDzqJv4IrUn799IBPbah8XNascIg3M/eOPCgswBJ4y g17Y0ZWTRJsSNbR3MevEgNXUUQLZz3DuPp8SjOv1dRKArjdtW1w0kOkF3Th6ZuRLL3HUy9rZAsE NUUBR/OJZpFQ= X-Received: by 2002:a05:600c:4606:b0:3b4:62b3:150b with SMTP id m6-20020a05600c460600b003b462b3150bmr5203340wmo.3.1664526640615; Fri, 30 Sep 2022 01:30:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4kmodJuSR/XONK5ttvI7YsCPMg21LO5DNNlzVaGbZhkWg+ApaqDuIWh4iZiTNEO8Ds1O8B1A== X-Received: by 2002:a05:600c:4606:b0:3b4:62b3:150b with SMTP id m6-20020a05600c460600b003b462b3150bmr5203316wmo.3.1664526640331; Fri, 30 Sep 2022 01:30:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:c00:48b:b68a:f9e0:ebce? (p200300cbc70c0c00048bb68af9e0ebce.dip0.t-ipconnect.de. [2003:cb:c70c:c00:48b:b68a:f9e0:ebce]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c19cf00b003a2f2bb72d5sm8546677wmq.45.2022.09.30.01.30.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 01:30:39 -0700 (PDT) Message-ID: <0fecbcdc-7324-2d76-8452-b60b4638d074@redhat.com> Date: Fri, 30 Sep 2022 10:30:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 1/2] mm: use update_mmu_tlb() on the second thread To: Qi Zheng , akpm@linux-foundation.org, maobibo@loongson.cn, chenhuacai@loongson.cn, songmuchun@bytedance.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, chris@zankel.net, jcmvbkbc@gmail.com References: <20220929112318.32393-1-zhengqi.arch@bytedance.com> <20220929112318.32393-2-zhengqi.arch@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220929112318.32393-2-zhengqi.arch@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UPTO6c/2"; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664526644; a=rsa-sha256; cv=none; b=P1ZXP15ZtVbRQUVKEIp9hFcnmOD4FRGszr7DW8rG/IiJo7evA4mwsM7/otB/iZyaF7jGBf 7Vi6m6QgBoIhixqlm4DCM7j8JpP3Nlv4r7sF4cSUaHHTugaE65PD4MeyOjlyxkSqUUKmc9 4A2SGIiNiqAx5ACfYXabVK0MphsDs9M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664526644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8CdgI6o1JPgGkTG2jpG4T+E2PTeCFnRXsC1gUO71n9I=; b=SX0h5K4sC7/bW2a1zNLGCPr/HufzPE9gmRZjsbQZC485cgq3j+5eWEqNBP0jJ0S5VeXWFY YnqGxBdi51nK8imORUBpxeVWXInd4ecm8tI3fWalHurPTf5imh2BHpIeL6gjLSyMcPMic7 wuFbntVndULzvA9f/xALSfiNVmpdNx4= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UPTO6c/2"; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: aezfadn6imo7mzjtoxcq6op736tinnuo X-Rspamd-Queue-Id: E359E8000C X-Rspamd-Server: rspam05 X-HE-Tag: 1664526643-246824 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.09.22 13:23, Qi Zheng wrote: > As message in commit 7df676974359 ("mm/memory.c: Update local TLB > if PTE entry exists") said, we should update local TLB only on the > second thread. So in the do_anonymous_page() here, we should use > update_mmu_tlb() instead of update_mmu_cache() on the second thread. > Maybe mention here "This only affects performance, but not correctness." Acked-by: David Hildenbrand > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 118e5f023597..9e11c783ba0e 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, > &vmf->ptl); > if (!pte_none(*vmf->pte)) { > - update_mmu_cache(vma, vmf->address, vmf->pte); > + update_mmu_tlb(vma, vmf->address, vmf->pte); > goto release; > } > -- Thanks, David / dhildenb