From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88010C77B72 for ; Tue, 18 Apr 2023 00:22:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB57B900002; Mon, 17 Apr 2023 20:22:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A65408E0002; Mon, 17 Apr 2023 20:22:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9545D900002; Mon, 17 Apr 2023 20:22:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 865938E0002 for ; Mon, 17 Apr 2023 20:22:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 44D72120722 for ; Tue, 18 Apr 2023 00:22:08 +0000 (UTC) X-FDA: 80692609536.28.986E9C3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 87E94A000E for ; Tue, 18 Apr 2023 00:22:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JV548fxo; spf=pass (imf25.hostedemail.com: domain of sboyd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sboyd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681777325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LWVT0pupnAnXrkzUoYLBdfn5iESolFK9tj9P9ubCimQ=; b=Ln5q9nBaEw7rTHJak8fESMvwOcas2kotNEq/azUa7yAxeXUJilwQBtE163R8R/kEO+Oxo5 Yp5OS+r3UQ/10vkONRHKN0so6QdbAe/IBiWDNEFqZ9XiqWT44gSratvTXkXpo0Mt+qy49e GwKl/TbkretgnjKtF7MOLMaA960TsU4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JV548fxo; spf=pass (imf25.hostedemail.com: domain of sboyd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sboyd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681777325; a=rsa-sha256; cv=none; b=VwyjtNCSFnUaYm4bRBDpqON+KSnDWH9yGkFm2EtXGVbSNl9rC0qVOsvcIysXQODrcqjun8 bvflpNJLnPFG9hJ5jj753X/deIR5GedT4d99bS99R+fagOF4xxaqeKTDlpIgal04LaI381 PFtxpcPKds9oGT4KRwEFqcQv6noum0o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8150F62084; Tue, 18 Apr 2023 00:22:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEE6EC4339B; Tue, 18 Apr 2023 00:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681777323; bh=6B9H24R54yv+r+KBdloI2WZn+iJMLoHViIQTdOdI35o=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=JV548fxoNPBFu/4qd9yOffE648bfbnpyWs5PGAt02g2PT1WIQqU0JDmdGDteL7Iup dd7Gr8B1bs2TZmQ8mY78mFZqHiWE1cJk0K1j+zbfAtP5wbtvwXXFYY3tbz2GaDKwws dBKMLa0jFb2TVLJ6qi6XjosEQGA4pi1wo2W/rq9SIiSsKvOmzHejqNxc1g7W5BD1u1 9J0lULT9ngVNlOw+OoqQMNggNipqlm67pLocsg1AicCB4v4/xV3EdEbkFvK8DxTdWn IJgW+G3Gc/OXGdZBwVw017N7rXO9gPsHNGrzQuDVEAeb8y5d1d5Jgv4Jdq2soZnRUa cm+UCH+hIDO2g== Message-ID: <0fe42faa3b34f82cc2fb73ae61460bf2.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230417-bolster-vitality-89d279146497@wendy> References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> <20230417-bolster-vitality-89d279146497@wendy> Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case From: Stephen Boyd Cc: linux-clk@vger.kernel.org, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, Michael Turquette , Paul Gazzillo , Necip Fazil Yildiran , Emil Renner Berthing , Xingyu Wu , linux-kernel@vger.kernel.org To: Conor Dooley , Hal Feng Date: Mon, 17 Apr 2023 17:22:01 -0700 User-Agent: alot/0.10 X-Rspamd-Queue-Id: 87E94A000E X-Stat-Signature: wiqyht9oyoijnizcupdjfn8u4d6tduwx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681777325-258186 X-HE-Meta: U2FsdGVkX19SnBv4C+dwjno874ICrzsSnzHa8jhPWFjP/gWFBURWHzo1/PmioggpceSSPrI7ioRj9csjY6T0OzNIptZ7rxxHg+kuioMWLkJewCphTkV7tqSpl0NdAVTlOKLhG5DFwnxJ/YH/pltHGhPqTzbLoZcFalfJ/Dxz4/Nt3O4hOoTofqnAz8ZKR2sE+g0fkEy/foXlzvqdamqYcYJymG4XNnwUIJfZk+VcuxNBPCLN5Tuu4ineQcfYh3uJFec+soocogFL374gxXBYLJxiZW7erhD3ysJlZVF6VrHDYzTvzvfOLSlESZExhiKqxT+qZnqjDIsFOrm3XiuxSDW7ZpQNO+B7iWv1F3t11rnMkwK56aIaM2kWYBNjVHpg0Y5r4xYQckyMfRCb6YYT/SMOXAW6XEyxKgF7Y6KTZhia2LFcM6y/donxCHvVQ3N9+2diHCsfmz5BJC6ZMg/AxkdEI+UFTx503kQak9D8g9Tv+w1h8sZx8sL/vujptqShOTXjiOmAh7+yCrBbWEAjeOefMuFraa+h1IObNaYWfaLrLX7MCJSTfDpidiR/qP4RBYbk0AWxWMpq6RnPplSIrdM5LK0tXwzZ58pfF+E/bU3lnZInj/kcbQZbxZTzT0P2N1UVBxBzgRF6yUo15wJGgNV9u/lyy5Aif/Lcw3EEdpiJ15sUprXIGmsfxFZXo542dZ+ZmYqHfcIf/9zHk/LXQ3ziD3h/IMzgj/vyI876TrqigZaJD2se651afIbuNRSQBDa0/hrf1JQpT8VZjuFXEznkufalugkwEfopTNJfWmAGGPYduV3X+6OtaqluZ3XM5S4hM6tdrV0AHjsuZuAC6r5UO7SoVgroXHnfTRDMqS+laUOVTQ1tTZzddjrG6lPL+ha1PYrmJFXprGZdSpKnU5wDRXRF8xw/52SKXqZOCCo+5xyICMiyrfGyFyT8NDeBHkYjsJfG4po/mOAHsfK fqpMQXTR /0qZCkRmgufmD0TpThRjp6MS8mxlJxybEJyvnNRFmMrQT+n5LYLg62Db4XqY98Rp7UcZDIbnHoC2mb/sV1PdKSUH4sQ+wvuroUiqz+p4IIuAMd+5pxpn+awGLKOHgy0jyhW1EOiibLMfHcMdfQ7NkfAxWSMRPIRhHx20nj/0sbGOd5haPFeNJUYfgszSQM3b0wQrMcF9XwWg16HuQnNK4f75SaCY1buTpWOtpLjySq+WbnUF6DUQd0DubLqzDlImate/HxHeEwwQY3HGCroROD/rjk4r0akvbEpNawlvznbkResc5ERp1GTco/UWePoULvAgyvFkqRT3/OUSHHNOWh2ROUV33It5D/p+aWLN3c2YIcBj/FTNbiV8Q2bIc1Wob8w/GnDC49HbOQd9H+xw1f/3lXBDAhWLgeLWf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Quoting Conor Dooley (2023-04-17 03:18:35) > On Mon, Apr 17, 2023 at 06:06:29PM +0800, Hal Feng wrote: > > On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: > > > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: > > >> When (ARCH_STARFIVE [=3Dn] && COMPILE_TEST [=3Dy] && RESET_CONTROLLE= R [=3Dn]), > > >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > > >> and CLK_STARFIVE_JH7110_AON. > > >>=20 > > >> Considering RESET_STARFIVE_JH7110 is not a necessary option for comp= ilation > > >> test, we should select it only if ARCH_STARFIVE=3Dy. Also, delete re= dundant > > >> selected options of CLK_STARFIVE_JH7110_AON because these options are > > >> already selected by the dependency. > > >>=20 > > >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system cloc= k driver") > > >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on c= lock driver") > > >> Signed-off-by: Hal Feng > > >> --- > > >> drivers/clk/starfive/Kconfig | 5 +---- > > >> 1 file changed, 1 insertion(+), 4 deletions(-) > > >>=20 > > >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kco= nfig > > >> index 71c1148ee5f6..3fad4adee841 100644 > > >> --- a/drivers/clk/starfive/Kconfig > > >> +++ b/drivers/clk/starfive/Kconfig > > >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > > >> depends on ARCH_STARFIVE || COMPILE_TEST > > >> select AUXILIARY_BUS > > >> select CLK_STARFIVE_JH71X0 > > >> - select RESET_STARFIVE_JH7110 > > >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE > > >=20 > > > Hmm, I don't really follow the logic above. > > > Why not just make the if be `if RESET_CONTROLLER` rather than > > > ARCH_STARFIVE? > > > I'm probably missing some obvious reason why not. > >=20 > > Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. >=20 > Aye, just the explicit dependency seems like it'd be less fragile and > more obvious in the future. Agreed. Be explicit so we don't have to hunt down select dependencies.