From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42063C3ABC0 for ; Thu, 8 May 2025 07:37:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7FFA6B0085; Thu, 8 May 2025 03:37:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B09126B0088; Thu, 8 May 2025 03:37:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 982A46B0089; Thu, 8 May 2025 03:37:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 772E56B0085 for ; Thu, 8 May 2025 03:37:14 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 29C26BD75D for ; Thu, 8 May 2025 07:37:16 +0000 (UTC) X-FDA: 83418934872.19.38DEEE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id C177F1C0005 for ; Thu, 8 May 2025 07:37:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cVK01zAJ; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746689833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GezCcPBScg5KPaNeawmNmkgQU7p8LvvEy7wz0/a17Ms=; b=0p1try0KCojUkF6QVmU2oH6VFWj7F94E7aU2Jv9ZntFypjChtAIsxj2ARjsRT3M9XC1z+E wrNTrtogV9XyuqCWjrTmI3QfLxem8BrLp+tfAaV8S4tGti2GRV4Btar5MFmq9bsMoHihgZ Cr/qrhOUi1Vf7jnJC+xwtweacqx9gcY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cVK01zAJ; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746689833; a=rsa-sha256; cv=none; b=VyMKjnAEPj1FqEn13KSih2vGCFkX16dq8FwegG3KsDD1qlhv6YQD+CnaZZSHBtDui38XFE 9kufWe7j5bpTaX2cWLzBadC5IgOoUG5loF9zaDv9cimpleiB1CzGCLCJAYnltRDkYXuPSS oILH+2zkhH/k4yEmBvbVnQw4r7ckn6g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746689833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GezCcPBScg5KPaNeawmNmkgQU7p8LvvEy7wz0/a17Ms=; b=cVK01zAJfjLdYRf1/is1gxU9soOm/Atexv82p75hofihcr/Fk6pcC1glH52o566Q3PtqKN +8enKMGlY5zLTqUFj4/odqH7nwINV27uHD9L0HUgo7A7m7zm4fB/3RyFquafH2dA7CdGA/ Kz0ClooDNSuPwAGc/c8+VtqIzag+JMg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-mCZcPNfZM56g6F2gYwNxXQ-1; Thu, 08 May 2025 03:37:11 -0400 X-MC-Unique: mCZcPNfZM56g6F2gYwNxXQ-1 X-Mimecast-MFC-AGG-ID: mCZcPNfZM56g6F2gYwNxXQ_1746689831 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39d9243b1c2so246120f8f.2 for ; Thu, 08 May 2025 00:37:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746689830; x=1747294630; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GezCcPBScg5KPaNeawmNmkgQU7p8LvvEy7wz0/a17Ms=; b=g5cEKtJz0mMI62DN/jmB03W/gi0zgBJ/pqlb78JD3gYLXwNaniqPNfo/TreMTGYbTn PY6R2VHDXb6+bFI1BzEb15TSg74ayjEg90w+Vli9Uzgtqt09NwwKQ5F8q2TG/KfqY8EL N3PYeVjWySxd9R1fGZaEPdkNz2wvgytTVO3XKGAaV55d3yd0bl+GcrnZ7CEBKIgxxOrX PlpJPH6gunDaKd3HgVsa75fIfL6S9xiVZiIWavTyElQYSwDLMO+zA2SP2MDrfVuI/B5x Ke/9/Dfc5C5A/IniX9Al6Zy20xe3zKuT2BVXdE9S582VDoeru2W03sRTVhz/7da9Sn59 9zaA== X-Forwarded-Encrypted: i=1; AJvYcCW1MSzaGOXX8g/9ZaOnoJK4Y8Og9vkQhm+f1Vy2bNXJ3ySKi4Inq8B/I+f1483NWoiWmqxjL3oExA==@kvack.org X-Gm-Message-State: AOJu0YyGQvm0CNk3rT7HFA0UQxmVzl4xtHo1RtdA0E/X8ID8yjs1vz5Y ctLL6NLJiljEVtEuMkhAaHsTvK7az6fCDGz58t9dIfJ/J4QN8ZhskRZSv7YSMK5c8E3aRsMoqiI dMWcrAJVooNCBSqWBdDm6tfoNEhNdiYG4sUzq/3rQuX0dA/8e X-Gm-Gg: ASbGncuM2pk10/448dmokpYi03rQORK+WsK5Oniz1JTAwhvim3yMdOwvMjYpEOJvtyM 10Pi5h+sGyv37zQ2Fwhc9Nv/tfTBUTEKd6wUaXjGSiyGdGyEiGhWjDrqOI7PBbi1cE0vZ7qC1k7 hkxRfkTsyT2SG0Q4KWM8ee6fZSZBPRwt7uD8Ny/mm+oihlmQFPPQN4Bf66+ODQKbp8Gu4qd+MAF e3ke2SZnYx2Rt4P4mMR9IxQJ8PfpaBtyj7dgfBsUoLmn/4w92BN2lqsP+MctlkvFk79vuwIL74D DDD7XhZTKOrTEBXYjLPsmULk5wm1cawJpyTmjriCWLPwtebsXxShFkahkABkEHojayT7cgzLPgA 6WwO7fBCcqM9kzZKf05LY5XFdj9yYkYzV3sDQs0s= X-Received: by 2002:a5d:64e8:0:b0:3a0:809f:1c95 with SMTP id ffacd0b85a97d-3a0b4a6868bmr5069691f8f.53.1746689830661; Thu, 08 May 2025 00:37:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfpkNjKotxnV6NRi8jDftDtvx5wtIETdy3ab7NqN203hY3QPoExdZ1fDzVF1kh2LAVn+THHA== X-Received: by 2002:a5d:64e8:0:b0:3a0:809f:1c95 with SMTP id ffacd0b85a97d-3a0b4a6868bmr5069666f8f.53.1746689830299; Thu, 08 May 2025 00:37:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c? (p200300d82f3e590027aa5f4ab65c3d3c.dip0.t-ipconnect.de. [2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae3ccdsm19537950f8f.38.2025.05.08.00.37.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 00:37:09 -0700 (PDT) Message-ID: <0fd1bf14-a664-49c0-a239-fdc45b8e3a39@redhat.com> Date: Thu, 8 May 2025 09:37:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: convert do_set_pmd() to take a folio To: Baolin Wang , Matthew Wilcox Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8e33c8a65b46170dfd8ba6715d2115856a55b8f6.1746609191.git.baolin.wang@linux.alibaba.com> <88060373-d0b8-404a-b53b-9b5a54f5ba6f@linux.alibaba.com> <569e592c-1c30-4c03-bcee-c1670ac4e159@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <569e592c-1c30-4c03-bcee-c1670ac4e159@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F6wTUshGbJme1UFMqYlM0Hgwggf29uUwx9cnnaBtPVg_1746689831 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: eepuasn63qkkok8exhtgy149kbpqu4k5 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C177F1C0005 X-Rspam-User: X-HE-Tag: 1746689833-969282 X-HE-Meta: U2FsdGVkX1++Q23xFDtgDkjBo8Dgt8t9pNey9FxyLdZMH2CWOw+E8gDB5RVSiV7RMY6Y8AZGu7IhVcXL747B1Y6COnnX1CQGKkkJTHgZXwY9IkFicEc7PBy4GO6d6cXUilDp99KoopeAM2T1Djqsrcpq4F+R8loQckkpmE8phxWPLJkcJrIeEQXbJ3x8hoYPHmq/hoNLlqiAVC+CwI+4i35xkUd1R5+rAlKD2U6xT1NAZn+K2k7O+vJMPYaFB7yECbqEXWG88Y0Bmpp+Il3Dgc5eqSk+nr0ijGKzS4i8k0qriy7yHkCzZq54ToDZGKE6VeTc3gqimnIHFpQRKlYCAW8SJavbQ0Nn9ER3B7LqdZ994kgP6FDzPwGxjEQfsW1fpMAM6kwo1OjNz4HvS/Nu3TfhLsCf9hceZDtqBa+crGNjpvdsH++J9xvCVLsYoO0Gio34fjTfBQkSjIP0w/na8t9swODzxoiD+AIGVebohb34JCF2/k8ACtJLDf39L2G/9XiksMon27mpMFftc6Q4jnxJ9Ikysia4CeStO+D3f4/xxArPLdrSCBc3+xeAatG409bztimvF9xMXkYWbhmpoZqJ9LaLFzxWjlJ1H3RFrxCZd0QMaUFW0MUrb/b9t51HeSZ4eER0VN6ve2giXZz4K8MblVBjSiAYCKsOz2yrT51zB16wfoWSuokGFnKqwAQfH0bSSQjpKUtA5K18xACyCRyS+jVz9Pz+QkZzbsZlQrq/ax5LCgZAp3iV6LqFu0FQFF1I7DZvv9dxwNnV0Het7zWzu3SesFpuaWFBcHv5fv4AArI0JjeXfxE3UMyZZ9vA+XhLHtOnOa8MJDuuyxI2cVZB7Dg46l+Wj+/0dwSamXQS0HIG/45D3STxTVrew+/2WhtBGWLVtGQhQvV1LIjY9Qmw1J/N8583sRUuhqUOnJ3tXREo+jA4aZCCGNzuy0EdU76T2N+HAAGJg54BCHP CsBmhUtR 5OQlFJANSs4p81uP/25r6CVjR71H6rAxqgei9M50vvmKqxD7rmZTn7Y1Ht82i+q0GxxJZvHnSuiXEeWxdea6qREAfGSwwjOzWsRfIORHFWv+EkLVg7u23oAQwCNKjIbyD2cgMPpg5QkPkZe8CLmsQhV/bXNHtxw1SORse3+u3W8m6Jf3eWV3ydHXXBpUAXDEjuRw54lKhwV90gml9RmKVprYFUYqcC8bXzgt5QAl9LJFoqMp9nLQhSLQaRvjn6JpDFS5mKknPQjxbmZapqjp8O/LoSsMM489swZ5GQC4UaHOnn5iXg1+lw35P/UnDyPunm+cucxoCd6IuUjASv0KFqZMDFoavNyUAYBAWHs/T/B8AJqCCnacFTCzr8xWivUIjf/4Mg/pEPAEb/3cM3YOjw+pf2zm4JPAnyAyl6D/kZ5rmuijqdXbUBf3l5lSnBdlo7ET5TPR4cn9GBi0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.25 04:23, Baolin Wang wrote: > > > On 2025/5/8 00:47, Matthew Wilcox wrote: >> On Wed, May 07, 2025 at 08:36:54PM +0800, Baolin Wang wrote: >>> On 2025/5/7 20:10, Matthew Wilcox wrote: >>>> Because I see nowhere in this patch that you initialise 'page'. >>> >>> Please look at the following code in do_set_pmd(), and the 'page' will be >>> initialized before using. >>> >>> if (thp_disabled_by_hw() || vma_thp_disabled(vma, vma->vm_flags)) >>> return ret; >>> >>> if (!thp_vma_suitable_order(vma, haddr, PMD_ORDER)) >>> return ret; >>> >>> if (folio_order(folio) != HPAGE_PMD_ORDER) >>> return ret; >>> page = &folio->page; >> >> Ah, fair, I missed that. >> >>>> And that's really the important part. You seem to be assuming that a >>>> folio will never be larger than PMD size, and I'm not comfortable with >>> >>> No, I have no this assumption. But do_set_pmd() is used to establish PMD >>> mappings for the PMD-sized folios, and we already have PMD-sized checks to >>> validate the folio size: >>> >>> if (!thp_vma_suitable_order(vma, haddr, PMD_ORDER)) >>> return ret; >>> >>> if (folio_order(folio) != HPAGE_PMD_ORDER) >>> return ret; >>> >>>> that assumption. It's a limitation I put in place a few years ago so we >>>> didn't have to find and fix all those assumptions immediately, but I >>>> imagine that some day we'll want to have larger folios. >>>> >>>> So unless you can derive _which_ page in the folio we want to map from >>> >>> IMO, for PMD mapping of a PMD-sized folio, we do not need to know _which_ >>> page in the folio we want to map, because we'll always map the entire >>> PMD-sized folio. >> >> There's a difference between "Assert that the folio is PMD sized" inside >> the function because we know there are still problems, and "Change the >> interface so we can't specify which page inside the folio is the one >> we're actually interested in". > > Fair enough. So how about adding a new 'folio' parameter to > do_set_pmd(), similar to the set_pte_range() function prototype? > > vm_fault_t do_set_pmd(struct vm_fault *vmf, struct folio *folio, struct > page *page) That's what I used for rmap functions. *Maybe* folio+idx is better: might avoid having to lookup the page in some cases (probably in the future). -- Cheers, David / dhildenb