From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C80E77198 for ; Mon, 6 Jan 2025 11:07:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E9BB6B0098; Mon, 6 Jan 2025 06:07:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09A2E6B0099; Mon, 6 Jan 2025 06:07:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E56FC6B009A; Mon, 6 Jan 2025 06:07:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C35EE6B0098 for ; Mon, 6 Jan 2025 06:07:20 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0465E814AD for ; Mon, 6 Jan 2025 11:07:19 +0000 (UTC) X-FDA: 82976750640.14.F91C64A Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf21.hostedemail.com (Postfix) with ESMTP id 5711B1C0012 for ; Mon, 6 Jan 2025 11:07:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QetQXncO; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=F0KsANVc; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf21.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736161636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZuivPjgy2oSe5FPIW3Y4JDpzikYhsAE0htx0bjkTnRI=; b=R44V4Gg995peIQlaspoiaIIam/yeqaKjKh03CQLS1qxukXMISjusGr0pT8pM9+JnOeHhw8 c3bgJkAYDITDxCLlFu30IIQE4oZSKz4qJSvJLbnCNkgtB8mq5Wd7G54n4NcLHfTWLKmv79 krpixSGlsucNrIgwyh/Iw1not+ujkYQ= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736161636; a=rsa-sha256; cv=pass; b=aItfmcDPhoT7ZBxwb23fpTcWzFauzUSFr7WUHIR9u0bn0HpYNLzJB6prmssokuBu9VpFj6 W5Dp1LDHs1XHf3cEBWT38bBFoB8+Gcmls0CKKeW4mkpOFRHr/HmcTBqQ29rLJ71J55yzPb zBh+hn7SOBuOgRD3L/rdahxvvcbu2uM= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QetQXncO; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=F0KsANVc; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf21.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5068u4VK011449; Mon, 6 Jan 2025 11:07:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=ZuivPjgy2oSe5FPIW3 Y4JDpzikYhsAE0htx0bjkTnRI=; b=QetQXncOf6Gfgvve1xyoUtuxF7JZWl6OC2 E/eDrf8eFU8KsVb4W0zLBv1wjeIUN/aLj66pqzjwnjosKRVimHuGESQuidUdZdtS kA1sLgy+wCtuj73APjtV6oxE8EbKCUiarQCN6pGG4iYHM4W/7l+kbJhE0FzdbTwg qxN1KdVSaUamIkjTn55kyNo5zqTXienaK2Yx57iGNTIsyo7mtwNKoHb1zSe9tAxO /nrZXsww4h6FDpM01LOLeRDKABMeySmU2Jg5U0MTCDONZaeMiva0gC+Q+5C87uey h54cqWCV7x5puEI7bPTSv4j3sU6fWIuGY8PiQb4QB4/YRyxV2eQQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43xuk02me0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 06 Jan 2025 11:07:07 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 506AKNKI005421; Mon, 6 Jan 2025 11:07:06 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2045.outbound.protection.outlook.com [104.47.58.45]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 43xue75m36-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 06 Jan 2025 11:07:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MVEJqmE9JjwgGsG+iS7s2xSiqRZVkAKugtK9gyJ+PTIZxjBY8NVH4wDOZPBbLBG4rm7C5WMChqD4KVGXbeAgGx1mKTgOdXmK1D7ChSb7zhRcq2yth/GmksQ3a66TrR9yVrBHVsUZwseLyf7NIg02VUIvGwBv/2x8vguS3migFEUSCn77OqlyYbzcQNvg+aYUvB3ve5Z3w+EoesWDkGh/AVEoJXKDImrcV7BTXTsz0JAFLrRGqyuFFGkDrOpYlWU8g6zclRmn+NOpIv2hL/ZsL4MHhGXtSV46TvWFU7tE1VOuMvux4EsFlv1axIQXDov1wQBYJjNO+XSMcFWXyKpsrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZuivPjgy2oSe5FPIW3Y4JDpzikYhsAE0htx0bjkTnRI=; b=fWVo/KpL4jaeOnN2Nk6oW2p+W3JUP1xsKYSlCugK0j3cN+LYPMJlSBO/QqeGG+RfkuwTSILNzFCvN4eeFwjsI4P47Fpm821HBlFMAg5MNKHBxzehU57cbGNhemkRO32QiNoRPXumzLQUMfOMCwcgbHXTYCWkWLU8vkm3Muj9QZiVZH+mzpa9pfH7rYtkdQ2ODiZCrgInZ4Z4m8MYfL5++QDyPXLtWCL4ov6dcY8y4lRp9+Wyff0p2mpzDbKgiyGITFz8NeaA5WbsLxqPUO7yC7B9Fg1L5cslq7BCw6vnUIhBTNMMpWSTQg7tVytRETfKJFTvaYgnhPyRzwpGAGZXaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZuivPjgy2oSe5FPIW3Y4JDpzikYhsAE0htx0bjkTnRI=; b=F0KsANVcw8HEzv7I5+Bxx4c4G+j1GIdGQ3jJFSx462FxDAnB3qC7NZFQ2Kepn7gt76G06MARouyJOPMKYibjeV7vw9zaYGIEf648Y5MXj8OWMoOEIkrNlzEbqOuUmnqNN6Cx+H0N0Fr/KiWvXE/WY98C3nbb1u4F/1PJ87s36WI= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by BL3PR10MB6161.namprd10.prod.outlook.com (2603:10b6:208:3bc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Mon, 6 Jan 2025 11:06:59 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8314.015; Mon, 6 Jan 2025 11:06:59 +0000 Date: Mon, 6 Jan 2025 11:06:56 +0000 From: Lorenzo Stoakes To: Alexander Shishkin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand Subject: Re: [PATCH v2] intel_th: avoid using deprecated page->mapping, index fields Message-ID: <0fcfc239-19c7-404f-bbc5-70a29ccf6ec0@lucifer.local> References: <20241203080001.12341-1-lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203080001.12341-1-lorenzo.stoakes@oracle.com> X-ClientProxiedBy: LO6P123CA0050.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::6) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|BL3PR10MB6161:EE_ X-MS-Office365-Filtering-Correlation-Id: 52236aef-2aeb-4ab7-1a28-08dd2e423da4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?v2YQbSRlwtVEMLWcDMVQpdxDmSGnlrfjDmkMzUwU8ko1Bd88C8P1Cd3+CFK7?= =?us-ascii?Q?2TF5Se1qF8d5Jpi6xZwY+jay4aPNK7JTveH0ehmHfbiFihXB15+Pojf0a0pi?= =?us-ascii?Q?yM6Y2EQTxke56tSWK/O1ptiWW/fvVBwLTCViKF7VXxA0ix1TI+1ycwr9p13M?= =?us-ascii?Q?q9C9RVRhGnCKSsp+Lrun/ACiCNR9O+z+7NKC+wGY/RVr1MEADLrruttkREpM?= =?us-ascii?Q?ATQbP3cZJS9zj/P7P5pD77eL8pa54Z4xQWxCgu0RigmBj+WSmgKzuKQf6tmx?= =?us-ascii?Q?8xEO2U36sJs/uJFLZeUzfNQ3EqW6uLq2NjNuDcN3O/s+03UBLq0zeGI+QqJJ?= =?us-ascii?Q?UaC4hxKyWCFAjtQZjxZBIMJI0ETGg3yTWQGwzgwDYMJAUDtC/M1+rCvFCkS9?= =?us-ascii?Q?rqggXVF2j2ZtnC0/Z4vFWkE5sg3M94eJq6wz55duoWeMePMlmyeJSyaDlEzv?= =?us-ascii?Q?146gaYe/GG5+lzWyH/gcCKrkY+kSFsK9YYHQMiSnvTQ4k5xVEuXyafR2YXO2?= =?us-ascii?Q?wAaThQqL7HL0tdp6IWb9NhGA3afTziKs5xvjUQyjutS0qvEw9PNliWXnGps2?= =?us-ascii?Q?w3uWUAn8Cs3tJ0uyziffoEhDHbHoLdfcuI4po1dyM94DyRMje8P5zjAygBN5?= =?us-ascii?Q?tupD6oRbnSW/hB0U6Bk+/Z1zIF2GNmgrTIVLyxYfoQBCdTes5f94dPXjePVt?= =?us-ascii?Q?ELiHIHvFet7+sYQeSkb/Nvc2ABuYyTRY8bjUnGRG9tspIEZ/PTKp7P4xCZ4O?= =?us-ascii?Q?ubyFfN6dwPsawtlT1dTIlDotOsu7P5H9GWu1QTAuffVNQUQL77ALLFped+H3?= =?us-ascii?Q?sy49o6OrjZ4BSFviyq8Qxw+EVd1iU4fPkOzu7c01McUBwv+dOhPAiuytpmCU?= =?us-ascii?Q?3WJHB3F4il4qxHWum1XaU4BIQyWVkG5hI52Ee6R62dUEidxNuahgZDDtte1f?= =?us-ascii?Q?yNNPRJOxN2qFV6yyyWM1lh49xCDTN+Uo6EZJt3jwv4U5C+xpjdRBnCpRgilr?= =?us-ascii?Q?vJ5AV6rpKT0dE2iqWzvNFdnOabnxAzsMnrYBW5aEfvqPPtfR5yvYZXb3Ro/L?= =?us-ascii?Q?tTOIOL3eQ4LzmK/OKnujqMg+9cTSIXWKBrfFStUfj9InuEqbGVmcAXLRVzT6?= =?us-ascii?Q?heAITmkjeoTHpxllCWl9/huaE8M6zS28Z6O/WOjGRyyuty04uIjm76lYHryl?= =?us-ascii?Q?RkJvIkAH+9HaZ83vnb7Wt2cDWs5od6AJNalxRTQGPDqGhyk72Um/0KdA3ZZ3?= =?us-ascii?Q?sxL6gAhlJ7cr3UqLYPrgp5RlCxnmwWOMJ86rPoClz5tIjIxfucOuNnViSL0W?= =?us-ascii?Q?BaP8SK16PauzgTe10ZE6JRYX2xKXUv3gGx55NSpfEjTguIqPe2jbNOrtpx6e?= =?us-ascii?Q?4+suOmHHnlakGBFWp+KB6+9O8GHW?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RYtSYjh681GzbMnw90de9Itjxra0bv4L+B6/RA3iCnfNOTmKBY/BCo8u6hrR?= =?us-ascii?Q?dZ78yY+lRloF/ZVHEBMQUGYYL/N04Ft+lZwiN8aMIw8k3L3ArXVStBGWNSVQ?= =?us-ascii?Q?tAJnkTD0Y4lqLa9QqUl2IeHTpEmlzCuVl6WwPUIeh66WkywXDr7U1D9kNCEl?= =?us-ascii?Q?jDHVamS/84/y2EZs+cZTK4ZMYjyXVOSmlpanG3bfQ+Tv8DI1OC5IikdKXCAf?= =?us-ascii?Q?kn9bfxg7cEZRc9Hy7/f0CmdaRjnnpsbGznXigYRhzyEoDrJnOZjl1VkKZ+ck?= =?us-ascii?Q?qsprdxqdfxqR2fNoNxIz/PKAKUfOcBbBaCdU7103ZN36/JXZe/szO2eDi3ou?= =?us-ascii?Q?+8jfVA2AsnK6eR3YASqc6dku5wGhvzeJsPPw2x7yuYBCvFTdgpwryYgsQMQE?= =?us-ascii?Q?/Yjk221M4scYKVPoWnuHgAQaDibdGzejHhh6K7s7TBzFq/U4r2rppIuEgXpN?= =?us-ascii?Q?ZK9yMZtGD3Fh4AOg0Wwb/79RoYljeDRz8iNL9mBPHBfL2FrY748FzFKWBIj7?= =?us-ascii?Q?w2Ch1KPYWJGmuplNgLjRF6QZeNwIoXSDuwjb6IMXBJJQsws7nYuas0tX/G2b?= =?us-ascii?Q?rXUJp+EkWbAOxhfwP095wW4leiMwg3HT5EhfQTZakrncbvzowWgdg2ZJjjHf?= =?us-ascii?Q?WfepnvZ9DJrtKOJLnS11SRPOFoMqOBeHk2bgZCFhnHWOfCau2gA8DPwg6EuH?= =?us-ascii?Q?gB87Wpkk5d5P+83ATWUsfhBhXNaTz4W+RQySorJIkjFyhFrK+D3JCF3kSmTy?= =?us-ascii?Q?G0xGAY0gvvuDPLK3FAPCNYnAstTY7KdjlorUld1w+DDP8uNIdNeMLMqSDTzN?= =?us-ascii?Q?0gK5nsvMcUcdDxBl07T/0uINGBVmJkKi6z222Wix0/o219w1DI6NXov/r7DO?= =?us-ascii?Q?9fU3SLmBkBB8uk5cXHlTuI1xFvAp4nD6NpTA0/sWV6KPvptFYLvYe1k4qI1Q?= =?us-ascii?Q?9G8K2vud6/JUB2g2BKaBENFeBibK1pWvUxvsYc/Qlf0oHk2LOEvy5qOUBHPs?= =?us-ascii?Q?R/RK4SrhJo23wbq/5mAWDjPuy8d3zUt7mbvzhdX1hCCeNFLPmknanOzUMHMI?= =?us-ascii?Q?8upwo6NurZglErLi6lo63owVMXwAN5SsByqWV3xxZweKNUmKhubaz0H7jcyB?= =?us-ascii?Q?2A0TnJ3IN7tJ6oK/7BKOTVXF9Vz7tgy5FSjm4gh8j67hYL3YSB2ICArNhdzM?= =?us-ascii?Q?6GlYfLOZs3Y/w40Vrfrjlr0Jp4Wf0K1/2JxPsYPMqrZQdOrhdA21LkA6X9Nk?= =?us-ascii?Q?rClrIqcz3x6BnYGGHkMxyqzpZXa05+YVh3RhYWu+1P0wxX2IXWFQL37QGzPC?= =?us-ascii?Q?4ACH9Ukjrbkypy6YiBVwoCtEeH6lkBpTEpp+TEx0qHgZuLIEXNG3MFUPvwAk?= =?us-ascii?Q?aV2D8NTZv+EbTuyIzAUpeP3satMDEqa86eXQiTpmsW6XPBE7tJj1UjyDrI5r?= =?us-ascii?Q?grqcXdeHTFya5PWTbxmFwBtXgco3j2pE9BeQDzqMmgII1Zvaem/L6T6qvCCI?= =?us-ascii?Q?XtInFtHuLqz73QcQo++i7NtCzN2xGFHrJUCAolpHh1TwdQU+YR07yBl0kwe6?= =?us-ascii?Q?k2k99TACXPVvx1y41Zho2crFclZ3I4FliyIQkbExT8ZDTFLbshgCUmi7XpwF?= =?us-ascii?Q?+g=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: K3BR12NoplBtx844CtBNPw5J7U07vsSqdmHzeM9VKFcQBIFuwUUKe0DVFnXvUo72lWkeYBGW/VooYLVMfHYZM3lptqRmO33lxsQIQGARrQbslo4prtcC56gyM3na2iyf5F8Yijc07ui7MiBOB5FCtqy94rY76g6FAYDIle/bOLqwfdUX+/SNTEjIdmacLQDu5Vwg0zLkG/sx9COm3m3EDWwx86Yi2uFFCxENsSpoW4kxCCMaprOfrUomZZNOJqFQeDUzfTg7o/XTUblvCR2S0BW+iySB+pK95fTz+kdRY+g2oeObAZLef9qgJQh9VcPmmA/K/Em4dzxJ1vvRkmUr5ehCXzqxv5YIXshPib9M5qEvfn3tLQ8yE612Qz3gfA9jfxLxO6tEC3w/ilfyR+2FTesuvJexzczbadNTopMJIl7hD5pm+GoiyNpPEb/jUPA57EpcccOM2dQjZrbJSpB8ni5i4jp85S/Zvf8so/kWPq9E9vbXR/w77315ga3YcFshRGEId9hjHgkhOOesH6FI5FM3cJox/7RTfc8oDF6veGe6FTm9EwpcnlNATOXhXN5+3Fj74KVTEVLrPYRl9IhNpEBxfNQ6ebByhPBMAJt7PXc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52236aef-2aeb-4ab7-1a28-08dd2e423da4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2025 11:06:59.6741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xArWO1PqHQflh79akNv1ktYujq2KmgYD0/V4/RvF7JG8KdraSM6wQ7/Rcsvtxmwp1A5g2YYv4VJEQYxLC/trfiRI+JjhSn8N8T2NlZzXcuA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6161 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-02_03,2025-01-06_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501060098 X-Proofpoint-ORIG-GUID: RoToDXTTkkldyUDKzabV6VHLTGkYxcoQ X-Proofpoint-GUID: RoToDXTTkkldyUDKzabV6VHLTGkYxcoQ X-Rspamd-Queue-Id: 5711B1C0012 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: drnehtao49o96w79hoftfmzd1h3ax8ht X-HE-Tag: 1736161632-280315 X-HE-Meta: U2FsdGVkX19Z1Hl8VOS0Xi/A2uLgE6LCH86JOgdUkSRZSWZpdPwbdJUkkVRowU+MS9cIW319zJJmoLyuGxJ7wrEhmzHDwh4ZrwYOfLelYZzJIwfwPcEnJhhEXR/C+FSZiUWkXWQ3UgPY+V0MtKWdXkKlNv4zxH7MCyEnEQbNr8N+LTSxoKlUJugKBx+z759OTrHyInLGOGh/zaYUlet+T6ySkZsYXQ74QcEjenbjVCrPFf/ewFyMrjSvABYV43PfNeJAxXwj4pg13aWTyRwdFsyAX41lccJ6T0VYQfuPUzWUA23KigDSojP9jfp+FBQAnPAU86lwuy4UG5ypBldkWaqtunMLwfQe5MdjJPaJwfuk4mtYJ/Mgac4Nd1Rft9WvzCgjq8kqv+alcdV3C7ifp3yJQ9k/62FxlCBprrGXrEoa8vKQQV/l3Zh85FMe9KJh543kvwn0swXDWcXIEPIxWtTtjLtmJV/HIvNTKcsE+fOdlZusUfnEeR7Y9LHCHEd0o3EIbreb16eJNAtFdXGAs4RCJmcr3KKlma4NxtQ17ZAxeKOg0pcwAOSAoizX6MnQAGuON+R8/ooWCMixiEK7rAaJN9YZSxQNJoDGj6pGL9P0WueWwaNO8yXow1dL6Cc5xjcmrExKsicny2Kw/dE3aQLCOmhLB3c4xnMWdraOjrYE5h/xS8NANvFKYeuFe0JELE87Y8KTzlaRoxLrYeLkFKgeoLjtlPRNy1Be/RB6hyOq9OOQiWu2l/gFRpmMYySTKLJN/q6CYJAbY0ltAAi5tW2wpMnKLsbpJd5mm/FP3xtPa+5HH8Z4CIUtP+uyS70YZaB6hlyQk9aUXVdYFHWrSgGU1CVlsgZiUgSpbTupdIZ2Z5PTRAfJBPZ1L1ckkJd4rROOA/SLaWjtJha6OL2xjy51jI+pKXNR/sS7HANmecqJTRf/wMKJKLli7JW+jKd3fV8h267LGJW/8Fq5DKZ RzHiAaPM PuiiSW0JXHRvOuqI3erq6DgT7B1KBHvf/uCI9JgDi1oUSkitHmAvmgutDFgHcMa7rd4PIAlnQbCV74n0J3UMKXC/NJW9T0gMo6+rxAQaRPTNVL8SwaNC0YnNKFErR2i85VDNzas5A7byBT1xiBkExK4v4wriwWUwe2WGYTtKKlSpH9ycVQMYM0OfaImLMKjCrW0SCOe7uJOhckj80IWWauf5U5AmgK3g6rflb01aDHsq1zFXyrb9Tujrjug+2g9rnVTEVuA1/WIQMdFN+nwRh0OMD3L+qdQBWbZBhdXQ1tJtjmh3+dujhO+qmha57d+czYJ75Af5vIUvZPyT45QbLCWZ4ev6XCJZ7nhaInulEBe6ZFZmfFLdgeNNckQK+fhBouyhmZJPwwCAHTXSZ5molH9WrwzXzBAL/2zApteHsNh8hw/hn7g4k0FSxkIrQzi+haI3UhhVaf/mjBrggH9wJUfZRPEzaZRJo+2pnzyLJB/o87fCJh7P5mf0DcqSwtlRAtPSNHs3abt9aP9zK55yiFGUWiJUdECZeQgsuj+D/tzSsXFIDM81CJPkL4+bj2yyqcf9pM4BSiiqW8phXAROwPKEMW4VodNx0gQ3nrKmf4dgeEYzClFwVjrstd/4T+UWSIlW/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alexander, Happy New Year! I realise it's been the holidays recently, but Wondering if you'd had a chance to look at this? Thanks, Lorenzo On Tue, Dec 03, 2024 at 08:00:01AM +0000, Lorenzo Stoakes wrote: > The struct page->mapping, index fields are deprecated and soon to be only > available as part of a folio. > > It is likely the intel_th code which sets page->mapping, index is was > implemented out of concern that some aspect of the page fault logic may > encounter unexpected problems should they not. > > However, the appropriate interface for inserting kernel-allocated memory is > vm_insert_page() in a VM_MIXEDMAP. By using the helper function > vmf_insert_mixed() we can do this with minimal churn in the existing fault > handler. > > By doing so, we bypass the remainder of the faulting logic. The pages are > still pinned so there is no possibility of anything unexpected being done > with the pages once established. > > It would also be reasonable to pre-map everything on fault, however to > minimise churn we retain the fault handler. > > We also eliminate all code which clears page->mapping on teardown as this > has now become unnecessary. > > The MSU code relies on faulting to function correctly, so is by definition > dependent on CONFIG_MMU. We avoid spurious reports about compilation > failure for unsupported platforms by making this requirement explicit in > Kconfig as part of this change too. > > Signed-off-by: Lorenzo Stoakes > --- > > v2: > * Make the MSU driver dependent on CONFIG_MMU to avoid spurious compilation > failure reports. > > v1: > https://lore.kernel.org/all/20241202122127.51313-1-lorenzo.stoakes@oracle.com/ > > drivers/hwtracing/intel_th/Kconfig | 1 + > drivers/hwtracing/intel_th/msu.c | 31 +++++++----------------------- > 2 files changed, 8 insertions(+), 24 deletions(-) > > diff --git a/drivers/hwtracing/intel_th/Kconfig b/drivers/hwtracing/intel_th/Kconfig > index 4b6359326ede..4f7d2b6d79e2 100644 > --- a/drivers/hwtracing/intel_th/Kconfig > +++ b/drivers/hwtracing/intel_th/Kconfig > @@ -60,6 +60,7 @@ config INTEL_TH_STH > > config INTEL_TH_MSU > tristate "Intel(R) Trace Hub Memory Storage Unit" > + depends on MMU > help > Memory Storage Unit (MSU) trace output device enables > storing STP traces to system memory. It supports single > diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c > index 66123d684ac9..93b65a9731d7 100644 > --- a/drivers/hwtracing/intel_th/msu.c > +++ b/drivers/hwtracing/intel_th/msu.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > > #ifdef CONFIG_X86 > #include > @@ -967,7 +968,6 @@ static void msc_buffer_contig_free(struct msc *msc) > for (off = 0; off < msc->nr_pages << PAGE_SHIFT; off += PAGE_SIZE) { > struct page *page = virt_to_page(msc->base + off); > > - page->mapping = NULL; > __free_page(page); > } > > @@ -1149,9 +1149,6 @@ static void __msc_buffer_win_free(struct msc *msc, struct msc_window *win) > int i; > > for_each_sg(win->sgt->sgl, sg, win->nr_segs, i) { > - struct page *page = msc_sg_page(sg); > - > - page->mapping = NULL; > dma_free_coherent(msc_dev(win->msc)->parent->parent, PAGE_SIZE, > sg_virt(sg), sg_dma_address(sg)); > } > @@ -1592,22 +1589,10 @@ static void msc_mmap_close(struct vm_area_struct *vma) > { > struct msc_iter *iter = vma->vm_file->private_data; > struct msc *msc = iter->msc; > - unsigned long pg; > > if (!atomic_dec_and_mutex_lock(&msc->mmap_count, &msc->buf_mutex)) > return; > > - /* drop page _refcounts */ > - for (pg = 0; pg < msc->nr_pages; pg++) { > - struct page *page = msc_buffer_get_page(msc, pg); > - > - if (WARN_ON_ONCE(!page)) > - continue; > - > - if (page->mapping) > - page->mapping = NULL; > - } > - > /* last mapping -- drop user_count */ > atomic_dec(&msc->user_count); > mutex_unlock(&msc->buf_mutex); > @@ -1617,16 +1602,14 @@ static vm_fault_t msc_mmap_fault(struct vm_fault *vmf) > { > struct msc_iter *iter = vmf->vma->vm_file->private_data; > struct msc *msc = iter->msc; > + struct page *page; > > - vmf->page = msc_buffer_get_page(msc, vmf->pgoff); > - if (!vmf->page) > + page = msc_buffer_get_page(msc, vmf->pgoff); > + if (!page) > return VM_FAULT_SIGBUS; > > - get_page(vmf->page); > - vmf->page->mapping = vmf->vma->vm_file->f_mapping; > - vmf->page->index = vmf->pgoff; > - > - return 0; > + get_page(page); > + return vmf_insert_mixed(vmf->vma, vmf->address, page_to_pfn_t(page)); > } > > static const struct vm_operations_struct msc_mmap_ops = { > @@ -1667,7 +1650,7 @@ static int intel_th_msc_mmap(struct file *file, struct vm_area_struct *vma) > atomic_dec(&msc->user_count); > > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > - vm_flags_set(vma, VM_DONTEXPAND | VM_DONTCOPY); > + vm_flags_set(vma, VM_DONTEXPAND | VM_DONTCOPY | VM_MIXEDMAP); > vma->vm_ops = &msc_mmap_ops; > return ret; > } > -- > 2.47.1