From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@kernel.org>, Vlastimil Babka <vbabka@suse.cz>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mike.kravetz@oracle.com
Subject: Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable()
Date: Tue, 11 Jul 2017 16:49:03 +0530 [thread overview]
Message-ID: <0fbc7a4a-9e3f-fb64-65cd-3259335bd07e@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170711072223.GH24852@dhcp22.suse.cz>
On 07/11/2017 12:52 PM, Michal Hocko wrote:
> On Tue 11-07-17 09:16:12, Michal Hocko wrote:
>> On Tue 11-07-17 08:56:04, Vlastimil Babka wrote:
> [...]
>>> It doesn't explain why it's redundant, indeed. Unfortunately, the commit
>>> f106af4e90ea ("fix checks for expand-in-place mremap") which added this,
>>> also doesn't explain why it's needed.
>>
>> Because it doesn't do anything AFAICS.
>
> Well, it does actually. I have missed security_mmap_addr hook.
But we any way call get_unmapped_area() down the line in the function,
it should be covered then. Does the proposed change look good and be
considered, or any changes required or can be dropped ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-11 11:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 11:10 Anshuman Khandual
2017-07-10 13:49 ` Michal Hocko
2017-07-11 4:28 ` Anshuman Khandual
2017-07-11 6:03 ` Michal Hocko
2017-07-11 6:26 ` Vlastimil Babka
2017-07-11 6:50 ` Michal Hocko
2017-07-11 6:56 ` Vlastimil Babka
2017-07-11 7:16 ` Michal Hocko
2017-07-11 7:22 ` Michal Hocko
2017-07-11 11:19 ` Anshuman Khandual [this message]
2017-07-11 11:11 ` Anshuman Khandual
2017-07-11 11:08 ` Anshuman Khandual
2017-07-11 11:22 ` Michal Hocko
2017-07-19 6:49 ` Anshuman Khandual
2017-07-11 11:06 ` Anshuman Khandual
2017-07-11 9:44 ` Anshuman Khandual
2017-07-11 4:29 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fbc7a4a-9e3f-fb64-65cd-3259335bd07e@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox