From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9497C19F32 for ; Sun, 2 Mar 2025 09:13:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED22C6B0082; Sun, 2 Mar 2025 04:13:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E816D6B0083; Sun, 2 Mar 2025 04:13:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D22306B0085; Sun, 2 Mar 2025 04:13:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ABDBE6B0082 for ; Sun, 2 Mar 2025 04:13:16 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2BCA71CD0D0 for ; Sun, 2 Mar 2025 09:13:16 +0000 (UTC) X-FDA: 83176047192.12.92420EE Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf08.hostedemail.com (Postfix) with ESMTP id 567F7160008 for ; Sun, 2 Mar 2025 09:13:12 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=AsDOEXfX; spf=pass (imf08.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740906794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HzSBbXwNMGob2tgfp9EcarAihO9UwDHktg0BwdEeoQ4=; b=bDeDa2aHw9ulKclrUOxccKdBf2Kf0os+ZeA3ur4qhVE/LDWDtBwMwDPvG8XO6Ke6WOQL4s qiArC9mEBPgK6U6KTo2U4fxrrbzSGV4E0O9HYd5xtT0F33cD8NnJwMwdE69OIa9Ecwp9rp v3Pqq+VSUJjgUvbKtYXpdhm2RJRJZFM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=AsDOEXfX; spf=pass (imf08.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740906794; a=rsa-sha256; cv=none; b=gB61scu7O5RknDQ7/W+L2qB/y78XBVP3KHV+6CcY8cB8rPOrGvI/ZKwOuHv6raCYeSBCqH pyUXYchuPnVa7fn/NqtrWfedo6Y00bGehjWmWzlwMVzqDq5N5DaQMQoMIhOmsFhjvGZAWs hQ09w8ewL0Qe10WEeOkUYGxchS8l9Go= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1740906790; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=HzSBbXwNMGob2tgfp9EcarAihO9UwDHktg0BwdEeoQ4=; b=AsDOEXfXvnlFpg2g+u/hQBujrM5xS8IqAo+wAoxbrntWzMtKcAusM7O8xyq7Q8ZdpbblSnfrdta62MpiNICnChTgO1DjaRXjFCNNbuy5bqUPvEV4z//ElzSzuGJbU52QnD8VJOfzxRaMNrAgSZAxpm01W/4MVYPXgAfC30mANBA= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WQUlzlk_1740906787 cluster:ay36) by smtp.aliyun-inc.com; Sun, 02 Mar 2025 17:13:08 +0800 Message-ID: <0fb57eb8-ae5b-4909-9afb-2104766e59e8@linux.alibaba.com> Date: Sun, 2 Mar 2025 17:13:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] x86/mce: dump error msg from severities To: Borislav Petkov , "Luck, Tony" Cc: nao.horiguchi@gmail.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linmiaohe@huawei.com, akpm@linux-foundation.org, peterz@infradead.org, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> <20250217063335.22257-3-xueshuai@linux.alibaba.com> <20250228123724.GDZ8GuBOuDy5xeHvjc@fat_crate.local> <20250301111022.GAZ8LrHkal1bR4G1QR@fat_crate.local> <20250301184724.GGZ8NWPI2Ys_BX-w2F@fat_crate.local> <7eddced6-bf45-44c8-abbf-7d0d541511ab@linux.alibaba.com> <20250302073711.GBZ8QKp1QstGaVGqBR@fat_crate.local> From: Shuai Xue In-Reply-To: <20250302073711.GBZ8QKp1QstGaVGqBR@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 567F7160008 X-Stat-Signature: 6duakmg6y68fzkuzg61idzwr3k7d5mud X-HE-Tag: 1740906792-131687 X-HE-Meta: U2FsdGVkX1+n+Ok42O7URq5K7xE7akrw4eNgZ3XUcOO46ZEvpg/RzKD6MFVlzgDzBAheRjYkhBbTDua+0K09mpbG/CWJJzRD16J0xTJO+w+me6xIDQX1QtQtwG07JtBQjOK9DKDeIe8yzA/XY4iM8OnOMkG419W6cZaz69LRYRx9hH3NF2TsjiLZ9hbEMx7Xf9Nxh3vraa/oju8O/uh1pW2WjbJlw+fS4YxNM3mp+jwNZ73HIa12/3Z4t3Yy2jzqtLiqQzMHaoeRvBkGmT8+f/XIbcbVXjT7Qkh22jZQw/2bukDaN4fwnrjBGQ6bag+uTag7T+OqspkrixtEHahux4nAEyfhi8UA7h1t5ySrL/8bn4DLgJqKwUfYKBj7/UeZGUpA5y+SwnIw4NEKK3oglwuF2+HcIq4wi/yYGQHqYKba/VfghWW3pfuDcMOTk7iahVZ9AejE9vfzB5/x9odQn85J9RMMAOEFX1gZ6DhTJihl1D+GEnzaY5hkdOAuaY7RfTYB8uK7f6Lc3ZPKEqnGNkHTmbYxobDhrdH/AO3AGU35mp1WYo1fm4J+xyW6GhD0+FETi8I3RZiEoCxWF7fylyHs7NGtpvkHRc3W/tB5n2iyc//NxBKyZ0UZ0J3/2VwcLO8My62RcQ+fcI9TFBqxocVG6mUTLu+8HpmX0PdO7x0Ps8YbtuPX+3d0NrR4K6d/4tcopdh1KAjKkIjoxl8Zl5YdKwLvov6gkgFCg9JQscHtfPcHXeDHsjyAHSCpCZ73+yWTvHhefemNw8oDPCNeHfRD7T4i2hJFyOiL6Zw+pkI7ZEcON4cjz+NZ0a1vt70VfDlR2lBGZ+hT5buawdk2mfuXIPkXzvD9l+y43BuNWYWWGqgl4A7llnup0IlR1eleLHHShDwpSgTaugToOCnMGG8MlSyBsb5SxUTut+rZir6pTmRqDu9gwrvUXq0/+R2jzY0IYRfOiLos7jkvobK Assa/TCQ fVGPfvxYbz7lgXZzS9XRFcH/aCl/OgQptacHQ46BorElTiQg0HumCfZgVdi5Kr02Yw7qJIMHNPSQQcBOhyz4Qqu2lbyFHmT2Md6tMXE2stJL7EwWEgJ1UFhYCxgqjBeiJ+PZtDgRbXBZ7fmxnElJ4pnQiWCQm/R6untv1Ah00rffaLbtnYveamFxN238PVFutJULNlFlt2trL3fcs1FHQKxtCIusfWAqlkC0KkZDVUmHg+fTBn7Vne6ZWOx690kF4jLKL4SheUPGfxFci4RAmOlthgFgvb9Z/iwyVGOXdMiK6Cjo+TTwbaLBbwYeZNiMwCxkE5wNP45NZIIQoxC8VBQLTruezsjSMv+G/D8TPFfUDo0A9aqacpStTrt272UJ9UVqui29pRV6+6Eo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000103, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/3/2 15:37, Borislav Petkov 写道: > On Sun, Mar 02, 2025 at 03:14:52PM +0800, Shuai Xue wrote: >>>> "mce: Uncorrected hardware memory error in user-access at 3b116c400" >> >> It is the current message in kill_me_maybe(), not added by me. > > Doesn't change the fact that it is not really helpful when it comes to logging > all errors properly. > > [ Properly means using a structured log format with the tracepoint and not > dumping it into dmesg. ] > > And figuring out what hw is failing so that it can be replaced. No one has > come with a real need for making it better, more useful. > > You're coming with what I think is such a need and I'm trying to explain to > you what needs to be done. But you want to feed your AI with dmesg and solve > it this way. > > If you wanna do it right, we can talk. Otherwise, have fun. I see. So I am just curious why we define `msg` in `severities`? I perfer to use structured log format with the tracepoint, and we do use it in production, but it lacks of process context. AMD folks add error message for panic errors[1] to help debugging in which the EDAC driver is not able to decode. For non-fatal errors, is it reasonable to assume that all users are using tracepoint-based tools like Rasdaemon? [1]https://lore.kernel.org/all/20220405183212.354606-1-carlos.bilbao@amd.com/ > >> 3. We need to identify and implement potential improvements. >> >> "mce: Uncorrected hardware memory error in user-access at 3b116c400" >> >> is *nothing* but >> >> "mce: Action required: data load in error recoverable area of kernel" >> >> helps. > > I don't think you've read what I wrote but that's ok. If you think it helps, > you can keep it in your kernels. > Fine, I could drop patch 1 and 2 in next version. Thanks. Shuai