From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5532BC02183 for ; Fri, 17 Jan 2025 22:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D43BE6B007B; Fri, 17 Jan 2025 17:13:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF43B6B0082; Fri, 17 Jan 2025 17:13:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE3786B0083; Fri, 17 Jan 2025 17:13:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A40336B007B for ; Fri, 17 Jan 2025 17:13:27 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 25FE51607EA for ; Fri, 17 Jan 2025 22:13:27 +0000 (UTC) X-FDA: 83018346054.12.0E1251E Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf16.hostedemail.com (Postfix) with ESMTP id 77902180009 for ; Fri, 17 Jan 2025 22:13:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=PQtU3Ypo; spf=pass (imf16.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737152005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=73ciZhaoGWRkvgB3C7s8OSDFUz8GhF8kepDOGPYDqFw=; b=h4as9785KdsuBxDBdPtPv4tguy12YVoWtC9npizI7yzONCncBdsKRpRyGofujlimzkRtE0 JsqoE6PmVRfiwCL99vWKvFrReiEjutuPu5UUf6zwwOerynGFqHuAj5e0ywd0M2gf8GGwT7 Uxx32TDYiwSn8v+jWwwB/5l9BNwpU3w= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=PQtU3Ypo; spf=pass (imf16.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737152005; a=rsa-sha256; cv=none; b=nyAvgJQArW5Lg5xlQVQl6SjsOdMpGZfBv+BUF9AtY0xUNXh3TDRnxXylMbIzMmHhgj1Tg4 t6eL5EJ4o2FauAzk669OGw5N0rpVQlBSsAi4ojznZB9FD7VlyzzXj4hAeC4QlRPKEzw5Ne t3gj8TFVl0yFgPceDqJsSKBo5bqDRtE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1737152004; bh=YRyanB7QhdfUr5PX2SBAZeyPMl8/gDbJl0cnFjA4gRA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PQtU3YpoDSNywen7+g81DQfv/Hc2sQ2zaxW8QEacR8+gvae+Exe92FIWWF2TYiu2W yCV/2a6Wp4ZkFCzxEneNKnrcrLSUH2NXTp3/BnnqjQOyz6vMq8mJapLSPDwJCVwAos irBVnK2evX5tIglEWmM+jzvt4RnXg/PTOd/MnN34= Received: by gentwo.org (Postfix, from userid 1003) id 2AAF6401E4; Fri, 17 Jan 2025 14:13:24 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 28CB3401C8; Fri, 17 Jan 2025 14:13:24 -0800 (PST) Date: Fri, 17 Jan 2025 14:13:24 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Kevin Brodsky cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH] mm/slab: simplify SLAB_* flag handling In-Reply-To: <20250117113226.3484784-1-kevin.brodsky@arm.com> Message-ID: <0fa27da8-d523-77f7-0473-bb317ec9d83e@gentwo.org> References: <20250117113226.3484784-1-kevin.brodsky@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 77902180009 X-Stat-Signature: wwwz789kq4bcik935p1zfu7x1yem1qdf X-Rspam-User: X-HE-Tag: 1737152005-884525 X-HE-Meta: U2FsdGVkX1+g3X3wteU1RqY2M14A1re/oFi2herAwGQJLrjQHm+2rLwPvGxsf76wG95+WX1LL9kCu34rmeDH2cxXzz2vbVn8deSUkeGzGiMjvsi846DXYd6DvPj2z/JpyERarOa+BpFGfUD6ypJuoR16InBZxhyAmlftRkadJbhoyx238Ze96m9EzA0n1dXlRehBoJroxyKJiS55cMavF0uBbDls4KmSujbdbq/8yxvlH7bDyUfK1GuV32iFZ+fpuj9k0cTlRVJ1rqpKMic/R1rD1LAZ3i63CpwolvHLjNv/ps5hACSchkqGYmo8aCoTOZYQLfGjuwkF5M6kGsGJ2rHnZ+mddhau2KG1YWAuJC+mSX5X68+S/2Ez5WPBPwG4ZYk8FPT1aoEJLahJQbgJcXaJgPbTUaLIG1VkuK4qqAV/wiioiTFpCjhtObS+VC2B6C0nBV12W5KWsPbv9XdDrd3jTiNJdCqfEyt2hzx3XhfffLTsxBqXLpguXPfztEviqUIUrZsjAJrLtwAuvCzB6OEUHUqPNv4fw/pxGH4nXN1mEDy0JF97IGaNsquAAvCjITvh0X/cd03OTY2k0rKPb9cFppP4jyM2SOG4wabfBsREdc3+PEPJ4LjKbyOcauPIDK5bvi7Dy6SXVXQdEc7mN4cBhEE/0zhWe7vXx+QolmavqPG88vlZYkH5PsEJ6MEgR2faF3nT2ie7r0YNp0NFiqQsa9dPSAd7ukyJfmvoq/nFHD0Uiyz2/Tf8Rts3/aW4uTboEMpGN1kQJbiPl9reYb6wFw5fW/Ohd6mWpuyT8E3tYZrWjRIIyAZk6o2OEC8n9IPkrss4TVKI9jF+z25lEgs3atlZibAumxuH74m4rt8hFn497NDkdKdTewtlPLKfl7+xDSZ2OmQsmy4NkF3170ugcIfR7gyACYAcxRP0behr3lwpzNoeD+8ucZjUlQp5o3hdqe+bNUcIIuEP+9M Tfqg0NMe ZgqH9TfZkIde/AOUE1l6i18Lw10HU0E90CNh/ryT9YNSdLOHdMeBgHa+K+OnvYNkwDBywNbyrolyYbWpRjjESyhz3p1S2I88m9BK6FaBdnjf+YHEuzcZaDNHCUvaWSEopk4nvIlgk+m9ok4dYU/bkcxnHk5/svVdVjJ7idapkifv16BrVk6DAp9moITQjkyqQk6O2DlamXiwXnPrR77f/BDHoUGlK/lztpTFPA1gbrwyXFsdw8UXYV1XensanmU1kK73m05zE9WiZ9hk7rBi/84qywSglLq8WMzYlArl4GDkUIZaf2BRLS+Ehe2p4bjzniMOpdWCRVQpT0UehbU67NPoDQzVQSF71sdpJPMVH2zRwVd/qVlYNyhZtl0FoqMs83wGe/bxoPP5QbWE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 17 Jan 2025, Kevin Brodsky wrote: > index a29457bef626..3b07cdaac3ae 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -305,18 +305,6 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > goto out_unlock; > } > > - /* Refuse requests with allocator specific flags */ > - if (flags & ~SLAB_FLAGS_PERMITTED) { > - err = -EINVAL; > - goto out_unlock; > - } I think we should keep checking for invalid flags. - > - /* > - * Some allocators will constraint the set of valid flags to a subset > - * of all flags. We expect them to define CACHE_CREATE_MASK in this > - * case, and we'll just provide them with a sanitized version of the > - * passed flags. > - */ > flags &= CACHE_CREATE_MASK; This would silently clear some flags instead of creating an error.