From: David Laight <David.Laight@ACULAB.COM>
To: 'Kirill Tkhai' <ktkhai@virtuozzo.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
"mhocko@suse.com" <mhocko@suse.com>,
"penguin-kernel@I-love.SAKURA.ne.jp"
<penguin-kernel@I-love.SAKURA.ne.jp>,
"shakeelb@google.com" <shakeelb@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mm: Cleanup in do_shrink_slab()
Date: Thu, 19 Jul 2018 16:21:32 +0000 [thread overview]
Message-ID: <0f98d9b38be1466b8608d5c071aa52ed@AcuMS.aculab.com> (raw)
In-Reply-To: <153201627722.12295.11034132843390627757.stgit@localhost.localdomain>
From: Kirill Tkhai
> Sent: 19 July 2018 17:05
>
> Group long variables together to minimize number of occupied lines
> and place all definitions in back Christmas tree order.
Grouping together unrelated variables doesn't really make the code
any more readable.
IMHO One variable per line is usually best.
> Also, simplify expression around batch_size: use all power of C language!
foo = bar ? : baz;
Is not part of C, it is a gcc extension.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2018-07-19 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 16:04 Kirill Tkhai
2018-07-19 16:11 ` Shakeel Butt
2018-07-19 16:21 ` David Laight [this message]
2018-07-19 16:27 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f98d9b38be1466b8608d5c071aa52ed@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox