From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9799C00A8F for ; Tue, 24 Oct 2023 01:33:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F6286B0167; Mon, 23 Oct 2023 21:33:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1803D6B0168; Mon, 23 Oct 2023 21:33:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 046996B0169; Mon, 23 Oct 2023 21:33:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E5D9B6B0167 for ; Mon, 23 Oct 2023 21:33:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B199A1205FC for ; Tue, 24 Oct 2023 01:33:48 +0000 (UTC) X-FDA: 81378633336.16.BA6D6AE Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf21.hostedemail.com (Postfix) with ESMTP id A53991C000D for ; Tue, 24 Oct 2023 01:33:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698111227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rSy1rXw2YapZutL8sUwTaEc0fT3AUEGjaMFHESFVt18=; b=E8nuT2M8X1sym8yy56k1Zs2CUjyd0i7amHHkpeeB/htYG4V+4m+7SE816PIYnGrVuEk0Ln FRn7nBVlQf+ZdyU4fsuaE/51wxYi87fGRhetbsP/GNi0RTNVi0zNmtP/I+9D6H05XRgLo3 WYeChW53tg1KW4y5ZSbgj/GUt7FVSsg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698111227; a=rsa-sha256; cv=none; b=xdorrVZVN0Pm/mytUOAhEqyu+rbWBPBKnAJ/U6Q22d21CcksSxvfaG6VD5bNb6SM+icUR8 2jV2C4MVTZTf8HNgIA1HiPDAg8clZ16S5huW/VS77T4x88AaGU2yDtrPHXImKZft7v+vAk GNCocucuf0+CsqGhbO7nxCt8OmClGMA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm500009.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SDvcL0h62zNnv2; Tue, 24 Oct 2023 09:29:38 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemm500009.china.huawei.com (7.185.36.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 24 Oct 2023 09:33:39 +0800 Subject: Re: [PATCH -next] mm/kmemleak: move the initialisation of object to __link_object To: Andrew Morton References: <20231023025125.90972-1-liushixin2@huawei.com> <20231023111624.15ea508ed8aba2dee69035c2@linux-foundation.org> CC: Catalin Marinas , Patrick Wang , Kefeng Wang , , From: Liu Shixin Message-ID: <0f977cdb-039d-789b-802f-02746f5ad8ea@huawei.com> Date: Tue, 24 Oct 2023 09:33:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20231023111624.15ea508ed8aba2dee69035c2@linux-foundation.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500009.china.huawei.com (7.185.36.225) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: A53991C000D X-Rspam-User: X-Stat-Signature: wrn1j69ghjybbc5qoxtnxjc4epemi1e4 X-Rspamd-Server: rspam03 X-HE-Tag: 1698111225-653179 X-HE-Meta: U2FsdGVkX18uo8A4X7kZ0+lA15vNJkx8cCLj/VPrELPb6YB6/V9rEWPf/GlKu5tLrF4SbY1f4fvSILHT3NxOY+dfJXDkcM8ySxX5FVrouhYOx92anSmXp8AzWdWdfVMFagOX7ICH2lceTXqpEwGTSQCom5GIiAt306xTGpfbqYePXMCjq/0norxZ5RLDEOY+lJ+DPSAlUB23oxYEt1URnEUUC6Uhny8AY68/mArbZTtsAAKJ64digxZ68ihF3GKLWDPs8VAtXhu2ZGgELlruoq5SymPxUM/OfcC/CI9Ce7vQfmzM8qqpkqafU8owWqfjI5FNAVsVM+0S5PFjwA1O9xyQnfbuVWlXW2R8HOgjUylHzSNzwGzyGlkz6iTmPm35YOr3nSamouC5+X6FSAlOelQHpCggvuFn2ZwLRwfYmuPBmJsWk7nWNqsPB6GD1dBLqgfrPN4gBVrZks1xi1C73xdLB3FA6DaPNbqPOy5hPZWy6hntlNcZTz164jhOt2lj+Mo5clUA1B2IEujQ3y3udZyx+VigUNOo8SKuC9+6v2alPpLSlZnJDaLg+anseoA/UMy/Dw1KJCfSkgNIddIe0eePMdJkI6ZFfEshX0+z7ynJonsiN6t6mssE+WgeaWNeo1Kec34pJPWPXT2qszX1PbzkNuoNhilnZCRA8MCF+iK3Kxk1ZlxKA3asVGcaK1Ukghm7E/upNlV4FbKx4GXMzSvZhZBWPFS1fSqy37VkdUTwgqUtBLtgCxRQ2NU4UVG+IE2e598HrJFODkROq0uw3pwctiFfihBf+IZnTmiWgPTT1vGgGXjg0YW9oDw2oGjZ10AXz1GsZx9HehSqFF0K76ewDunU8Z0IBDwJUAbN79vqOl/t8nl07PrXW2QmsdQgVmH7AvXgGMhDFL4mOVtZi46ErQg+jJSfhVfd+KC7XBV68tsyBKlWDXZnbJtz9dh4E5ozBmcSqOXfantTPO/ jW4wE0UZ 8ORQmOm75DryZRDcTFetM5CkJDlgavxy9K+1ZKqRX8vpis25p7/68QoqbSEwgta6t+vPe4U7jYe5UhIzG/2FZbg3vZEATXpY5i5ypSdypDnxZ4kwR/Dorze1WHI4J5YRL5whYc717q9vo3Jhgosp8acHjSq9QsfaOlZErpv3wyr8GsR8VkYp3MpDYC+GcqYGvFJQgn7wFcQu26loh/m3V/HVWyTJb6IhmHkkPM+SoYAGMBDyYJEd92AxwLM+LGcom6uAFD4kTe915Qjw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/10/24 2:16, Andrew Morton wrote: > On Mon, 23 Oct 2023 10:51:25 +0800 Liu Shixin wrote: > >> Leave __alloc_object() just do the actual allocation and __link_object() >> do the full initialisation. > Changelog doesn't describe why we're making this change? > . In patch (“mm: kmemleak: split __create_object into two functions”), the initialisation of object has been splited in two places. Catalin said it feels a bit weird and error prone. So leave __alloc_object() just do the actual allocation and __link_object() do the full initialisation. thanks, >