From: Liu Shixin <liushixin2@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Patrick Wang <patrick.wang.shcn@gmail.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mm/kmemleak: move the initialisation of object to __link_object
Date: Tue, 24 Oct 2023 09:33:38 +0800 [thread overview]
Message-ID: <0f977cdb-039d-789b-802f-02746f5ad8ea@huawei.com> (raw)
In-Reply-To: <20231023111624.15ea508ed8aba2dee69035c2@linux-foundation.org>
On 2023/10/24 2:16, Andrew Morton wrote:
> On Mon, 23 Oct 2023 10:51:25 +0800 Liu Shixin <liushixin2@huawei.com> wrote:
>
>> Leave __alloc_object() just do the actual allocation and __link_object()
>> do the full initialisation.
> Changelog doesn't describe why we're making this change?
> .
In patch (“mm: kmemleak: split __create_object into two functions”), the initialisation
of object has been splited in two places. Catalin said it feels a bit weird and error prone.
So leave __alloc_object() just do the actual allocation and __link_object() do the full
initialisation.
thanks,
>
next prev parent reply other threads:[~2023-10-24 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 2:51 Liu Shixin
2023-10-23 10:55 ` Catalin Marinas
2023-10-23 18:16 ` Andrew Morton
2023-10-24 1:33 ` Liu Shixin [this message]
2023-11-14 16:21 ` Geert Uytterhoeven
2023-11-15 3:13 ` Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f977cdb-039d-789b-802f-02746f5ad8ea@huawei.com \
--to=liushixin2@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patrick.wang.shcn@gmail.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox