From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1A0CF9C71 for ; Mon, 23 Sep 2024 21:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 653E16B0085; Mon, 23 Sep 2024 17:56:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6045F6B0088; Mon, 23 Sep 2024 17:56:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A4326B0089; Mon, 23 Sep 2024 17:56:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C7C06B0085 for ; Mon, 23 Sep 2024 17:56:11 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C7B80140732 for ; Mon, 23 Sep 2024 21:56:10 +0000 (UTC) X-FDA: 82597361700.01.30492C5 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf22.hostedemail.com (Postfix) with ESMTP id E777AC0005 for ; Mon, 23 Sep 2024 21:56:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Re65vEk0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=eddyz87@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727128481; a=rsa-sha256; cv=none; b=35OoVr1OWyYjCwtZemVe3AjtRZRncjcLkpBOswFbTMW9PgG8MD4jpqN5eCdFz+jJL9l8BL CNDQ92COsyU5xG2Y0vpLEralQAzgSjFJzyTn0JbtXkkHKh+DcxmVa2a+ePS8jRHK9d1Vd1 WAuOGNY7Os4E8pEPUnNjv3xCbdz2ZkM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Re65vEk0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=eddyz87@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727128481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/8+/Agj95n5lwYDiAPqDI5W15t31UBn8yUoG9/0FMeE=; b=qk9h5aRuFWJ5VOXa+DO6bn6R6noLe7JMPyDfYqKCusV2C7OsXFEaTdAezYsxF8LE7o9ZQl L+Zl7TCyHfgUqoBQqBimGQELvrMdQ3SGGiWfl6g7JS7mzVBlpToNqCFEDoygdlj4wa4duW MLKafBT7Ss7cUCx8o3NlrLoh84ZtOf4= Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7cf5e179b68so3962802a12.1 for ; Mon, 23 Sep 2024 14:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727128567; x=1727733367; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=/8+/Agj95n5lwYDiAPqDI5W15t31UBn8yUoG9/0FMeE=; b=Re65vEk0SO8cMGrIuXcnxszBpDP2h4EWZwbpqjqglYa7Evofk3SyvjPYc7jr2IGkzW X0dSihzuVJy5kaVDfRPCG/MEyRrAaWt6PczCzjX6Z7QrJyAjFcrRDGVBHMQqzgT4LT00 hk2idmKAn8TYW33WUQ2jnu8McQ9Gfnk1I5N9TkrpEchTrCsGGeozAmLcV/gTjA3CgPEk N56SCMVaiCLrX2zVG5vU1I1QEUEM30KKtZj6gG49XP6yNnmPg0M1zkicdtqH4OZPux7z H5x+GB+pDruVk3UjLrqVWIRgNgUBWldX/2NSp+6661R2aoF4i12y6IeMsmp3vUVFr1VU 1oTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727128567; x=1727733367; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/8+/Agj95n5lwYDiAPqDI5W15t31UBn8yUoG9/0FMeE=; b=RXxIYdqExUg5d4jCRp4P2/x4XVk0JQQyMfQXyTwqQPvn8cFObQ3fjkggdqe7P/NbGO smABaZNRfEN5DYQuWN6b8OPb9vidowypeHL1f88An94omu8/iO3MxkFJX+p4xMFMpoC0 wAIIrnNQ2VeGz2H20FIMI2Nktp7879IvGYoyMJr3sPpRQQ5hPqj2Pldm+S1W5jLnN2oQ zphUvkperTlwju0ATppTekyzlaMyPIPJ5cgFBqGAGOE+oJOTAcjlOTz6wAdy7roP2fbG N3AHLJhTVfXAtMcvG8qbA3zXX7mmBmZOo0IdV1o5XH6NayNHbp1hF0VkgC1tzPToaYxo e+Og== X-Forwarded-Encrypted: i=1; AJvYcCWZXrVndGHSwsquYMkypyp2fJbcmn3uhNw2yB9eF/smsK0FcdAy4zuyatYD+uyBg2g2aW8X4siIKQ==@kvack.org X-Gm-Message-State: AOJu0YxNHFginFRhkx6HVCktcqGolK8R+uwkUXxve1qrFWtJDqcGmQFk ONxUovVgn8KOzjKNroDzCLPO6X0dEFVIcmd1672r6RjbYH1Q2cRE X-Google-Smtp-Source: AGHT+IEOWgP+NQYRnWmQn7Tzm3qkB8mabtnbmT8Onpp+Lt2mGQXJbIgQdAxRKso0U9c6JGKqTdiPZA== X-Received: by 2002:a05:6a21:3983:b0:1d2:e90a:f4aa with SMTP id adf61e73a8af0-1d343c5913dmr1421967637.13.1727128567376; Mon, 23 Sep 2024 14:56:07 -0700 (PDT) Received: from [192.168.0.235] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71afc97c102sm80715b3a.154.2024.09.23.14.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 14:56:06 -0700 (PDT) Message-ID: <0f6afef57196cb308aa90be5b06a64793aa24682.camel@gmail.com> Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading From: Eduard Zingerman To: Manu Bretelle , dhowells@redhat.com Cc: asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Date: Mon, 23 Sep 2024 14:56:01 -0700 In-Reply-To: <670794146059f85a30efd7cf9d6650375d987077.camel@gmail.com> References: <20240814203850.2240469-20-dhowells@redhat.com> <20240923183432.1876750-1-chantr4@gmail.com> <670794146059f85a30efd7cf9d6650375d987077.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) MIME-Version: 1.0 X-Rspamd-Queue-Id: E777AC0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pqnj8kckigbwj5krmgwf9agro5o31e36 X-HE-Tag: 1727128568-751686 X-HE-Meta: U2FsdGVkX18aT3LBbJTqXYxX8BL1/8nOBdcIonQK49kWa7yoNNemQGzzwAdcKkW1ZHAvrGZLNTkoIyLJnhA0lbMmPjeeaeprJotEC+zXHpllG7ZDjE4RtZvbgoYwRJm59/n1l6gj6estg/dsx/z6LO/0A1VTAMWsMz+KUzkAED6+5WV95NPOdGFy8sv2dOEpnlj8IgQ7H/ulCWYo0Lak3NbUl4jQ5yGg44kXde4wJYcZynvjhc+b3ebfFLwc4nc+7QlPE9/WgbOzlylV04df5caRNgzD/EjZpf7bIHxDwBp9ydfol+BFLdUQywxNIs/7t3bST/gbafdpI5chFkp/0K20zD6SLm/DYL/nhmRl6zRcLzTDICAk9NNO4cfp7MJ8JnKDlMV1WJKGclLTI0sGltBKrSL7psMdcoIHQPOfts+AFM9mCt2s439tZjiyitaFNI3H3v+fONPNAypNF1dGib0NTOvlsq9G06retH+MOI6mRvyrFQkyMTC7ZoEzpadCUmaFbYt4sfPbJsXi56CP8GsDcApOj3sEmZ0k2lVSnWPSSCHBJtMSFLW4xG5WwEUG9/jeF53Hf5z0fG5SS29yxEtQvHfnEc3t1q1LAo0DWRjQ7FOYmpy3N/D3PLXQVM8TWT7eoSVsnFBBTZJ4XnQLtD3A9DuNPx07Nc1MZO/9EIgpNaXAnBj3wPrVCACMTo+0E83UsDFJzRg+FyIO3b94wYK+GpGKRgF/ZNjLUQfFskmZEwEskcNXPMc9G2pYsTwzfQwlDZnTFiHWxkHBDlKBBps1aCAEqZYlo6HXqCqdfBzhohPhRCHXV6pwsiGNxk5D6flwxGyUv+EYR0p5fM3C2QnrDinazG+b4p/p7MPVF+ewb5R7ecD6o5HItX7szj5PUAErmsoiMuNioBF6Bk0sF600QeyK0uG19Fz6z3kmvJuQe2q08jVoS5J9iMKrGvsgUjZBFCPU0JWij620RPC skHXiBNh z7VwTIncvv2gm3NtRVrsWKu+UD0762nTGklQ9KLHULRmWpfWcGrqxohRLxETx/TxuQbRjd/UrncUsK1F0+cMEhJbYyspSvjFi1dvM7QEHT/LLCYgRW/cpcX1AiZQ9yIZrg8xeuJAyoRxyx0rHgoFapjkODucp4A5lpgJHLi487J0l6Efe1Qi2SBVnHJ1uFapR6Zc3hUajTrTANSe/0mZOecNU3AGJx1Sfn/R3ocw1iCzXuA0ZKMVoHYyZnkhdLYxfCFM9tBkJxqLTqpuNJmuG70Sv7SU/MH/E5isVWBTAiNZJhe57oMAaEMGAFgXAlR5qgmQGlLr9h5FogrRuVoKaYM2wSh3mZ5EeDQrfT8T0GPzTZyFhHoLIlsDFyTbCviCmboCUd7pAPAVXJI0hXoF5YWA45bffXqnGQv6H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2024-09-23 at 11:43 -0700, Eduard Zingerman wrote: > On Mon, 2024-09-23 at 11:34 -0700, Manu Bretelle wrote: >=20 > [...] >=20 > > The qemu command invoked by vmtest is: > >=20 > > qemu-system-x86_64 "-nodefaults" "-display" "none" "-serial" "mon:stdio= " \ > > "-enable-kvm" "-cpu" "host" "-qmp" "unix:/tmp/qmp-971717.sock,server= =3Don,wait=3Doff" \ > > "-chardev" "socket,path=3D/tmp/qga-888301.sock,server=3Don,wait=3Doff= ,id=3Dqga0" \ > > "-device" "virtio-serial" \ > > "-device" "virtserialport,chardev=3Dqga0,name=3Dorg.qemu.guest_agent.= 0" \ > > "--device" "virtio-serial" \ > > "-chardev" "socket,path=3D/tmp/cmdout-508724.sock,server=3Don,wait=3D= off,id=3Dcmdout" \ > > "--device" "virtserialport,chardev=3Dcmdout,name=3Dorg.qemu.virtio_se= rial.0" \ > > "-virtfs" "local,id=3Droot,path=3D/,mount_tag=3D/dev/root,security_mo= del=3Dnone,multidevs=3Dremap" \ > > "-kernel" "/data/users/chantra/linux/arch/x86/boot/bzImage" \ > > "-no-reboot" "-append" "rootfstype=3D9p rootflags=3Dtrans=3Dvirtio,ca= che=3Dmmap,msize=3D1048576 rw earlyprintk=3Dserial,0,115200 printk.devkmsg= =3Don console=3D0,115200 loglevel=3D7 raid=3Dnoautodetect init=3D/tmp/vmtes= t-init4PdCA.sh panic=3D-1" \ > > "-virtfs" "local,id=3Dshared,path=3D/data/users/chantra/linux,mount_t= ag=3Dvmtest-shared,security_model=3Dnone,multidevs=3Dremap" \ > > "-smp" "2" "-m" "4G" >=20 > fwiw: removing "cache=3Dmmap" from "rootflags" allows VM to boot and run = tests. >=20 A few more details: - error could be reproduced with KASAN enabled, log after scripts/decode_stacktrace.sh post-processing is in [1]; (KASAN reports use-after-free followed by null-ptr-deref); - null-ptr-deref is triggered by access to page->pcp_list.next when list_del() is called from page_alloc.c:__rmqueue_pcplist(), e.g. the following warning is triggered if added: --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2990,6 +2990,7 @@ struct page *__rmqueue_pcplist(struct zone *zone, u= nsigned int order, } =20 page =3D list_first_entry(list, struct page, pcp_list); + WARN_ONCE(!page->pcp_list.next, "!!!!! page->pcp_list.nex= t is NULL\n"); list_del(&page->pcp_list); pcp->count -=3D 1 << order; } while (check_new_pages(page, order)); - config used for testing is [2]; - kernel used for testing is [3]; [1] https://gist.github.com/eddyz87/e638d67454558508451331754f946f41 [2] https://gist.github.com/eddyz87/f2c9c267db20ee53a6eb350aba0d2182 [3] de5cb0dcb74c ("Merge branch 'address-masking'") https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git