From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9992BC433F5 for ; Thu, 20 Jan 2022 12:46:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F8B56B007E; Thu, 20 Jan 2022 07:46:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A6F36B009C; Thu, 20 Jan 2022 07:46:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 197356B00A0; Thu, 20 Jan 2022 07:46:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 09B126B007E for ; Thu, 20 Jan 2022 07:46:07 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B16FB8249980 for ; Thu, 20 Jan 2022 12:46:06 +0000 (UTC) X-FDA: 79050637932.08.B4D55C0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf16.hostedemail.com (Postfix) with ESMTP id 36FF018000E for ; Thu, 20 Jan 2022 12:46:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 35312218E8; Thu, 20 Jan 2022 12:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642682765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDxHAmIgZRfOrZZ7G8d/IzuEHF8OI5iVQORd+3hPf0M=; b=jw3uTkYIljr03VsllR2n/LQizTKqcwoT10wxfyT1ja6m+H+DLXXZYVnJzuFqDApHxRb7uA 6ahPT1H6vM5vwk20yrbHCM54mdXQLyHj7/Uy6U9HIsjmkc8ovEf5tCKucO7qKi6wRjjfmo yxz/Jx9T1l1oTgtr2T3Jtb0h/CiXGLs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642682765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDxHAmIgZRfOrZZ7G8d/IzuEHF8OI5iVQORd+3hPf0M=; b=d66As84i5rNF+Y+4UEObXqNZUl6kTm93oAAmWPhT/sy87NIPb1/34bjpF968MqMPCwSQMX VkbQAP7KWlnIJ1Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CE8A513E9E; Thu, 20 Jan 2022 12:46:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fsmaMYxZ6WGvZwAAMHmgww (envelope-from ); Thu, 20 Jan 2022 12:46:04 +0000 Message-ID: <0f62ab3b-eee8-7465-bd5a-470e7e579ded@suse.cz> Date: Thu, 20 Jan 2022 13:46:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 62/66] mm/swapfile: Use maple tree iterator instead of vma linked list Content-Language: en-US To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand References: <20211201142918.921493-1-Liam.Howlett@oracle.com> <20211201142918.921493-63-Liam.Howlett@oracle.com> From: Vlastimil Babka In-Reply-To: <20211201142918.921493-63-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 36FF018000E X-Stat-Signature: a1w3a6x3dweusmhbrhwg5bu8ijn9zytt Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jw3uTkYI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=d66As84i; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam08 X-HE-Tag: 1642682766-356031 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/1/21 15:30, Liam Howlett wrote: > From: "Liam R. Howlett" > > Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka > --- > mm/swapfile.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index e59e08ef46e1..21c88b0944f9 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -2103,15 +2103,18 @@ static int unuse_mm(struct mm_struct *mm, unsigned int type, > { > struct vm_area_struct *vma; > int ret = 0; > + MA_STATE(mas, &mm->mm_mt, 0, 0); > > mmap_read_lock(mm); > - for (vma = mm->mmap; vma; vma = vma->vm_next) { > + mas_for_each(&mas, vma, ULONG_MAX) { > if (vma->anon_vma) { > ret = unuse_vma(vma, type, frontswap, > fs_pages_to_unuse); > if (ret) > break; > } > + > + mas_pause(&mas); AFAIU unnecessary for the resched as we don't drop anything and keep the mmap_lock? (and without that it could be VMA_ITERATOR?) > cond_resched(); > } > mmap_read_unlock(mm);