From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E79C0CD1288 for ; Thu, 4 Apr 2024 19:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6266B6B0089; Thu, 4 Apr 2024 15:48:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D6846B009E; Thu, 4 Apr 2024 15:48:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 476786B009A; Thu, 4 Apr 2024 15:48:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 29BB66B0088 for ; Thu, 4 Apr 2024 15:48:52 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E4E251A0FEC for ; Thu, 4 Apr 2024 19:48:51 +0000 (UTC) X-FDA: 81972887262.08.BCF2CDC Received: from wfout4-smtp.messagingengine.com (wfout4-smtp.messagingengine.com [64.147.123.147]) by imf19.hostedemail.com (Postfix) with ESMTP id B10961A0008 for ; Thu, 4 Apr 2024 19:48:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=hlTSVONy; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=W6wFbnK3; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf19.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.147 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712260129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hiQ9PP65yprDlNGzHIE3Deo1U6GRa/cTqCw3rUTctos=; b=8PVAJ6dP2xS87qonwywD3cCPUvMdu+BPaIB/R4e0ThEQzRNgrbKXUVw4VUYljs4Im7QKkV ci5w5tUYvSucZwz0RQdcnII0Ib8CbZU1+nIIA5lE1wYQ2RB15zGUsX6Sut0ptZBpsjK1gf s74VF24FNFDD5Wb/4S7glFlHyYJi5nY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=hlTSVONy; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=W6wFbnK3; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf19.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.147 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712260129; a=rsa-sha256; cv=none; b=sddiXMUhhwYhv/IQm9Ibz1xXcwb88j7JiqwtF2Z4O5O3VxYAZEDlwOduy3oouB2L910rc4 WwYP1Fy8JEaGFdQoJtL64H2J8KuBWVzJJZLIPZluvGS2bWzzo9qlV6llkoqUnFTSo3i9d3 rhWq6gAgjLlqzW0m5N+kI3YNSZVYMNg= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id E6DDE1C000E0; Thu, 4 Apr 2024 15:48:45 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Thu, 04 Apr 2024 15:48:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1712260125; x=1712346525; bh=hiQ9PP65yp rDlNGzHIE3Deo1U6GRa/cTqCw3rUTctos=; b=hlTSVONye1ukVOCIHyXzI+GsA2 FSAIUselSgLAkxoPi004HDhkuO/kMDWvV0DfDwKxxb25+Hwhw8ExSJ1h4J3/yF2w 2tAFyZEYmLLQIgUyxi9ppwkrEX/uO6MyQQno87/u4WUYaBj4UYK7f9MmfdIxBMZ8 XqCyZJuNvSrTOmr/O6Miw8b3wgu81c+gz6sb9ooJ27vQm1C8eHf2Rig+QJYboQN3 2irE4YRH/zDKwXeJWUhv587KHvtPCoZ3oVVk9dWoq80P/dF6LyIHw3oKN2bpkccR 0AaQarOOTHsirP6I1RQqHtz2S6ZI6e69qnaAw1w8HK6Hg95C/e2OzxV7VVUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712260125; x=1712346525; bh=hiQ9PP65yprDlNGzHIE3Deo1U6GR a/cTqCw3rUTctos=; b=W6wFbnK3sSgBJsAKxp6mAVBno17pc6Vboff+je/06/4T 0HS8tYofyJdiwXKkS9aRdHSqs9d3u9kLjIyqAx2SBMMIDntyC8WVohFRI7ksxgYO QsjM3kRSPhPCz74n+b1LAtAxOO8DCAMQFz5tKEtY2tJStHzaa5osz+pjXH4Aisyq jM3L3/P3YBB3xqVJ0Q5fyUdjX0HCYCCK875tXPRlDKUI7MynsYDQYXh5LOjbrapF UBETYNbuAY5GaRMrzGD4difEOite9QGOJAg6KwEVB3nOYEJOqjlhHvVxDkHy8Mg+ dURGACBcCDV6YEStit7tL04rXeDEOp8Tf/55pGn7lg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefkedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1F290B6008D; Thu, 4 Apr 2024 15:48:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542 MIME-Version: 1.0 Message-Id: <0f4d6888-af13-4419-974e-dbfb5eaffa82@app.fastmail.com> In-Reply-To: <20240404111744.40135657cd9de474b43d36c7@linux-foundation.org> References: <20240404124435.3121534-1-arnd@kernel.org> <20240404111744.40135657cd9de474b43d36c7@linux-foundation.org> Date: Thu, 04 Apr 2024 21:48:24 +0200 From: "Arnd Bergmann" To: "Andrew Morton" , "Arnd Bergmann" Cc: "Andrey Ryabinin" , "Alexander Potapenko" , "Andrey Konovalov" , "Dmitry Vyukov" , "Vincenzo Frascino" , "Mark Rutland" , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kasan: hw_tags: include linux/vmalloc.h Content-Type: text/plain X-Rspamd-Queue-Id: B10961A0008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ojpqjbpitxzn1eecxfyuwqjwhsesjfqt X-HE-Tag: 1712260128-413590 X-HE-Meta: U2FsdGVkX18eT0sMO97wv1XrFGdBtdwk/jPMYtM2xfaKe+JFwls2F71twm+qTw2BfQFxir7SIt3+zeT7t21VaBOBBMVe1MaQV0pIhr2WXXqsVo7eAlPO2fa/4vBjk33HXaQRS4LxH5GnhBSRyxY3+dgPJ7pTJZN0fKzKHHqcITi6LZHOBF2dV77wwGUWY9hXlm8Jk9MsPMtho3LdIjzfsBS1VW5HD+i6tTMsR2F3tP31xhDw+5Ja9vlJjCqAfZ0eoUAnXz/NSdAqUQzGKXt7bC8vVMi6dzp9Zk7x9EzwZe+5Ff4DEaVo+xRUrACnSYafOcBFVQrrxY5GE+z5J77F52vfuo1QURoZfcAE5xQfFvyVK/kQnIN2N/4IvcU57x8fvYn97osXofzy5ASWD0+vwAGRpE2tAcUS2UWPvGYrEKXH9lbB3Zptn5RKeNrAGx4n3m/5TP+COKRpSaYjDa2v+eKj9/VaO2u5bLFxEBoa519iqUC0jaZtJSi0C4Zt7YGzgp8hrNgVoxEe69C1LM4WE7VOPQ0rdo3Lq3uRVFr8M8SFba+X5Gl015z/EWG9Ajk3O3+O1D2nrCpN2VldlXrdAS405mAAevz6V2kjf9qcJOXMYy5vHRsnxtRNtrWWM9jpXmEpcxqJLnzjx0nHZ35z9CDjI6DchBYt54xzb8peGK1qWtp3Tr5FCOQZS+rvVvuntLkfNNlT7DiEUTcdY/dU7K+khCHBg6u7GWOjK26CvAUr+aYkzVUmbFJHyMYouOWbu95dcMoWTrbdgK8WirnskKS62WNE64OazJlronUsj5hYzYX7j1vNbQAvW0w12VePyuvgO7j8OQbLVn1Ax8dznbNEJ8MQyCC0FQvJYRPZ+3WkXRJrzloLnXkX1onM89/XLO8+0Vd57cme1T5KF6S2J9ZJpWyXUe5N/6cE+Aq9N05J6Zy8AGjUBe+BVOZoPvN7w/77TJssU7kxL3JLYRN VFwGxdcI V9W3sT53Emd8NSuc7Z5nCokNax8A4an/wHpljtd3Sl6zECTg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024, at 20:17, Andrew Morton wrote: > On Thu, 4 Apr 2024 14:44:30 +0200 Arnd Bergmann wrote: > >> From: Arnd Bergmann >> >> This header is no longer included implicitly and instead needs to be >> pulled in directly: >> >> mm/kasan/hw_tags.c: In function 'unpoison_vmalloc_pages': >> mm/kasan/hw_tags.c:280:16: error: implicit declaration of function 'find_vm_area'; did you mean 'find_vma_prev'? [-Werror=implicit-function-declaration] >> 280 | area = find_vm_area((void *)addr); >> | ^~~~~~~~~~~~ >> | find_vma_prev >> mm/kasan/hw_tags.c:280:14: error: assignment to 'struct vm_struct *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] >> 280 | area = find_vm_area((void *)addr); >> | ^ >> mm/kasan/hw_tags.c:284:29: error: invalid use of undefined type 'struct vm_struct' >> 284 | for (i = 0; i < area->nr_pages; i++) { >> | ^~ >> mm/kasan/hw_tags.c:285:41: error: invalid use of undefined type 'struct vm_struct' >> 285 | struct page *page = area->pages[i]; >> | ^~ > > Thanks, but I'd like to know which patch this patch is fixing, please. > Is it mainline or linux-next? I'm suspecting it might be a fix for > fix-missing-vmalloch-includes.patch but without knowing how to > reproduce this I can't determine anything. It only showed up yesterday in linux-next. I thought about bisecting it but ended up not doing it as it seemed simple enough. fix-missing-vmalloch-includes.patch looks like the right place to me, given both the timing and contents, so please fold my change into that. Arnd