From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCCD4C4167B for ; Mon, 2 Jan 2023 08:39:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1509F8E0002; Mon, 2 Jan 2023 03:39:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D8668E0001; Mon, 2 Jan 2023 03:39:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBB298E0002; Mon, 2 Jan 2023 03:39:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D6B6E8E0001 for ; Mon, 2 Jan 2023 03:39:32 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A45E14063D for ; Mon, 2 Jan 2023 08:39:32 +0000 (UTC) X-FDA: 80309210184.28.6E15566 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id C998820005 for ; Mon, 2 Jan 2023 08:39:30 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ScZXyyDk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EM7SMaIl; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672648771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zBpzvYwTG7MktQJZQ60oM5iN55WPRaqqwC7DCEgXNrM=; b=ssyosFxoICGzeeMaDSIPZIevPpS8vGlGXVqkkYHFzUHq7I5jcAUcFJxPbQPeOD8MKBCmwz AzASa+o+F+IEw64th1qF2BI9NIqISO8OcQJKan3AJK7QFRoYHscZ8w/6lCR84lcNEaTLho Y+CA0/1p3dnu57z4Lgt1XA7NHJariZY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ScZXyyDk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EM7SMaIl; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672648771; a=rsa-sha256; cv=none; b=xu3TyQ3wpOf1myF1HnEksfUoxabMpnOh7TonpL+7nt0TltuJL+bApRx9wgRr0rW4RtDfRs SJrvkd4PHRpdiIfsMKoXejkxYfNkG7M1H5L3WaliJb99zFut3u6Jxw9eidA0/X3eT39pBK Uklzy4uhyYbbwt2dMCeDMGLaIGXLXT4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 59CE433F82; Mon, 2 Jan 2023 08:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1672648769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBpzvYwTG7MktQJZQ60oM5iN55WPRaqqwC7DCEgXNrM=; b=ScZXyyDkp3FSC9rCEqv8glXmh316nDRRBqEdxFm2B85ZC1QzyP+kDYROvtjeMq9rmc7dQu JiI/Qd+BL5YyaEoCYal2v4UJmMagl85ET8KTmTQl+bbiAkRhtiQyPzxhNSoApVbd1lGUIb 3JHg2/iCEhRzxRjoMsMKaRXz+sLIWec= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1672648769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBpzvYwTG7MktQJZQ60oM5iN55WPRaqqwC7DCEgXNrM=; b=EM7SMaIlHYkfB6f2LuUlB3uwF90WNRoTFdKaIiuqR8aOAQqieK++OflGumRL3c/FJ0KVW8 KFxABA13vb0Dg+AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B17B13427; Mon, 2 Jan 2023 08:39:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lnXHCUGYsmODKAAAMHmgww (envelope-from ); Mon, 02 Jan 2023 08:39:29 +0000 Message-ID: <0f330796-480e-0b78-c2f4-006eac38d7df@suse.cz> Date: Mon, 2 Jan 2023 09:39:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V2] mm/slab: remove unused slab_early_init Content-Language: en-US To: gouhao@uniontech.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, keescook@chromium.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, mingo@elte.hu References: <20221218123127.23810-1-gouhao@uniontech.com> From: Vlastimil Babka In-Reply-To: <20221218123127.23810-1-gouhao@uniontech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C998820005 X-Stat-Signature: 9jhf4iunkfzn4ahzdwosuw59x8a4udz5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672648770-768542 X-HE-Meta: U2FsdGVkX1/0Z6+kWGeISSn1nblqk2B2X24rD14RRrg4Sff28RJ4qEjxuMLb80GrscSPmjAuCrNtYfevBwRG+MU2hDjhzXf7gFRPZJ7y4j4zyPN6FOIqZQzj8aAFQS/lOGiUfj4gV5ugPbjMZ2eMrlE8+vSqul6EdQ+DYYb4W5JX2RN0ekQ0YARqJwlAD7wmCcq/JV82CLrnnlAJtn1+AeE7FxxxoGiK48jgM3TOLr8jqK6n5GiMT18UfrBZa08nkt4852V/c1ppriKSxXDAoJEWuBrIsxaRq2tAwgzhRG9x/BKl8tJnfo4lzLNYGbet+Ocyp/X1J1XJ2l7JuUUwT57V03oHybkMByDF1xI9md3fWn2bZNsoTa0TBZW9eVj3/C3vyIR4kr0YdtCCNjQbf6cdsS7oVrtICGc5DbvxTXwv2OwdHMHje2J6G3A20wjROoiT+/jJ38Gbp4j2U+dz/+KG3dvz19qeh57JgqVLrxLmVphlyztCTGYLamF5P8hSlX/lPwZ7oOQGsHS786Vfk6q/PWg1Wd6mtG5X+KSbObcXw/4W5aMopvPec0PLD5vag3B6pzg08dysHPxUyvai8oz162rm3da6VfLtGIQatd1D3TGepHaE97zW4Pr4b4BXzxZaMH8UMqT/Xqzw4SPkGfHKPyndrMZhbjYfNqCFAlTvOLfA/Dy/rEb6ySpIpjPzUMkmzmi348ht1pWTqdJ5tfdaelC4th6u0KJcJnhHOHFKspIT8Oqk0MKN7T/Ff5sn1zu2VtVyJ4Yee9LnskwOEvxKMsVuAI00bdKqz9TpziC7DOwCH1mhfta7qQtMp26zO2uVrwAdPk5SgYIky/hau1TU0hDCSfFNXK3AdgGHT5cEkiYMwJoWNDKvAkSdk30D+he5NhWgxVIBYRl289RBd/SG6PN6ImtEGsyxBt+w680fbMQwvD5pRcBmo4j6JDc6IEwTarBr6ph39Rjojty nHqp4mSu bqNKiKC8fgx/8cbvvf4mvfQ3VEwFokcr19U/USIFr0goWaUMF+b6aBCWYxYFiHfgyJ2NN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/18/22 13:31, gouhao@uniontech.com wrote: > From: Gou Hao > > 'slab_early_init' was introduced by 'commit e0a42726794f > ("[PATCH] mm/slab.c: fix early init assumption")', this > flag was used to prevent off-slab caches being created > so early during bootup. > > The only user of 'slab_early_init' was removed in 'commit > 3217fd9bdf00 ("mm/slab: make criteria for off slab > determination robust and simple")'. > > Signed-off-by: Gou Hao > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks, added to slab/for-6.3/cleanups > --- > mm/slab.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 7a269db050ee..ede1f29fd81c 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep, > static inline void fixup_slab_list(struct kmem_cache *cachep, > struct kmem_cache_node *n, struct slab *slab, > void **list); > -static int slab_early_init = 1; > > #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node)) > > @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void) > slab_state = PARTIAL_NODE; > setup_kmalloc_cache_index_table(); > > - slab_early_init = 0; > - > /* 5) Replace the bootstrap kmem_cache_node */ > { > int nid;