From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB873EB64DA for ; Thu, 20 Jul 2023 09:06:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285572800E5; Thu, 20 Jul 2023 05:06:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2350028004C; Thu, 20 Jul 2023 05:06:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FCF12800E5; Thu, 20 Jul 2023 05:06:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F063528004C for ; Thu, 20 Jul 2023 05:06:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BEBC040236 for ; Thu, 20 Jul 2023 09:06:39 +0000 (UTC) X-FDA: 81031409718.05.A2C1234 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf19.hostedemail.com (Postfix) with ESMTP id 821521A0008 for ; Thu, 20 Jul 2023 09:06:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689843998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ILYlvoXg6GD1zTq8YVD4KDohZi8Deh7uhxFtiqD9zsM=; b=il1WH8IE4/uAddJIEJR1zO/HRN/mo6UB7PLg5dm7jR6uYhwyvhUySLIe4yFcUf63jhmeFu aSUIGSaGg+OPfiTLdkRwmwhSS8lH54OnYuPw2tdMKTO+RNuKMIL6Fdi5xEPUwxxlY9Wgpd q5F0TtPcz3ozZ1vLpRQz3zYGdGta5wE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689843998; a=rsa-sha256; cv=none; b=3yV2h6V31Feb2FDwtkN/ZI+mpMNF9T0DsF8OrKwtIJiPGlmkCIF6i5hrZ6UxgF2vNewZNd 4c2WX7f6VtlT5cmq6On0//byIPjTJqbY4zM4uwtl+PhohgBwvCjI3UjRC6IdIqllw00drq 4GLgTHW7xsvM3RdZ59S8kGLcoPlV5ts= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4R66Gx5Dn5z18LYT; Thu, 20 Jul 2023 17:05:45 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 17:06:30 +0800 Subject: Re: [PATCH] mm/memory-failure: fix hardware poison check in unpoison_memory() To: Sidhartha Kumar , , CC: , , , References: <20230717181812.167757-1-sidhartha.kumar@oracle.com> From: Miaohe Lin Message-ID: <0f1f354b-7308-d170-d84e-3c64161be647@huawei.com> Date: Thu, 20 Jul 2023 17:06:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230717181812.167757-1-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 821521A0008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hnsdmzboibwdfzmk8ykufiij9i1i6c15 X-HE-Tag: 1689843995-266140 X-HE-Meta: U2FsdGVkX1+O3d5t7iq/FDKOxPIuqGGl4MT5Bh31amMO6PgN18Mft8XCjdP2rTrYJZI3GPrK19gYAyk+7QIjaQDoBp7SsKZLSxgROxNTSOgG3hZcdAt6zvEESv3DJ02krdkKfBbGwJE7qjJX2+AXYqTdKl01ZZQYao8bAiDrV/urAMgXU2fpZ5F7K5AK2UYzIO/fvdy+eRg25hewszO6qAmbL+WES6kRHswHJ6Hg8PRylrO+oqsyStwYCGP8G5dRktO0HbR61/Bo9Etua24YuGv7LtoYBUwntQJ5Vs6BxXfS1CnXm0abKLrm2u1j/fryUU3Z6/K+cTVRV8k7zbd5Jwp8pJABuaFrnNvE86fYdeNehHhOZWbDsK/5M/gs3JlrUHpEOlig1pULjUQmS5JGho6/0BtJ/3wgSAO9eY19QZGiRXVzgoym/G3qdX4D4VDt/NDW38pW7Y7WlFAe/SzKxhjL4DMvB+6A6V/Tx4mgvTkVnPcyjC5k8c3u/oZR24edlbtLDDEUddhIikmN+Nkdb2fhx9GnC26zNgrum1RQcdav7lLI/YL3lgt4GO1hetJrfsKZ/221aew7AR5bw96Tyf1Wf5JnNRKbYGVezSIXufH/xD/PZXZW98921x5MkAbv1p2m3Auz3yr1Ybzm53t54TZhTF0SV2ErY8v0FWAIAFhPC9IoxupaWTP3gFCMWFAfU5HDwbf8OrsumeiBUvf2bOkjH/tt/XIk1JxJa1c7uRoMTgsfw8yVI/xcOmPxBf+pp0ZKhLAuZ4m1JRBX2kvz3T2iVg44JJ3FWgxZA5R6vR8JKJOWgyn7s1A0AA8iB5GAn7FVJi5UJ5xap4jFo/Ki2XpFD39lHreTQSiDE8vFTYOWXLsrXwqSeHAccnzVyipSbmNEhJOtQO+eTjD9N59GS/Pd5smtsAq7A4DL+Jnqs7lLqJIsaa46zTcRqbjI9CW3q2tWRiZT7XNthcsOvUa C0ecyZjQ X4k2A7dXyr+qYc+7/+gdM1wr9hf98Vlw2TTONxMdm0c44pAb8JVoszCnmO9CWspLuwlJGY4NmgNGOadZtd5FA5HyLskjoxWyYL0OC1zQzAPe3Lg0oHlkseIrr+vpECNBqrhgF+PY/K7s2ZxPYXtrr+O+TLSMhMEFtRC0beNnlEelFl8WwvL6jZynjHXNpT0UTEZu3vjsqOhtMzpfZnxNU4KrdsTCNik+TRk2RY8RFl6EeNHWrMZFVZwHU57Eud4nizFVyeXAXIM04Yy+Kg5SL95ulesQ+Mxm5GjsXlIdJNssJIkdZpDMZsiJK+Ugern9IOXWgIl39FhCNNyQG4mEkrBt2uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/18 2:18, Sidhartha Kumar wrote: > It was pointed out[1] that using folio_test_hwpoison() is wrong > as we need to check the indiviual page that has poison. > folio_test_hwpoison() only checks the head page so go back to using > PageHWPoison(). > > Reported-by: Matthew Wilcox (Oracle) > Fixes: a6fddef49eef ("mm/memory-failure: convert unpoison_memory() to folios") > Cc: stable@vger.kernel.org #v6.4 > Signed-off-by: Sidhartha Kumar > > [1]: https://lore.kernel.org/lkml/ZLIbZygG7LqSI9xe@casper.infradead.org/ > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 02b1d8f104d51..a114c8c3039cd 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2523,7 +2523,7 @@ int unpoison_memory(unsigned long pfn) > goto unlock_mutex; > } > > - if (!folio_test_hwpoison(folio)) { > + if (!PageHWPoison(p)) { For successfully handled pages, they should be non-compound pages (dissolved, splitted or normal pages). So this patch makes no change for them. But for failed to hwpoisoned thp and hugetlb, there's some difference. But since Naoya points out that, "the users of unpoison should know where the PageHWPoison is set via /proc/kpageflags.", I'm fine with this patch. Reviewed-by: Miaohe Lin Thanks.