From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB646C54756 for ; Thu, 22 May 2025 09:24:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F34D6B0082; Thu, 22 May 2025 05:24:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A4676B008C; Thu, 22 May 2025 05:24:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BB6F6B0096; Thu, 22 May 2025 05:24:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EE3006B0082 for ; Thu, 22 May 2025 05:24:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 930A1120D4B for ; Thu, 22 May 2025 09:24:01 +0000 (UTC) X-FDA: 83470007082.29.4A3E7D4 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf28.hostedemail.com (Postfix) with ESMTP id E25DDC0003 for ; Thu, 22 May 2025 09:23:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nQ3wMS6T; spf=pass (imf28.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747905840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=avjo55ebe7BgHKOgNprUwDqOEbppK9cXNMGqMlzeVPs=; b=O9zcGl+JqPDhpPOcDjvq1YhC9wjppZ4ny81yW3FuVSkweVysOlCrsHLAyhjo3tqQZC+cpr rG2vj7aLxhXCBwLnvYUyN8jX7TXWGjJLfbdLXP/GpOy4Hy41J5/I5bXSIfoFmmDvAVoRHq RIk43B/eKdG/t6p3t0qC60uaFleXyio= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nQ3wMS6T; spf=pass (imf28.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747905840; a=rsa-sha256; cv=none; b=cKFqyaI4/Pr95zbWvhuGTOIHaYYw2z42eUKv6/KUBK04oXOrXhc/ofa5R3iJ8hzZESh8XJ SLx/N6m+wEJA50OzMui3XGrC02AwznwzLCOt3JjvwDr2fU4r6InkhS4WgQeG0VG/OB3GfP aJhad4/echHvIdsQEw+hEnjb9DxqHIw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 1A03C62A37; Thu, 22 May 2025 09:23:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CB9BC4CEE4; Thu, 22 May 2025 09:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747905838; bh=eXAlb49JkCb+TQz9exx3hf5fNZb3kP86w2z33zlM7Wc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nQ3wMS6T0pfisADnNRP2uPa31VU+qtbXzfiwWoygKXDQliDo35SJyyoKHXV7oyt0O MJ9xlgSXX5R9dfkDq/Hq3QjbBrxJ4wGDuQVHw9dJpMpRrw1HTU+w2Xszb/xtWWf+F6 fREJkAQEUuSo72YJTNzVs5z4G+tv/LrHNZiVFTYVlWgRPAkYE5q3+R0zZxUx41okBf tKp2e3Q8Fjsl4VEWRe7PjcpYUvp8fw8fB2yl+WEIT3OVLpIp44Xn9hnAylgvG3ahbI CpOA8SD8w4FvpQ0MN+EbZC8gI7nWu8TopVaV6dMOPVQpwlrTnxvmuqr3ogvrlmy3xB 8IUB+8qbaS78Q== Date: Thu, 22 May 2025 10:23:54 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm Message-ID: <0f0622f7-2630-40f4-8556-99bd479d1aff@sirena.org.uk> References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <58dbef73-6e37-46de-9092-365456306b27@redhat.com> <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1STrL/W39KMKSBxv" Content-Disposition: inline In-Reply-To: X-Cookie: Beware of dog. X-Rspam-User: X-Rspamd-Queue-Id: E25DDC0003 X-Rspamd-Server: rspam09 X-Stat-Signature: qzodo1asybeam5efcu83ghkf33gsrb3c X-HE-Tag: 1747905839-457314 X-HE-Meta: U2FsdGVkX1+/EhHWhyPJ7hQFjTSY6UBcDoXGQpF6222yr313+UjYS/2CvE83KrkQUQ9Su2+Ki7TNpOrKmSeU82DVDqlu1pHQM085lRoA7QmtYB6mSuq26utZWCnVj5ewQfeCGTztmzio+KLNCcz3Ud6GYu5ahL6yvZTk+bTVKrGKAy50o3owpz0ivyQlr/6ljq1pMwRoevmFnFL2Jy393j3jvq2DlaYDQvTDsFsd/UEft4m1Mt/supjFIJckfj1SFBmtw6tukf0i37qFU0YwpLRrX+zKv0F/Y6u1LzduVOYC4ZWLzRAx/GrweyzTZcU2k0qjsaslIGhT6x5guJadJ7HlPYBboMtECwQrK2XM/PGKMUbzefBcnx1F0ou8V1lblVf29/QL9Vn/scHZoWsK3Wk3Jh26Hq69fTW/Q9qmU0edUOmZkIqugvPmuqpyFMT3oYRNkf/XuDLaYdUJMoHRInqUwBh8+YMFbbXyCklOne4jR29MYVdDaCH4uTH1mfUCwzpLGISAxKhRMMnDXGZ3Of3L0pd6K+mIKkm5gp+MDFgo7rA1rgnU2TxYK+cVrl1l6cHxxIcQOBjWc85bMusa3Gbp5PClkc9FGWRQqtDpv08MRjNTFigqpRCkXHJweGmZyId+aDd2TymI4KjPR6yPAaAR4fIUIQegfTk3T1ykX0oagaxe0LtBelMo46qjjaEE38MCnnuOAw/fvkHjRemEuhf4PkNf1kpTYX2RHzFdfHI176eqSyrWgqddlO1RjMSqd+jFhN4fYnRqBHDWz6Bz2Mm1AaliRW93oBrALdREqZZ27LeBOI57SYogHXSh3bELBgEhX6b1xxhHTbzFblSGt496C3FFHkNxeZ11/mJXGpWtUTClqDaVp1bS8gymZluOIxr/mGXVdKpqbhZSMzj2sFMF04SpvsxsPqGfVCZa0NsEQfZ8pxNXE1OXia+IALwGl4eFvBBoW8b6Z0AXu6E QJi7kt78 BD660c6M81D10+CEzGQqhmS/H2XQmpvhABdEylqB0uAP+D9XtMKJSukwq6ql9YkoTttKJksA9ur2AhFZz5BTCgCeptXKonR/e0R+JUBDgH/GQDRt+mXH0IP3eqAgB8cZIivBYgh1OlRqiCVhcrj6YI8R7bz9mgNSBNdK6q6ncX51VyUuB8vApGi2B6KEVGRVOiF5Y+0tTemopl4z2iDhAEIDQ7EHDl90/SyWq+cxpif9UBxhxAMVxn6gLysLwEFrMuJulHz/e0ulYYzubew1k4BF5VCV/tb3gPVBA/sbcFTevb2tUIDLQVuNSGW1GReUYbmgBVQLdgun9SPix4T0BXH1WQsy6pKtjluAc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --1STrL/W39KMKSBxv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 22, 2025 at 10:42:50AM +0200, David Hildenbrand wrote: > Probably, one might be able to revert the logic: instead of running each > test for each size, run each size for each test: then, the tests are fixed > and would be covering all available sizes in a single logical test. Yeah, that should work - it'd lose a bit of resolution in the test results for automation but I'm not sure how often that's likely to be relevant and the information would still be there for humans. =20 > I agree that that really is a bigger rework. Let me take a look at your > original patch later (fairly busy today, please poke me if I forget). Thanks. I'll take a look at the other similar tests like cow using the same approach I've used here. --1STrL/W39KMKSBxv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmgu7SkACgkQJNaLcl1U h9ASlQf/cRLMEkBxUlfbfTgzQ+8TLtGOObYAhPQyrMYAQOdor65OEzy35eYR94iV d5T1hf0KzpFeZ9eGyZlpIJx7SeUWlAHsj486xpc+kDhmj0HOBrw9aPjseaOuVmNp bfnzh8jpNOBpQ95Y/7oXvC8iQTjbB452hrUtF0UMdV7dYzYdEumg/zMAKZZdlDi7 TTOEDfdMqcRQUDlhHVLnPcBNydzGsZbAmaJofT8+L20pRPrDuVthuPM67/XFDN4P HVbDn+2PGwz189ms892GBoaYc9Bq5eJKiqNTGzywL62AZMfCIVESFndjfzrAxK0l yhWcd/A+J45cI+ASY+FlwqRB5qXJpw== =Wtd4 -----END PGP SIGNATURE----- --1STrL/W39KMKSBxv--