From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Shixin Liu <liushixin2@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 3/3] mm/debug_vm_pgtable: Remove useless pfn_pmd()
Date: Thu, 1 Apr 2021 20:11:30 +0530 [thread overview]
Message-ID: <0ef29a80-5873-ddf6-bfb0-7d1b5c17b8c0@arm.com> (raw)
In-Reply-To: <20210401022315.2911967-3-liushixin2@huawei.com>
On 4/1/21 7:53 AM, Shixin Liu wrote:
> The call to pfn_pmd() here is redundant.
>
> Signed-off-by: Shixin Liu <liushixin2@huawei.com>
> ---
> mm/debug_vm_pgtable.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
> index c379bbe42c2a..9f4c4a114229 100644
> --- a/mm/debug_vm_pgtable.c
> +++ b/mm/debug_vm_pgtable.c
> @@ -196,7 +196,6 @@ static void __init pmd_advanced_tests(struct mm_struct *mm,
>
> pgtable_trans_huge_deposit(mm, pmdp, pgtable);
>
> - pmd = pfn_pmd(pfn, prot);
> set_pmd_at(mm, vaddr, pmdp, pmd);
> pmdp_set_wrprotect(mm, vaddr, pmdp);
> pmd = READ_ONCE(*pmdp);
>
Instead drop the first pfn_pmd(), as that pmd would not be required
when THP is not enabled. Also, please fold this with the first patch.
next prev parent reply other threads:[~2021-04-01 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 2:23 [PATCH -next 1/3] mm/debug_vm_pgtable: Fix one comment mistake Shixin Liu
2021-04-01 2:23 ` [PATCH -next 2/3] mm/debug_vm_pgtable: Move {pmd/pud}_huge_tests out of CONFIG_TRANSPARENT_HUGEPAGE Shixin Liu
2021-04-01 15:05 ` Anshuman Khandual
2021-04-01 2:23 ` [PATCH -next 3/3] mm/debug_vm_pgtable: Remove useless pfn_pmd() Shixin Liu
2021-04-01 14:41 ` Anshuman Khandual [this message]
2021-04-01 14:34 ` [PATCH -next 1/3] mm/debug_vm_pgtable: Fix one comment mistake Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef29a80-5873-ddf6-bfb0-7d1b5c17b8c0@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox