From: David Hildenbrand <david@redhat.com>
To: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>,
linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: selftest/vm/cow.c failed to compile (‘MADV_PAGEOUT’ undeclared)
Date: Mon, 9 Jan 2023 17:42:25 +0100 [thread overview]
Message-ID: <0ee389dc-5e47-5b7e-4db5-637eb2b3fbc9@redhat.com> (raw)
In-Reply-To: <0f117203-3227-cd16-61c2-2dd3de75ecc7@alu.unizg.hr>
On 08.01.23 11:58, Mirsad Goran Todorovac wrote:
> Hi all,
>
> During "make kselftest" there is an error in selftest/vm/cow.c compilation on
> platform:
>
> - Lenovo desktop 10TX000VCR (LENOVO_MT_10TX_BU_Lenovo_FM_V530S-07ICB)
> - AlmaLinux 8.7 (CentOS fork)
> - gcc 8.5.0 20210514 (Red Hat 8.5.0-15)
> - vanilla kernel 6.2-rc2 from the torvalds mainline tree.
>
> Compilation fails to find "#define MADV_PAGEOUT":
>
> [root@pc-mtodorov vm]# make
> gcc -Wall -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../.. -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -isystem /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -no-pie cow.c vm_util.c -lrt -lpthread -o /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm/cow
> cow.c: In function ‘do_run_with_base_page’:
> cow.c:755:26: error: ‘MADV_PAGEOUT’ undeclared (first use in this function); did you mean ‘MADV_RANDOM’?
> madvise(mem, pagesize, MADV_PAGEOUT);
> ^~~~~~~~~~~~
> MADV_RANDOM
> cow.c:755:26: note: each undeclared identifier is reported only once for each function it appears in
> cow.c: In function ‘do_run_with_thp’:
> cow.c:914:22: error: ‘MADV_PAGEOUT’ undeclared (first use in this function); did you mean ‘MADV_RANDOM’?
> madvise(mem, size, MADV_PAGEOUT);
> ^~~~~~~~~~~~
> MADV_RANDOM
> make: *** [../lib.mk:145: /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm/cow] Error 1
> [root@pc-mtodorov vm]#
>
> MADV_PAGEOUT is defined in #include <asm-generic/mman-common.h> :
>
> [root@pc-mtodorov vm]# grep MADV_PAGEOUT -r /usr/include
> /usr/include/asm-generic/mman-common.h:#define MADV_PAGEOUT 21 /* reclaim these pages */
> [root@pc-mtodorov vm]# grep MADV_PAGEOUT -r ../../../../usr/include
> ../../../../usr/include/asm-generic/mman-common.h:#define MADV_PAGEOUT 21 /* reclaim these pages */
> [root@pc-mtodorov vm]#
>
> However, gcc -E shows that asm-generic/mman-common.h is somehow never included:
>
> ---------------------------------------------------------------------------------------------
> [root@pc-mtodorov vm]# gcc -Wall -E -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../.. -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -isystem /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -no-pie cow.c | cat -s | less
> # 1 "/usr/include/sys/mman.h" 1 3 4
> # 25 "/usr/include/sys/mman.h" 3 4
> # 1 "/usr/lib/gcc/x86_64-redhat-linux/8/include/stddef.h" 1 3 4
> # 26 "/usr/include/sys/mman.h" 2 3 4
> # 41 "/usr/include/sys/mman.h" 3 4
> # 1 "/usr/include/bits/mman.h" 1 3 4
> # 49 "/usr/include/bits/mman.h" 3 4
> # 1 "/usr/include/bits/mman-linux.h" 1 3 4
> # 117 "/usr/include/bits/mman-linux.h" 3 4
> # 1 "/usr/include/bits/mman-shared.h" 1 3 4
> # 42 "/usr/include/bits/mman-shared.h" 3 4
>
> int memfd_create (const char *__name, unsigned int __flags) __attribute__ ((__nothrow__ , __leaf__));
> int mlock2 (const void *__addr, size_t __length, unsigned int __flags) __attribute__ ((__nothrow__ , __leaf__));
> int pkey_alloc (unsigned int __flags, unsigned int __access_rights) __attribute__ ((__nothrow__ , __leaf__));
> int pkey_set (int __key, unsigned int __access_rights) __attribute__ ((__nothrow__ , __leaf__));
> int pkey_get (int __key) __attribute__ ((__nothrow__ , __leaf__));
> int pkey_free (int __key) __attribute__ ((__nothrow__ , __leaf__));
> int pkey_mprotect (void *__addr, size_t __len, int __prot, int __pkey) __attribute__ ((__nothrow__ , __leaf__));
>
> # 117 "/usr/include/bits/mman-linux.h" 2 3 4
> # 49 "/usr/include/bits/mman.h" 2 3 4
> # 42 "/usr/include/sys/mman.h" 2 3 4
>
> # 57 "/usr/include/sys/mman.h" 3 4
> extern void *mmap (void *__addr, size_t __len, int __prot,
> int __flags, int __fd, __off_t __offset) __attribute__ ((__nothrow__ , __leaf__));
> # 70 "/usr/include/sys/mman.h" 3 4
> extern void *mmap64 (void *__addr, size_t __len, int __prot,
> int __flags, int __fd, __off64_t __offset) __attribute__ ((__nothrow__ , __leaf__));
>
> extern int munmap (void *__addr, size_t __len) __attribute__ ((__nothrow__ , __leaf__));
> extern int mprotect (void *__addr, size_t __len, int __prot) __attribute__ ((__nothrow__ , __leaf__));
> extern int msync (void *__addr, size_t __len, int __flags);
> extern int madvise (void *__addr, size_t __len, int __advice) __attribute__ ((__nothrow__ , __leaf__));
> extern int posix_madvise (void *__addr, size_t __len, int __advice) __attribute__ ((__nothrow__ , __leaf__));
> extern int mlock (const void *__addr, size_t __len) __attribute__ ((__nothrow__ , __leaf__));
> extern int munlock (const void *__addr, size_t __len) __attribute__ ((__nothrow__ , __leaf__));
> extern int mlockall (int __flags) __attribute__ ((__nothrow__ , __leaf__));
> extern int munlockall (void) __attribute__ ((__nothrow__ , __leaf__));
> extern int mincore (void *__start, size_t __len, unsigned char *__vec)
> __attribute__ ((__nothrow__ , __leaf__));
>
> # 133 "/usr/include/sys/mman.h" 3 4
>
> extern void *mremap (void *__addr, size_t __old_len, size_t __new_len,
> int __flags, ...) __attribute__ ((__nothrow__ , __leaf__));
> extern int remap_file_pages (void *__start, size_t __size, int __prot,
> size_t __pgoff, int __flags) __attribute__ ((__nothrow__ , __leaf__));
> extern int shm_open (const char *__name, int __oflag, mode_t __mode);
> extern int shm_unlink (const char *__name);
> -------------------------------------------------------------------------------------------------------
>
> FYI:
>
> On the platform:
>
> - Ubuntu 22.10 kinetic kudu
> - gcc 12.2.0
> - same 6.2-rc2
>
> , MADV_PAGEOUT is also defined in bits/mmap-linux.h, so the compile passes.
>
> root@marvin-IdeaPad-3-15ITL6:/home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm# grep MADV_PAGEOUT -r /usr/include
> /usr/include/asm-generic/mman-common.h:#define MADV_PAGEOUT 21 /* reclaim these pages */
> /usr/include/x86_64-linux-gnu/bits/mman-linux.h:# define MADV_PAGEOUT 21 /* Reclaim these pages. */
> root@marvin-IdeaPad-3-15ITL6:/home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm# grep MADV_PAGEOUT -r ../../../../usr/include
> ../../../../usr/include/asm-generic/mman-common.h:#define MADV_PAGEOUT 21 /* reclaim these pages */
> root@marvin-IdeaPad-3-15ITL6:/home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm#
>
> However, mman-common.h from ../../../../usr/include/asm-generic/mman-common.h is also not included,
> as of "gcc -E", but only bits/mman-linux.h:
>
> root@marvin-IdeaPad-3-15ITL6:/home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm# gcc -Wall -E -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../.. -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -isystem /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -no-pie cow.c | grep mman-common.h
> root@marvin-IdeaPad-3-15ITL6:/home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm# gcc -Wall -E -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../.. -I /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -isystem /home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/../../../usr/include -no-pie cow.c | grep mman-linux.h
> # 1 "/usr/include/x86_64-linux-gnu/bits/mman-linux.h" 1 3 4
> # 119 "/usr/include/x86_64-linux-gnu/bits/mman-linux.h" 3 4
> # 120 "/usr/include/x86_64-linux-gnu/bits/mman-linux.h" 2 3 4
> root@marvin-IdeaPad-3-15ITL6:/home/marvin/linux/kernel/linux_torvalds/tools/testing/selftests/vm#
>
> I hope this is enough information for you to debug the issue.
>
> I am standing by for any additional diagnostics needed.
Won't userfaultfd.c fail in a similar way?
Anyhow, khugepaged.c jas
#ifndef MADV_PAGEOUT
#define MADV_PAGEOUT 21
#endif
So most probably we should do the same.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-01-09 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 10:58 Mirsad Goran Todorovac
2023-01-09 16:42 ` David Hildenbrand [this message]
2023-01-09 21:41 ` Mirsad Goran Todorovac
2023-01-10 10:05 ` David Hildenbrand
2023-01-10 12:25 ` Mirsad Todorovac
2023-01-10 12:29 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ee389dc-5e47-5b7e-4db5-637eb2b3fbc9@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox