From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34049C433DF for ; Sat, 27 Jun 2020 08:17:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F23CF2080C for ; Sat, 27 Jun 2020 08:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F23CF2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C0416B00A0; Sat, 27 Jun 2020 04:17:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 571A96B00A1; Sat, 27 Jun 2020 04:17:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45F216B00A2; Sat, 27 Jun 2020 04:17:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 2B63D6B00A0 for ; Sat, 27 Jun 2020 04:17:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D0DB2180AD817 for ; Sat, 27 Jun 2020 08:17:52 +0000 (UTC) X-FDA: 76974288384.16.band50_151644d26e5c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id A4E75100E6903 for ; Sat, 27 Jun 2020 08:17:52 +0000 (UTC) X-HE-Tag: band50_151644d26e5c X-Filterd-Recvd-Size: 5451 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sat, 27 Jun 2020 08:17:51 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 49v67c3vRsz9tyVp; Sat, 27 Jun 2020 10:17:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id LVJHe2PffxRU; Sat, 27 Jun 2020 10:17:48 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 49v67c2nSlz9tyVn; Sat, 27 Jun 2020 10:17:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id ACB498B772; Sat, 27 Jun 2020 10:17:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id i_8AMg20BFyg; Sat, 27 Jun 2020 10:17:49 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C3F508B75B; Sat, 27 Jun 2020 10:17:47 +0200 (CEST) Subject: Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests To: Anshuman Khandual , linux-mm@kvack.org Cc: christophe.leroy@c-s.fr, ziy@nvidia.com, gerald.schaefer@de.ibm.com, Jonathan Corbet , Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> From: Christophe Leroy Message-ID: <0ed75013-6ac4-3902-391a-1f7152510c6d@csgroup.eu> Date: Sat, 27 Jun 2020 10:17:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr X-Rspamd-Queue-Id: A4E75100E6903 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 24/06/2020 =C3=A0 05:13, Anshuman Khandual a =C3=A9crit=C2=A0: >=20 >=20 > On 06/15/2020 09:07 AM, Anshuman Khandual wrote: >> This series adds some more arch page table helper validation tests whi= ch >> are related to core and advanced memory functions. This also creates a >> documentation, enlisting expected semantics for all page table helpers= as >> suggested by Mike Rapoport previously (https://lkml.org/lkml/2020/1/30= /40). >> >> There are many TRANSPARENT_HUGEPAGE and ARCH_HAS_TRANSPARENT_HUGEPAGE_= PUD >> ifdefs scattered across the test. But consolidating all the fallback s= tubs >> is not very straight forward because ARCH_HAS_TRANSPARENT_HUGEPAGE_PUD= is >> not explicitly dependent on ARCH_HAS_TRANSPARENT_HUGEPAGE. >> >> Tested on arm64, x86 platforms but only build tested on all other enab= led >> platforms through ARCH_HAS_DEBUG_VM_PGTABLE i.e powerpc, arc, s390. Th= e >> following failure on arm64 still exists which was mentioned previously= . It >> will be fixed with the upcoming THP migration on arm64 enablement seri= es. >> >> WARNING .... mm/debug_vm_pgtable.c:860 debug_vm_pgtable+0x940/0xa54 >> WARN_ON(!pmd_present(pmd_mkinvalid(pmd_mkhuge(pmd)))) >> >> This series is based on v5.8-rc1. >> >> Changes in V3: >> >> - Replaced HAVE_ARCH_SOFT_DIRTY with MEM_SOFT_DIRTY >> - Added HAVE_ARCH_HUGE_VMAP checks in pxx_huge_tests() per Gerald >> - Updated documentation for pmd_thp_tests() per Zi Yan >> - Replaced READ_ONCE() with huge_ptep_get() per Gerald >> - Added pte_mkhuge() and masking with PMD_MASK per Gerald >> - Replaced pte_same() with holding pfn check in pxx_swap_tests() >> - Added documentation for all (#ifdef #else #endif) per Gerald >> - Updated pmd_protnone_tests() per Gerald >> - Updated HugeTLB PTE creation in hugetlb_advanced_tests() per Gerald >> - Replaced [pmd|pud]_mknotpresent() with [pmd|pud]_mkinvalid() >> - Added has_transparent_hugepage() check for PMD and PUD tests >> - Added a patch which debug prints all individual tests being executed >> - Updated documentation for renamed [pmd|pud]_mkinvalid() helpers >=20 > Hello Gerald/Christophe/Vineet, >=20 > It would be really great if you could give this series a quick test > on s390/ppc/arc platforms respectively. Thank you. >=20 Running ok on powerpc 8xx after fixing build failures. Christophe