From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE24C001B0 for ; Thu, 10 Aug 2023 22:16:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 532FB6B0071; Thu, 10 Aug 2023 18:16:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3036B0074; Thu, 10 Aug 2023 18:16:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AC6A6B0078; Thu, 10 Aug 2023 18:16:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2CD456B0071 for ; Thu, 10 Aug 2023 18:16:59 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EFE46C02C6 for ; Thu, 10 Aug 2023 22:16:58 +0000 (UTC) X-FDA: 81109606116.14.13F9020 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id C4B6FC0011 for ; Thu, 10 Aug 2023 22:16:56 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CS0hkXfV; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691705816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ExdQSgIsU8Qpzn8/coG+1H8VMTOqwdmuE5djP/V5DWM=; b=apBsA/Q7EQretSFvsBe2xo9wkDE/LsAbhwpzFt/APHXLsmSkvfItnbqVl9OpIvq4ijs7Ao OImUoGYNuUeMD9s6jtl093bEoN397Dcl+OTbb7WepQPlWicVxcQG/SsUlUDpsNBVNffSCc QDCtcFEviPchORd2Z9ZlxL+5iwy5UX8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CS0hkXfV; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691705816; a=rsa-sha256; cv=none; b=vSSWOp1LWnXLHgDEZEdbdXAntwhvYuSTwzbZoLl3+2p8Ksc9glR1gPjjOm+dcW4aHXd2FA ipTNASQxYmkfos88rNMSkos5xkXcTU0Lk3GIumPAJMlGcEP5TZbjisgXfuxo4OYxHKUVwT ZxhfJl/2leBTKHh6qjNYxqcMtNKScnU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691705816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExdQSgIsU8Qpzn8/coG+1H8VMTOqwdmuE5djP/V5DWM=; b=CS0hkXfV7vwL1+qeEg6YLEw9gc6zOEe+RKLLeGA4p2Z2a+Cv1NwuE6DJ7UapPfbpqXmzhq 90wZUUmB8DTyAaS87IndRToY+FpNg/uI+K+rS/nioIvArtd8GdaDMj8ap/StDQemQrl6T1 7TrTrzRnIyGhXDNh2wN5Egr3Q3RZWf8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-wAnksfB2PX6mEBkDCRP9bw-1; Thu, 10 Aug 2023 18:16:54 -0400 X-MC-Unique: wAnksfB2PX6mEBkDCRP9bw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3176ace3f58so890501f8f.0 for ; Thu, 10 Aug 2023 15:16:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691705814; x=1692310614; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ExdQSgIsU8Qpzn8/coG+1H8VMTOqwdmuE5djP/V5DWM=; b=dR+dqQ5+HWsftPQ0FZNKT80bV7xnr11heL0tlPwRwnpeeylCSpUyRDi9JENaf2V0kg tWbPGDX2bs8qVIggzEqsqwPu/uDKY56Aszhwn1xsczm2DLoMBB9TGvwjcokjGfjfdv1u Gds8HIIieqSwYg6TosszCk6AHhD1zqNq9t5f0SiwoID+XHWu3/y2vAQZrQ4NzXVDr6/I kS68gmwogfEMHvO29U3WXGp5CiBA/gD+CL8HwgNMXBadBxzyRgismZzTxjDWmQnu4o7R +kqs+JPqDTUpxOiRYw5Lr97cqfOoqd6B06FRJqdqYkKddynxuLkSyKdIqpHc14K9RWYg i4Ig== X-Gm-Message-State: AOJu0Yz5Tn23H65fVsiDbWcETa4PUSr+GsMdcJ9NY1ARW4jNoV9rTulb MPan9+a7mzbLM1X4CCRRZPGv+l1kvA2ueROdy5B8bRrVB53/6CHBrjaMcozBpRl1V+GThxlwhfz JJns6YUCxQ9A= X-Received: by 2002:a5d:6787:0:b0:313:fbd0:9810 with SMTP id v7-20020a5d6787000000b00313fbd09810mr2628780wru.4.1691705813860; Thu, 10 Aug 2023 15:16:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtLfNPGRKQt+xEbb3eLq+Srig0g08UmptGpsx6FqAE53yp4YBydO8+CdRSSlBgc3OvAUBYww== X-Received: by 2002:a5d:6787:0:b0:313:fbd0:9810 with SMTP id v7-20020a5d6787000000b00313fbd09810mr2628772wru.4.1691705813490; Thu, 10 Aug 2023 15:16:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:8a00:8200:f041:4b87:a8be? (p200300cbc71a8a008200f0414b87a8be.dip0.t-ipconnect.de. [2003:cb:c71a:8a00:8200:f041:4b87:a8be]) by smtp.gmail.com with ESMTPSA id j2-20020adfff82000000b003195504c754sm1657171wrr.31.2023.08.10.15.16.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 15:16:53 -0700 (PDT) Message-ID: <0ec6c371-c183-a8aa-614b-a23abbf3b233@redhat.com> Date: Fri, 11 Aug 2023 00:16:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Peter Xu Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Andrew Morton , Jonathan Corbet , Mike Kravetz , Hugh Dickins , "Matthew Wilcox (Oracle)" , Yin Fengwei , Yang Shi , Zi Yan References: <20230809083256.699513-1-david@redhat.com> <155bd03e-b75c-4d2d-a89d-a12271ada71b@arm.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH mm-unstable v1] mm: add a total mapcount for large folios In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C4B6FC0011 X-Rspam-User: X-Stat-Signature: mitqase1pbyd6grg9oteofdzbg458bne X-Rspamd-Server: rspam01 X-HE-Tag: 1691705816-238837 X-HE-Meta: U2FsdGVkX1/uK47rn2n4lDjQOI+PQH1BFc104ajaS+iEh/s3XFF9gy0phrIY6LkfdnqF5bPbTnfBao+VHY3zaMv2Jju2VOuMYapHWUNtdcNrkDCkzYFCdqPwKp9PF1F2xP6GbSLSwzNqPr3lYhII4nCV3jT8R+i4V4PaP87IYpb3NKWT+DezQIvOOKhmZPvaHwF/t6jK4kebt3I7joI+FklZATdBhhMmWSgdjAGCdWyBF3HdsPfLrowOlZiO/VTvkrKWyBp1PytscISF8MNJ+lEViWkjDe+eSJkBbI8dFeO1NXrwgneluTW3AKTT5DiA2cFtBcV74C5ly7CopcbuQUCjkXV0k0tLcg4Uz21ULpR+cbcXH+vaDlpd4cUaCtXhoCTbsOWU3cfsNFtGTcLcZJG0BdWhn9tWDbprWDRFVAQYSB4pYSAXmlbxhqUQvoWtNkHDKUovpARAF2LRhzOAFb/Zjoc9KqCb4qFxthrcml7we6X7/VDjcKMdB2sgODHiySvQZ4e/0F5D0HYKAazAJ3bmp8l7lGb6dAiIlNGt1U2OzrCELQX9hE9pTBvTw787/0L1oHS4zF9jTLRSXnSxtqJQIwR3ruo8GBORsRHqI66VkEO5s9PS+DNftJryFoSCWhxgB8OU9Tl1ZDHWJpMyYefu3e+f4py5Hjm072CeP83J2f39ctNvmW+MPUxQIafwVF/75YWQmc8NaYZI2Vj5O+dF954xkm5cHeXpxN/7NVptPCZaQx595t102RH1IZlqSRbGPPMicamVDr27cTm3qNVDXi6EzinIAULUqPCwNbB2xqxuwTBKSzObtS7XitG6J+oslHmZhdhTcM5ffIdKigYxwN9gNL5QP7tfmppS2R+nOTJ9DlW130MTbEKau4qevu7mljdt8S7mID49d1gURKDEzUpPhyPyVZZvliMPOZl8eFtJdozxUpPLDuRBcEv7KwJP53ihewzeoRKYvps ZeQ72rp5 NgswkdrSgJZHwLxQPkqHQB4GzL+TRl+WyWYID+RYfz3g7T9Uwb5UuPyZiGzWml2YkiFBbz9dRa2GKF1QvT3Ls1p7t0HF2bzg7hHcVIvmk1DQzzLquxtewDMZuQ22GnCakoyJ6mdYwoRY2ZTadkpdV+J9OC3NUrWIA2+ixlRljonvdcyy7m9n8AhRWhn9YxVaglJNfX1XoIrliV2S7PV8m3Yt11NSvjsc57EcahB2sWdo1bPzD9SK1tnv/eyfum1nmp6FZZrJvrCm/7CgzmF6YmWQJTwSsFmhbL9LvbD/MsYK52jZFZi0LyzWO/WXEJMeQ9KAszie/VEEusCahJFizezJI09Onb+SuOUSQTxbBP9gRDhfWDDvqThqTQRKUnVU29sGV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> Okay, so your speculation right now is: >> >> 1) The change in cacheline might be problematic. >> >> 2) The additional atomic operation might be problematic. >> >>> then measure the split (by e.g. mprotect() at offset 1M on a 4K?) time it >>> takes before/after this patch. >> >> I can certainly try getting some numbers on that. If you're aware of other >> micro-benchmarks that would likely notice slower pte-mapping of THPs, please >> let me know. > > Thanks. If I effectively only measure the real PTE->PMD remapping (only measure the for loop that mprotects() one 4k page inside each of 512 THPs ) without any of the mmap+populate+munmap, I can certainly measure a real difference. I briefly looked at some perf data across the overall benchmark runtime. For page_remove_rmap(), the new atomic_dec() doesn't seem to be significant. Data indicates that it's significantly less relevant than a later atomic_add_negative(). For page_add_anon_rmap(), it's a bit fuzzy. Definitely, the atomic_inc_return_relaxed(mapped) seems to stick out, but I cannot rule out that the atomic_add() also plays a role. The PTE->PMD remapping effectively does (__split_huge_pmd_locked()) for (i = 0, addr = haddr; i < HPAGE_PMD_NR; i++, addr += PAGE_SIZE) { ... page_add_anon_rmap(page + i, vma, addr, RMAP_NONE); ... } ... page_remove_rmap(page, vma, true); Inside that loop we're repeatedly accessing the total_mapcount and _nr_pages_mapped. So my best guess would have been that both are already hot in the cache. RMAP batching certainly sounds like a good idea for __split_huge_pmd_locked(), independent of this patch. What would probably also interesting is observing happens when we unmap a single PTE of a THP and we cannot batch, to see if the page_remove_rmap() matters in the bigger scale. I'll do some more digging tomorrow to clarify some details. Running some kernel compile tests with thp=always at least didn't reveal any surprises so far. -- Cheers, David / dhildenb