From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC54C3ABC3 for ; Wed, 7 May 2025 09:50:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A6A06B0085; Wed, 7 May 2025 05:50:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 855666B0088; Wed, 7 May 2025 05:50:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D2536B0089; Wed, 7 May 2025 05:50:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4CD196B0085 for ; Wed, 7 May 2025 05:50:25 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E8D591A18B4 for ; Wed, 7 May 2025 09:50:26 +0000 (UTC) X-FDA: 83415641652.04.8DAB045 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 74F6BA0006 for ; Wed, 7 May 2025 09:50:24 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=guquAJq7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746611424; a=rsa-sha256; cv=none; b=1cDspN5YyvaQrScLeSvVdOmN5sL6kfAeCqUfEZJyx3J5z7eDKPx+3DKQhkglnar2hQG8k8 RAFDehitrhh6zx4i8cq6bomX0pPA5nNg/dF96LXjap0sdZBkJF9rA+CyawcvAo3PL701rB Y3k7e4IOZ+OZ7IM52iD/XH3iq2dOvhE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=guquAJq7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746611424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WVKm+prTo91mCK4sWi9nK8ro46xY5ZiQCNeKWZ2n6iY=; b=OVfkQv+FDOAg09CEUyyOyRUwGEvKnGXJwA/B96hAou5gHpwaP/4wzeLE+AWU1ZODsJqjtQ D2n5UclAEqTtpXhB5FUS2aYDF/tvnH4XULKGcbMrak+Ue9k7s9jycNJP4dbJMkLDp/IlMn xVA5uJkVxdb15QoVv7Elt+8u6TDlYsw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746611423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WVKm+prTo91mCK4sWi9nK8ro46xY5ZiQCNeKWZ2n6iY=; b=guquAJq7LeZeomSYy3LDvyss2BGgbxsSpKiHVhj8lXKzEdnOpFLikcxJ5It1EcmNjfd3ph 1XMxzvYXHbp6FyxZFL7HgosAuQDzSns/y7DGy9aLT4Iza44mQ8yMtfJFe3zi704azw8GGz ypLmv8gXTM44xwWgEhhmb1vm25jOqnk= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-hOPMBkD2OzqYymvot_8ewQ-1; Wed, 07 May 2025 05:50:21 -0400 X-MC-Unique: hOPMBkD2OzqYymvot_8ewQ-1 X-Mimecast-MFC-AGG-ID: hOPMBkD2OzqYymvot_8ewQ_1746611420 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-74041404f8dso4136943b3a.0 for ; Wed, 07 May 2025 02:50:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746611420; x=1747216220; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WVKm+prTo91mCK4sWi9nK8ro46xY5ZiQCNeKWZ2n6iY=; b=KR167Li9/ST7KDVn/Eti8bLr1SulMINmSuNCq7BfChv1KatlTqJEKvPia0gI4jg7no AiveLRIINuImm3GfW9C+hYr3XVAhwWyiU+vK49T4i3w6/RIg4xGmGb+1xryGdrCYAI7Q gFLSxYzGksiQ+Jh3r7Q1E5zaiuuLtGALhOv+mupxLe8cMysmcpfdWtN9tpVwxv5JDy3X kflE+utSiBaZlkzoqUhDEoRAxjI9kD3mcTT96VC5HvOU+ufDyuU8p72Fb5GqOQ7HeIrE 5Za33h7sTtMf2QEsubn6FOU+3JbaZ/49ehaHbRyZBWPTjopGriLUfp3nhgc3CI7cygAc ncZw== X-Forwarded-Encrypted: i=1; AJvYcCVHyFHzcG+tG/c5+GZmcSGKNWWzivJJ5qSAbhl6EXrj10m8HAbkLIgrqy1kj0lhGodLWj/BCXnj1A==@kvack.org X-Gm-Message-State: AOJu0YwJYo+4kzxfDP27QoOReFsa++wpbZEsB4yMeQ5kl7HeUGbT4UFO ej9sq8uPOMsocjXnkL0qCCPQRHrqCaZx8MwVLTPiQNp2J+PROTmZ2hBDEBJ1SaZsXnTo6fEaWAy tks4hSbeO+zvNza8sGDy7nTlmxWvF44QiyibRIEyQlrmYoXvH X-Gm-Gg: ASbGnctVywrvB6SWZwIkgNIqgNsUNK+JCh+mqRqXAD//juhi2jRBKmhcTaNnevhbjEp 0kcrhXTa3PaDVkD7Px2pjNCVlDQs+cbyFxonA0WAxuvWbm/XZRTnbPVki1TOOStMolvlLm9kexg WaJk/lqaWWf/NfZxy4vPFtfy49nHmNFAsOoA+kdBzTTGDNx2G1Auncq9MD22ZBaltUPLtx2UKFm QJdnnMuwcp2pFlqLDvLfXtc1b+NUwdEh2YLQqZUjdvgUrdLp0gmzTCl83hgJ/aQlQQO3/hn/iPF 06lxGnbbQMdzI75Sh6zWTS9NB/2nEZ458dHdOs1VkuWToajg3Ukf9iosnwVVhzQYQ/abixElMv4 +1ziqOPm2R+QdNZ3EC2b4/Bk29CKg5MryFyiqj9Y= X-Received: by 2002:a05:6a00:2a06:b0:73e:2dc5:a93c with SMTP id d2e1a72fcca58-7409cf0f945mr3319248b3a.11.1746611420398; Wed, 07 May 2025 02:50:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVA37Uyq+XuIDleGXUMxF5Rlx1CmJawsIQUf6ZGk0Jxt0AkI56K7rfY3hb7Ni+UPjopi5iAA== X-Received: by 2002:a05:6a00:2a06:b0:73e:2dc5:a93c with SMTP id d2e1a72fcca58-7409cf0f945mr3319224b3a.11.1746611419983; Wed, 07 May 2025 02:50:19 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628? (p200300d82f12d400ed3cfb0c1ec0c628.dip0.t-ipconnect.de. [2003:d8:2f12:d400:ed3c:fb0c:1ec0:c628]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74058db8befsm10590578b3a.40.2025.05.07.02.50.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 02:50:19 -0700 (PDT) Message-ID: <0ec57b2e-0a1c-443f-89e1-608d5bccbf26@redhat.com> Date: Wed, 7 May 2025 11:50:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled To: Ignacio.MorenoGonzalez@kuka.com, lorenzo.stoakes@oracle.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250507-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v3-1-80929f30df7f@kuka.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250507-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v3-1-80929f30df7f@kuka.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _OHONzJVm8vx_PQg6gC9mM2S7blTbMQVyD6CgQVXL1A_1746611420 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 74F6BA0006 X-Stat-Signature: rsuiei7gg5de9w6jzdy8w555bfn7fjyt X-Rspam-User: X-HE-Tag: 1746611424-685864 X-HE-Meta: U2FsdGVkX1+HRWULPYP1dJwUR27lB1v/6LCHlK3k9IXRjU53bkTLU0IcDzfQo8EIQs4+OzQhGWwBQZuTtOhYZkhLltmrwWZtyDKGgPbpIxUK4ltUxgGeWOCgCVA5Q9teA9Xfsypjs+5kYOjW7BdoBnKIE/4Kjipqx2ple93Dwc3Q23Bhmz9FKzICmzwo+cxaMxdSOE975/G0DGFgaWev5VOOxDCg/PZB2B5IWtLhvpKL+vw0v7YQULvEbzrS0OU8e/w2UNejilW0XHVJJje35e7JiXGVEKRx9/lR1XqyewR2Ov+ai7mlXUybZajZ3xty0DwY7RBKnBhR5Bwn8FBzfQK1QHMqn843NBR6FTE0HCjPXto4OTArU/xk5t5sHdai7onvk9bynrfvlN8j+HnopF5/Qm2gWd7seVeawa5936lNVKmgdVmaIs+sTs4SKaNqzjBP/DCJkQZabpnGdzUmeONu17ldDiiD6T1+KgY/U9XvSFYqYwE0cs2KZ/NYm30K6+0bl/6Tjp20mQQR10+E5uTfqMrOhqjYlUCMvcbuKacC9jQC13SRM6KJG2Oyo9J3wseOaO9fbMybhkFcvNclWxQHaUYpYHOdsW/yEbsvJYv3HjPXAReqfAhr8CSBt7BQzTQZGTOHZRjACb2W8BNqVrtybyBC4OQEZEs1e+XMNbdGzygYj6QcVoETrIvx6lQJaPF5bRXWIyfK7rHtdWBHCcDDZ5+LWeyPHPevpGMWS3f1KDynbh7B1V+H1+lGbPMQHgNy5vAUNgsHb3QSfIRzJKunVllcJ0UH5/Jmy1qpBgX7oNHEj0nktnPf36LA5beMSaxxcEStkdygOVXBSMSH3C0jR2loxY2fIb55IbjQxEfziU75nshzlLhxvU1CGiUbFVwxbPW17RggkUTh+1yTXQdw3AXiKImB5Nn9nsmgh85HE5sqqiWi5AZ9mFGW2zdWbqjsK0Ycz+wY0YYTvWd ReQZJW9s 5L9G8ruEyLI3o0lyqyGBJxOVviXWBNkBvnL6UlPbpc9JriGveuHIC5g8vl/2RqQxNRsXUjjdncJcKTDO4kCRmGrtw1lVDy3E4AywIDPQGZqjDplbE+OtFhrgowRy6dxNVuklvab6JLE0kIUqmzvEupxzZZjHKT7BOc16xg9MQYyC2Y0fmnx85WtL/gFVpnR2PUkNs0n0EKhyLGsW4qbCMGUMA1pTB1K+YhKkENQfJ+aSYR7r6J1/6LA+89QXFN9fpyf+XemdTALA+bY7Q29WC1WdmEGANzgTzIi8pTgOpBHV0bgZad7EzaUEPaOioGQyOpSOOjF+t70foQIyZI+1v/yVTpeg8zmGBiUVRSZ6i+V63wxqLA65iNAgRg70zJbkAWo4Gh1+RM2CQ/GPK15ET59sgeX6LZmJSOWN5bNNa26iLk1rgLzAgMD1MQHJarozeYKLU573YJiOF+sqkmf7edUrUA3bTMLdLpcO4Q8clJePFtIqQWd6hZOXrZi1FJNEUi0ztPREZxLH7/ZgtyQqUshrgog/AJjt8R2HQ9pW11bL392e4AIELdoj0xK1GBF2vgxOUi01lYwr4juCRTHF+SIHgFtr7/3DFz7G89hW7trGDfUU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.25 11:11, Ignacio Moreno Gonzalez via B4 Relay wrote: > From: Ignacio Moreno Gonzalez > > commit c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") maps > the mmap option MAP_STACK to VM_NOHUGEPAGE. This is also done if > CONFIG_TRANSPARENT_HUGETABLES is not defined. But in that case, the > VM_NOHUGEPAGE does not make sense. > > Fixes: c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") > Cc: stable@vger.kernel.org > Reviewed-by: Lorenzo Stoakes > Reviewed-by: Yang Shi > Reviewed-by: Liam R. Howlett > Signed-off-by: Ignacio Moreno Gonzalez > --- > I discovered this issue when trying to use the tool CRIU to checkpoint > and restore a container. Our running kernel is compiled without > CONFIG_TRANSPARENT_HUGETABLES. CRIU parses the output of I'm sure you mean CONFIG_TRANSPARENT_HUGEPAGE ? > /proc//smaps and saves the "nh" flag. When trying to restore the > container, CRIU fails to restore the "nh" mappings, since madvise() > MADV_NOHUGEPAGE always returns an error because > CONFIG_TRANSPARENT_HUGETABLES is not defined. This should go into the patch description; it explains how this is actually causing issues. > > The mapping MAP_STACK -> VM_NOHUGEPAGE was introduced by commit > c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") in order to > fix a regression introduced by commit efa7df3e3bb5 ("mm: align larger > anonymous mappings on THP boundaries"). The change introducing the > regression (efa7df3e3bb5) was limited to THP kernels, but its fix > (c4608d1bf7c6) is applied without checking if THP is set. > > The mapping MAP_STACK -> VM_NOHUGEPAGE should only be applied if THP is > enabled. > --- > Changes in v3: > - Exclude non-stable patch (for huge_mm.h) from this series to avoid mixing stable and non-stable patches, as suggested by Andrew. > - Extend description in cover letter. > - Link to v2: https://lore.kernel.org/r/20250506-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v2-0-f11f0c794872@kuka.com > > Changes in v2: > - [Patch 1/2] Use '#ifdef' instead of '#if defined(...)' > - [Patch 1/2] Add 'Fixes: c4608d1bf7c6...' > - Create [Patch 2/2] > > - Link to v1: https://lore.kernel.org/r/20250502-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v1-1-113cc634cd51@kuka.com > --- > include/linux/mman.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/mman.h b/include/linux/mman.h > index bce214fece16b9af3791a2baaecd6063d0481938..f4c6346a8fcd29b08d43f7cd9158c3eddc3383e1 100644 > --- a/include/linux/mman.h > +++ b/include/linux/mman.h > @@ -155,7 +155,9 @@ calc_vm_flag_bits(struct file *file, unsigned long flags) > return _calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) | > _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | > _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > _calc_vm_trans(flags, MAP_STACK, VM_NOHUGEPAGE) | > +#endif > arch_calc_vm_flag_bits(file, flags); > } LGTM. I'm surprise we even have VM_NOHUGEPAGE on kernels ... without THP. I mean, as you say, even setting MADV_NOHUGEPAGE does not wrok. -- Cheers, David / dhildenb