From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A35C4167B for ; Fri, 8 Dec 2023 01:41:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5EBE6B006E; Thu, 7 Dec 2023 20:41:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0E556B0083; Thu, 7 Dec 2023 20:41:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813926B0087; Thu, 7 Dec 2023 20:41:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 701DB6B006E for ; Thu, 7 Dec 2023 20:41:09 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 425D01A0388 for ; Fri, 8 Dec 2023 01:41:09 +0000 (UTC) X-FDA: 81541947858.27.23DAD4A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf02.hostedemail.com (Postfix) with ESMTP id E044A80017 for ; Fri, 8 Dec 2023 01:41:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AZMDc9fI; spf=pass (imf02.hostedemail.com: domain of fengwei.yin@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701999666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wp53dzqv5V9i8XndcJRhwh6hr1J9ch/wTDcf/tQJhbc=; b=783JW+cEnjn2mUfExyPERjI2faDQCgMJDWgxoF92lfTTG3RUlu45LS4771BtZ0e474G6yH k6fLiUbBDAK+obLtiGTv3VhD88cV8EGwoJMg3gZa0RH87UMI8ZtH4NKE404QVgjaLI0MoN 9BPAw3Dpjxo1o/nzGzTvliH73GrBK/8= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AZMDc9fI; spf=pass (imf02.hostedemail.com: domain of fengwei.yin@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1701999666; a=rsa-sha256; cv=fail; b=A9fI1zuXhipiU3ssbdZ09akgcJc2HvQZVE06r67IjJE1AjD+sqCbWlb4hUoYv09M6Q97u9 JAw0IImFnfkBPkFUKTc0NMTFcexv9aIAWd1Xn4vDz5JyiAZqpPkxQZEiop6Dy+WVKFQBIv 2WvV3QiPkWyKL1K0G4fHXdi1ycrWnOg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701999665; x=1733535665; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=DiO4UeZS0doj2OLCMUqyoHZY/pfgokyrxrC5PdhHnGU=; b=AZMDc9fIkycMNGNMVPKZdpClxqAZEd/A+taoz9nZGFvaFqmNptwbaGSG 7NZvolSlhh0oxzKdjI47veYJLGVy+X6CvEq20RB479H1Rz1NBeI5/h/AM Qkg3h99oja3ON1raogrYNPGUwe94j6EC+7p8RP12mh+7Ji4qUhUm/4kz+ h8N0E2ZjkaYOblQE8MRpDXaf721yvnHuJCyFdDk76S2vhCH48hMxjXTKM p0ciI7z8scajpSg4yC4HzuMc5LKVE0TvqMPL3bSuqmvzsAtBs1K9sVdlk wu1LAcR2TlTZ65xuZoymQoXxfqgPa/q+VbrmOhK6qCzOlm0VMH7Ei7kQ1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="1409179" X-IronPort-AV: E=Sophos;i="6.04,259,1695711600"; d="scan'208";a="1409179" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 17:41:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="915780923" X-IronPort-AV: E=Sophos;i="6.04,259,1695711600"; d="scan'208";a="915780923" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Dec 2023 17:41:03 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 17:41:02 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 17:41:02 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 7 Dec 2023 17:41:02 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 7 Dec 2023 17:41:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N43b87c3LQLB3cjgO4/mKiNFxPzO+4tbMmSitSryOVxJdiS1XyOalgsUkd/IhSMNE7hf7FudhtM8PDsQJPxDdz1sf63l7ftl4dkWt2JxxrKCbYE0ijcH70tPq40LifxcIxlI8oTTuS60e+on0ZIc4e31R1DaH1zoKY1/XsMWUapdYQmHy2QFe6b4nWrcTJ5n+AkiV9BMZW3IMaWl7Ykg/sTr4gEDp+VrXigN7qMuES1KmjDOUEpFSShFe6xdwYywvbps3FYnCZWnpo7HzhbYxmqccHdX6T8Li2vKRDctdKmhwo0Q4sMGbdy5SB0Mal2Ka1dlqOT2mYFVvPUmkQRpFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wp53dzqv5V9i8XndcJRhwh6hr1J9ch/wTDcf/tQJhbc=; b=MoCKxhGxTQcwhy0udF/UUn2DK8J8QOQmJDIbAgrynxVyfXs89GTMqJYLaRd0acxMKqtVNl1q0RzgBeovr2qFhs2WfXB3Z3qoxZhYRDlbrnMXlZ8FigioEfmqt7LP1/x93OIzwEtEfEIy0R/Gp6DbMst9CZsD1sQoY5jYi0FmJibMKkol0Soiqjm2j+ZcTRguAT4WO/YL/zyIjrjJWOBoXnAPdZNcxj+ovrCxqnH+BLApmO+c0EBaFR1zikTnEzE7rsBBOZOiV1bmYHu6dG/NFCT2pdr7VT0j0CFvVWoE/PW7ncyjTeI3j6faQoEzcIDpRGkrSnb4kq4C3a92DV0cfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by PH7PR11MB8504.namprd11.prod.outlook.com (2603:10b6:510:2fe::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Fri, 8 Dec 2023 01:41:00 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::3d83:82ce:9f3b:7e20]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::3d83:82ce:9f3b:7e20%5]) with mapi id 15.20.7068.027; Fri, 8 Dec 2023 01:41:00 +0000 Message-ID: <0ec525a5-5ee5-4254-9c4b-340fc9de0db0@intel.com> Date: Fri, 8 Dec 2023 09:40:52 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 08/39] mm/memory: page_add_file_rmap() -> folio_add_file_rmap_[pte|pmd]() Content-Language: en-US To: David Hildenbrand , CC: , Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-9-david@redhat.com> From: "Yin, Fengwei" In-Reply-To: <20231204142146.91437-9-david@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI1PR02CA0001.apcprd02.prod.outlook.com (2603:1096:4:1f7::15) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|PH7PR11MB8504:EE_ X-MS-Office365-Filtering-Correlation-Id: 26292f66-0646-4944-909a-08dbf78ebafc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: day6tuoclej1qW116er4v1AHN5HofPIxZC+2PXhgJ4LOIeipv+AUu3UNN7REKPUjiU6pGkQEyjZpE50O5BiAh4EHoTHKUgfq7e+I+rjh6H+g1ZGrdkY760fPMmcMdcwd1U7CATdlP54kXkP4qoACRl6rWxC/R5HqyQ6PqEovXsaASlBST7dbuNdGvrVyS5nh4fOODa3nNTUKnj6NRWa5JswjBcmScbdbaYpNFPOdfoxIejlRDa05QzmnDMpvLZQJPVCXaCYhsEFXIqL5Gh/KEJFte6+e+X+76rl4nFvv4KtKGMKMRtgs6uYpw01WfgZZKR4wsr57Q3zeuq1FelaRLmuKI+t430XQdxok9v9rKMPN3TlehiDTYgQEOWzCr3bzccnkcNH8EmdKh1EqsqUuYgNG5vzJYpQ7X3ZDcCGsg5OBVMureUUgkX+wwHNmMumRqxJHSIqlI/bYzgsY9b7djoIXr6nIdIsqx6BhnMlt5LK2DKKgRzLkkIxGj2EgjHfI6A7kjGEfoXBEh09H+l7CZlyFltS7YDFwd94NdKI9LvtclAQrhCW/ktI/4xvMaOSlJu16JCn1xhU9G0GgaZj1zMfy/J84nBJ0/Zc4QxMCKItx9YqSa3ku1/wkniLhGYDPS8W600NYiLvkjPQ8q5UgwxuJeK4UEkvQ24yRj2aZiXBBQwKB/+c7mhZwBor4i3lBmE0rxalXtMBIZ9ZSIC8FZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(346002)(396003)(376002)(366004)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(66946007)(66556008)(5660300002)(66476007)(54906003)(478600001)(6486002)(2906002)(8676002)(4326008)(6666004)(7416002)(316002)(31686004)(8936002)(6506007)(53546011)(6512007)(26005)(2616005)(83380400001)(41300700001)(86362001)(38100700002)(36756003)(31696002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cldZaVg5N0NpSTdSTkxOa0NWM1VVMkVmUVEvYjZBVVdDclpBZ01OcXVtOHVV?= =?utf-8?B?K3JiYmU5aGtxd1lMam84YjNqOUhuU1h0RStEai9lZUVaR2FEd2ZsdkxVZVhk?= =?utf-8?B?cmNVSUU2Z3hWcmNnTERqeGpsTUJHUWp5OEJhZ29kQzBiSlJQMm5Dc0J2NVlz?= =?utf-8?B?OEluZG1MbzNMUXNXeE9qN0xzVnVERk52UEJCc0J6clFlRkdNVi9hWUtRYlZt?= =?utf-8?B?TEtDK29kWmY3S0NKbTZpWFA3THpWbm0xQ3JTRk5QOUNmclZFUEtVTitWQzZl?= =?utf-8?B?ck1abnFOcHdjWWNCa2liYmNReENKb0RTdzM5TlgyRXJxWW5JVk5wdUcyUllC?= =?utf-8?B?bDZ6cklabkRUbENpY3VFSGNqZTViTCtkSWIrR0ltcUN2SkdSV3JVQ1dEK2kv?= =?utf-8?B?NHprc3U4UTVYcmxhNEZtRDI1MHB2WkN0MitMVmVZUlN4VGMzem5adUdweFlv?= =?utf-8?B?MW9uSkd2MWhLd3ZJejNHWFltOFdHWnljWlFIQngwbE1wSktsdjdDclRGZWFq?= =?utf-8?B?alVqa21JNXVVREVmZHVPWlZYV01iaEJ6d1d1cnhXdVo2SDNrTlVzMWxPOUhC?= =?utf-8?B?ZmNFQzJmSzdwamZOTFljL0dpOWJENkJvYzN0akpWSHpxL0lCaFlGMXBPblhj?= =?utf-8?B?VklkbWJrRzk0YlhsMWhyV3hUK29TSEozaWJFd2VTeEh2OTlzZXVTbEpUVDF6?= =?utf-8?B?d0tjNHExbWY4akVkc2EwY09tNGVuNmhONVVBMDFwWjNPL0ZKcXdNbmlla3I2?= =?utf-8?B?ZW9UaW10eEFlV1ViZytpTXBZYlM1alFEN1ppNmQ4VGdWblpFYWVTMjhwNTVK?= =?utf-8?B?SzlHL1NIUUp4K2I4aDFMTDRCcnF3YjNwY2dWQ0hxb0diT0taRVh6WUppTlVv?= =?utf-8?B?VUNMMXZzeFJlQ3ZjaTZEYzlLd2FNNW9kRC9mdmFLYzVEUjg5aVJxNFhtMVNz?= =?utf-8?B?cWZDREFPV3pLWm9ybDFXWExOU1hCemhaSDlUUGUyZVhySEFKaEtZM1poYXVk?= =?utf-8?B?ZGkxUEhsT2cwZlQ5cWsxOXNxSG9FRGxnaGtVdjJUcjE5dmh4WnlBZnJyUk44?= =?utf-8?B?Yk9MUm1WZi9tUEZEZzIzN2ZZNHkrejYzV01SV0h6SkNqa3VUSWd2WTRoMlIv?= =?utf-8?B?MVp2SHlSL1V3RVNTUVNWU1RsQ0RHTDJYMURIRnd5L2JrWU95MmhjMnNEVDI5?= =?utf-8?B?MXptcGJvdzJKeWRvaGFXeUpyM05JcXBOODJBeTNUZEMrcnZHY0VRYzg1b0Zy?= =?utf-8?B?cUU5cjVvY2pYYXRleDkybFFoVTdUOWx0OTRnYndObWZhaWpUYytDZi8zRytZ?= =?utf-8?B?NUlLemdyQlNyNkowYlpVVTFqNzhEbGI1SFVydHJiOWJzQ0RzUVJwSVViZGZn?= =?utf-8?B?TGVZUXF0enp6azR3SE5IbnJzR3NkNUZLUGx3NHFJdHR1dFRrQzYyQmlWeXQx?= =?utf-8?B?THVweHJrRHNib0dsbFBleHRBOFVwUzF3U1RweU04alc1SFJtU1FLQ1p6cjkx?= =?utf-8?B?dS82TERSVWVyL0VTZDVSdDZYaHgvVndWTjJ3MDcxRXBjbWJ6c2xGRWlzSjQy?= =?utf-8?B?NTY2MEVRVjNOVzdqUFRHSVJYZEJjdjdlMVdhejJtemdBM0t6djU3Sk5wK2c5?= =?utf-8?B?L2VYTFI1MHNtMDFkT0cycDluNXhISDN2VFZWMk5VZ2VJNGl3cTFkSlRQVFht?= =?utf-8?B?cU90WVZhUVhhM3BwQkh2czFyMEtubWFKTHVNbUsvM25BMlpiZ0ZtK1hIejc4?= =?utf-8?B?RDNPOUwyb09NenZvaXdIelNQV1ZjL2ZzVDhMS2VaeUgyNkZ1NHA2ZFBlWGNK?= =?utf-8?B?K3lSSEdZVjJJUEE5QWVydXJ0dzVHUnhFaVRqYnpNYkxORlJQQ0tjNktOZGxI?= =?utf-8?B?R3lqL1hwYTVnd0xkSHRpYktBWHpFT1lWOXByNWxuQ0JRTFJ3NEpnUElOWWRS?= =?utf-8?B?REYxcWVBbm1DYWhqSUVvMHlFS0x0ZURXOXd2NGNzMDZiUFIzMG1DUVVmUnF0?= =?utf-8?B?QmFHZVZJSWdJVkt4bjhVbDZGeGIzV25nbjZlZXFzT3pGcG5mdkxod2k5YThM?= =?utf-8?B?aDVXY28wbFhJYkVnZHRoYlFlWkFxQno4Z3FIRk1hVmRXamV1ekFqNllhMlJC?= =?utf-8?Q?EmU+eoWsCDQmJiA9Y482rqJNd?= X-MS-Exchange-CrossTenant-Network-Message-Id: 26292f66-0646-4944-909a-08dbf78ebafc X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 01:41:00.0768 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9/Co97M4jBC/++HTXryxMsnUdt0agrnfcazBt6C8sritFz1Nv+4JoBlfNoUw+RLjuBKAl1DIVizr+rHmrnSWtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8504 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: E044A80017 X-Rspam-User: X-Stat-Signature: q3nagc4ymhqwm1zjeygwsdcp3ydqx6zd X-Rspamd-Server: rspam01 X-HE-Tag: 1701999664-776058 X-HE-Meta: U2FsdGVkX18TJEunCMGZIlsBQVH51pt9aaNogzgM6Rw7uC80+h0TGlWgTst15AtI9ipHJCtyiEJaOaa6rLv93QOHIUAk9GGNswa6zbb8sNYuvZjmsPyX9YE7PpVFnunpssdrTImlq/LN/2Fxkw3Kna990l3dBDv/QPgtywRa77/FiIGOYlZkj3W8wnnfZrUw+NqvwitTLyk+abgpZmWRI+vZQP9pHbjkwBLLU1A51utA/DgKw0zhzsdYCYOqR2tYRBk7Dm+/KkhMQfEcgB4d8ep+2+Scym9l+/x5mJzzTa2m/arM4RXbY5L4p0L5mScLyTC9r441yPUjN9q3Beu9FC0kU/M+bh9zaSC6LXuLFopbPntcZDq5pugldVN2ZM+9+3nB3LxrHs+cAnIKr969HxFWlFvUxDgB1mMHE7ZypXoZa5Z4GFzMzlZA8/cUQH7nJYfx5CaIq9YephCPXPkQYGSL3BZIiMPuOVuQ9gkFjkKkk3esrxIjx4l8Aed8SmlWufCl5RFmiOIu2MSnkF0ZzVUmEy9fpC7oqFAUbmrLltLv5xfQNukfFoBYSMTLxTNTVj0BUoiupzNqVGVoRrTheGg8fAYRgmhsziq3baLo8u1oY7JcPWs53Sm65m2eADMTI2LUguf524Lk+6m5QnxSLLl6QXYOdX4yRaaZNMZ8VhM0/E9evfYHZBH4U7ZR/Y5gRxFFf7osuBiUKSx6JAnj3HAv0gAPGYmplgj9qNU8cx/PABUzZDnxNthRraZgMBjvVYoJhj780p59oNIejJfbFkeQbB+z3Kx/Kp+4KbTjfXylgTZl5jD1rfA3w7NB9se9P9FaWirl15GnUtQcmXB9x8NP3iKJ9qKDcmPbeUbeogsMunIhV41h8uqIYGOsuqWrWsdANbCp+3wZV9VN1Fq50FwgjdDksOAtVnIDN8VWCfzcKoU7KCUbVJ+eZ5f+0TwYdSnPvtd6pwlPpPxbKy/ O/y1TJ7J Ddhv8ZiHiG5nWNp2Q0wh2KF98XV0ioPvaKl13p8cQFwiNKbQsOAFkMzFCepjXT32NiGQ758ncH7y3KPLMm2Y1UPupYC3+mNpT1eEmioPeVXWRpPMVTrxge/m/FmvNNZt3dI71kJmGqKErD5R3De6ofgKfV9aehtM18PnZbEc9FdSd9qf3DhtIX11Q3IJTv3uc4X5CCowC5idY0gDRrQuL64+rU9ThkCj7x94bPiFD6wUGzcTZDz1/CY3q9xMS5DY8HBZqVEa4KDOHNoI19GuPSC3DZmINcQd73slnkufu1So+aBW1hys8cLIR9tISYPTTB6kErsNiB76sT4yWHgwOjZo8nfNJw/YBis0L4OJyrdVotvM/e/UwS5vgZfGpEZXWQ8Y22VFNaQljWmqvg2Qx0oMNQsMye5KapzKi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/4/2023 10:21 PM, David Hildenbrand wrote: > Let's convert insert_page_into_pte_locked() and do_set_pmd(). While at it, > perform some folio conversion. > > Signed-off-by: David Hildenbrand Reviewed-by: Yin Fengwei Yes. I make sure my RB tag this time. :). Regards Yin, Fengwei > --- > mm/memory.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 15325587cff01..be7fe58f7c297 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1845,12 +1845,14 @@ static int validate_page_before_insert(struct page *page) > static int insert_page_into_pte_locked(struct vm_area_struct *vma, pte_t *pte, > unsigned long addr, struct page *page, pgprot_t prot) > { > + struct folio *folio = page_folio(page); > + > if (!pte_none(ptep_get(pte))) > return -EBUSY; > /* Ok, finally just insert the thing.. */ > - get_page(page); > + folio_get(folio); > inc_mm_counter(vma->vm_mm, mm_counter_file(page)); > - page_add_file_rmap(page, vma, false); > + folio_add_file_rmap_pte(folio, page, vma); > set_pte_at(vma->vm_mm, addr, pte, mk_pte(page, prot)); > return 0; > } > @@ -4308,6 +4310,7 @@ static void deposit_prealloc_pte(struct vm_fault *vmf) > > vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > { > + struct folio *folio = page_folio(page); > struct vm_area_struct *vma = vmf->vma; > bool write = vmf->flags & FAULT_FLAG_WRITE; > unsigned long haddr = vmf->address & HPAGE_PMD_MASK; > @@ -4317,8 +4320,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > if (!transhuge_vma_suitable(vma, haddr)) > return ret; > > - page = compound_head(page); > - if (compound_order(page) != HPAGE_PMD_ORDER) > + if (page != &folio->page || folio_order(folio) != HPAGE_PMD_ORDER) > return ret; > > /* > @@ -4327,7 +4329,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > * check. This kind of THP just can be PTE mapped. Access to > * the corrupted subpage should trigger SIGBUS as expected. > */ > - if (unlikely(PageHasHWPoisoned(page))) > + if (unlikely(folio_test_has_hwpoisoned(folio))) > return ret; > > /* > @@ -4351,7 +4353,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > entry = maybe_pmd_mkwrite(pmd_mkdirty(entry), vma); > > add_mm_counter(vma->vm_mm, mm_counter_file(page), HPAGE_PMD_NR); > - page_add_file_rmap(page, vma, true); > + folio_add_file_rmap_pmd(folio, page, vma); > > /* > * deposit and withdraw with pmd lock held