From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE69C021AA for ; Wed, 19 Feb 2025 19:33:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 715DA44017E; Wed, 19 Feb 2025 14:33:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C4AB440179; Wed, 19 Feb 2025 14:33:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C92644017E; Wed, 19 Feb 2025 14:33:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 32A87440179 for ; Wed, 19 Feb 2025 14:33:11 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9691281A95 for ; Wed, 19 Feb 2025 19:33:10 +0000 (UTC) X-FDA: 83137692540.28.60E5F9E Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf21.hostedemail.com (Postfix) with ESMTP id A562B1C001B for ; Wed, 19 Feb 2025 19:33:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ibLRg9pq; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739993588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CUsy+0kApC5qMhd0jpaY7wTCtuXpI7Fu0gfENiFAKxQ=; b=qXIzdMn3oIuh+H98slBXlpEX8PdTmIHwGw/5dqRY0PVeDdrze9ckdF/KIduFQ9Mg1wfRYz D0McOX9ZaPm+zSo+j6FRlc7mNoeHFekYWFxMsDtgwHw/osVulAda2QUg+ick0YFyo046/j TGdJMeHGUF3/a69uon8W79X/w6guM98= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ibLRg9pq; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739993588; a=rsa-sha256; cv=none; b=ETnmKajJ1bdPyiKbtxvKSROMNWNWpt9thlRfVIvULeMr+F82OMpGMh/+P0EQoiNKGem2FN pS3hargxJO5X8YljAz3mxyY5ZZKeh81d87QnRet6brt8vt6fCJUrj4T8iGk489Cz6met7M f8pbjx69b7ruZ+rhyrPEmjhgqgoB8cE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739993587; x=1771529587; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=alXYuPS0FINh9Nm9P5MiVyVk+9+fDhZvqgT5JAY4svw=; b=ibLRg9pqmVKFBPoVzQ2JEdGDKU+pwAZC7WiedSNiBu3BrP399MTKxR4D P37PhJCCMd6hqJXn+mYYRjqMtPSAcPzHQxn28k0r9UyuRJ4qlxOAD5SF1 9uQEyI+n1utZz+6I+E5AkMkJhWGo7LpQtKyzXD3fLXGJtHG1AMIavE1+U a3Ql4Ao+M9NuVn+JpXBBlFvL8PzdNmSYSrGW0xsldKYjxiYVrebcqMCXQ V3EglR+sI7rOncKXB7+CaHl9PO2PMOPljtkcacyihstTmLJc9Jtc3G/H/ RPj/HBAFuw6tEHdEqT93yHKx4Lxn6+besBgDzOFHB98pz23cuHlIKB6/w Q==; X-CSE-ConnectionGUID: zQZU06b1SA2tW3GwnqYXlQ== X-CSE-MsgGUID: /LWwghDvRUiedR6C37y2PQ== X-IronPort-AV: E=McAfee;i="6700,10204,11350"; a="44665145" X-IronPort-AV: E=Sophos;i="6.13,299,1732608000"; d="scan'208";a="44665145" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2025 11:33:05 -0800 X-CSE-ConnectionGUID: qmAl5OaIR7aoFqIIOv6vDA== X-CSE-MsgGUID: s4N8mZO9TfuSeGmxmFrj6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="120021039" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.109.250]) ([10.125.109.250]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2025 11:26:09 -0800 Message-ID: <0ebdfab1-09c6-475f-bcf8-366a321359a0@intel.com> Date: Wed, 19 Feb 2025 11:26:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 04/12] x86/mm: get INVLPGB count max from CPUID To: Rik van Riel , Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-5-riel@surriel.com> <20250219115626.GMZ7XG6s-5ftg1XLoZ@fat_crate.local> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A562B1C001B X-Stat-Signature: bjhbxo6sa89t5cjzy74x9ur7gkwoemxd X-Rspamd-Server: rspam03 X-HE-Tag: 1739993587-23257 X-HE-Meta: U2FsdGVkX19hjelwTW+dFz1k3/w7vDyeBNs5XrP+xGBFRNr9Q2ofd8jhR6NSyTtzgNnwbqlJ+G4XrWGg+FbcHsx0zBlZpDqDjNS2ToMB3vRmL8c6AzP+dS4+6vAym0vEgbV8gnJvcjkZI/8XLv9k38ukyaJUyDQVPQbicIJHvVIP9n+sYKQf3kkQK87NlsWDnLAGAmSTkIm5HkyA+rnGXkHIqzg+JRZDHKV+0H7X9FW0C02GBKpYvZL5NRfcb+v1j4y6ffTF4cBangCdirHbBrLoY/eFUA2LgJIxFra9eYPFxDA6gn96jIznaWCR9ApLpMh2tEMxeFcQTTZszDLZV01zMs3oENs1aGeY24PJkFzivqe3k1No4iANTpdEGcszllxqERNFw0DiMHdQlDF5QL8ISte/yFGLZw2yoM7ojKP90a7UiiqIf7X1zhyK9nENKGFhMDFut7M3NgvjSMFzVVGlhAOA3YLmOzohxQH7j4pef5nIve8J0mM4xnF6EtsCCpDfJk2+dgcxMnNZ6+pyLqxDmpffLszEYtWDCTDU+RvuCVRP3aLTHVwkwrn31I4/txBjeN74iabhoaXGMuc8gQOsavE/crquCFp3htU0ta0KwBVKgMzy+2wu4BuN5jOd9rhv43ZB7GXw3Xnf/0RDhpfBWljlzIm/Xo2QaIErmS2DEuXBPGilLFYh71cwT+C4LWQE9Vr5V5ib41WFui4QnWx//DyIlcQJoOX41Fv8t91Klbt7MXLv9Gtq5Akz2wf6jPNY1DKzWn6Ppa4OW4LrqRtaiLn8JWAm84ifoNtzLj0oDh53UohXST1jQhICmhatnvAcUHYnhyXpF9Hmm/+F+NQIRT1F03eAh1ZO77RlyoX2cJp8DpxSDa4mY8CnjlNxmsGrE6+KLwT+3nOY6dJLXP2j7ghsZhkN5YZcXfzXYKIXNsVAZ0rUXwLBzu6ndBJc6wKtjDKcvROoFa9v7o2 8UQNgNCU MUy1lExwmZzyzxpVhiZO3WtrNROv6HM1C11y8coq/5geJqZ0yQQkcSUu7/v6ZCbSJyLhbMHdfCnA84iv0NdSNq/Xs7jNWrSuf9kYJZ8AKYFPekkAhX7jeraZodWPj7Wc0+M++AUiifiqkwBbG1ZRrACzfjvs6aTTozUTvLIAoBpH0XbRbcjT1IvGrFKBnIio1f/QaLq8clPzzfwjDs4ldADYaNtdTjzpaCMGtT8iIRTZC4NffNsyeceFmYDk4MswzQmh+Xka7llbeTIpp4HE4yBaX4Fo3h78WoBEqdjjlAVqZj4y7Ne2a/0HQc9MpgAb8JEjdRAox0uy4ga7lTvdsBTid+9zwqMjmJahO3eXfbuFT0T3bsbcnK388sa7zh3unVHfX+Qojsyo6eQ6mSmdaHReHFYq/KR0LxB1eVq4+Nv5Oje9TnqqXzNrlLz5CHntBX0zdTzxu8ow/CR5WABw9jutxG85VQvjfT3g6qC5Em1RRi0Wl5D+Ie2i2Q47+2Bp+h6UYTouvm2Ei8LBJLW+xgm1tWYhd+I8b6WSnGUpWeUTfZ1LF7so8UQKhyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/25 09:52, Rik van Riel wrote: >> CPU_SUP_AMD selects X86_BROADCAST_TLB_FLUSH which depends on >> CPU_SUP_AMD which >> selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD... >> >> Why do you really need yet another Kconfig symbol? Just whack >> X86_BROADCAST_TLB_FLUSH - it'll be enabled by default on everything >> anyway. > Dave specifically asked me to do things that way. Yeah, I'm in camp "moar Kconfig!" and Boris is in camp "too many Kconfigs!". I'm OK getting rid of the Kconfig as long as we have _some_ other way to nicely identify the INVLPGB code (which I think the X86_FEATURE gives us) _and_ that the overhead isn't too bad from leaving it compiled in all the time. The mmu_context is the one place that's kinda nasty without a Kconfig option. I guess it's only a few bytes but it's a super silly waste of a few bytes on i386, for example. I also really like the _logical_ clarity that comes from something like: +#ifdef CONFIG_X86_BROADCAST_TLB_FLUSH + u16 global_asid; + bool asid_transition; +#endif as opposed to: +#ifdef CONFIG_64BIT + /* Only used with X86_FEATURE_INVLPGB */ + u16 global_asid; + bool asid_transition; +#endif So, while I respect Boris's concern about Kconfig proliferation, I see the user-invisible ones (the ones without a prompt) as pretty harmless. Sorry for the maintainer crossfire, btw. I definitely don't want to be thrashing you around too much.